2025-02-11 20:07:51 +01:00
#!/usr/bin/env bash
2026-01-06 13:28:12 +01:00
# Copyright (c) 2021-2026 community-scripts ORG
2025-02-11 20:07:51 +01:00
# Author: michelroegl-brunner
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
2025-04-01 10:25:46 +02:00
source /dev/stdin <<< $( curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func)
2025-02-11 20:07:51 +01:00
function header_info {
clear
2025-04-15 15:20:46 +02:00
cat <<"EOF"
2025-12-03 04:48:12 -03:00
____ ____ _ __
/ __ \/ __ \/ | / /_______ ____ ________
2025-02-11 20:07:51 +01:00
/ / / / /_/ / | / / ___/ _ \/ __ \/ ___/ _ \
/ /_/ / ____/ /| ( __ ) __/ / / ( __ ) __/
2025-12-03 04:48:12 -03:00
\_ ___/_/ /_/ | _/____/\_ __/_/ /_/____/\_ __/
2025-02-11 20:07:51 +01:00
EOF
}
header_info
echo -e "Loading..."
#API VARIABLES
RANDOM_UUID = " $( cat /proc/sys/kernel/random/uuid) "
METHOD = ""
NSAPP = "opnsense-vm"
var_os = "opnsense"
2025-12-07 02:36:47 -06:00
var_version = "25.7"
2025-02-11 20:07:51 +01:00
#
GEN_MAC = 02:$( openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//' )
GEN_MAC_LAN = 02:$( openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//' )
2025-05-07 12:37:46 +02:00
2025-02-11 20:07:51 +01:00
YW = $( echo "\033[33m" )
BL = $( echo "\033[36m" )
HA = $( echo "\033[1;34m" )
RD = $( echo "\033[01;31m" )
BGN = $( echo "\033[4;92m" )
GN = $( echo "\033[1;92m" )
DGN = $( echo "\033[32m" )
CL = $( echo "\033[m" )
BFR = "\\r\\033[K"
HOLD = "-"
CM = " ${ GN } ✓ ${ CL } "
CROSS = " ${ RD } ✗ ${ CL } "
set -Eeo pipefail
trap 'error_handler $LINENO "$BASH_COMMAND"' ERR
trap cleanup EXIT
2026-02-23 14:30:48 +01:00
trap 'post_update_to_api "failed" "130"' SIGINT
trap 'post_update_to_api "failed" "143"' SIGTERM
trap 'post_update_to_api "failed" "129"; exit 129' SIGHUP
2025-02-11 20:07:51 +01:00
function error_handler( ) {
local exit_code = " $? "
local line_number = " $1 "
local command = " $2 "
Archlinux-VM: fix LVM/LVM-thin storage and improve error reporting | VM's add correct exit_code for analytics (#11842)
* fix(archlinux-vm): fix LVM/LVM-thin storage and improve error reporting
- Add catch-all (*) case for storage types (LVM, LVM-thin, zfspool)
Previously only nfs/dir/cifs and btrfs were handled, leaving
DISK_EXT, DISK_REF, and DISK_IMPORT unset on LVM/LVM-thin storage
- Fix error_handler to send numeric exit_code to API instead of
bash command text (which caused 'Unknown error' in telemetry)
- Replace fragile pvesm alloc for EFI disk with Proxmox-managed
:0,efitype=4m (consistent with docker-vm.sh)
- Modernize disk import: auto-detect qm disk import vs qm importdisk,
parse output to get correct disk reference instead of guessing names
- Use --format flag (double dash) consistent with modern Proxmox API
- Remove unused FORMAT variable (EFI type now always set correctly)
- Remove fragile eval-based disk name construction
* fix(vm): fix LVM/LVM-thin storage and error reporting for all VM scripts
- Add catch-all (*) case to storage type detection in all VM scripts
that were missing it (debian-vm, debian-13-vm, ubuntu2204/2404/2504,
nextcloud-vm, owncloud-vm, opnsense-vm, pimox-haos-vm)
- Add catch-all to mikrotik-routeros (had zfspool but not lvm/lvmthin)
- Fix error_handler in ALL 14 VM scripts to send numeric exit_code
to post_update_to_api instead of bash command text, which caused
'Unknown error' in telemetry because the API expects a number
2026-02-12 20:06:02 +01:00
post_update_to_api "failed" " $exit_code "
2025-02-11 20:07:51 +01:00
local error_message = " ${ RD } [ERROR] ${ CL } in line ${ RD } $line_number ${ CL } : exit code ${ RD } $exit_code ${ CL } : while executing command ${ YW } $command ${ CL } "
echo -e " \n $error_message \n "
cleanup_vmid
}
2025-05-07 12:37:46 +02:00
function get_valid_nextid( ) {
local try_id
try_id = $( pvesh get /cluster/nextid)
while true; do
if [ -f " /etc/pve/qemu-server/ ${ try_id } .conf " ] || [ -f " /etc/pve/lxc/ ${ try_id } .conf " ] ; then
try_id = $(( try_id + 1 ))
continue
fi
if lvs --noheadings -o lv_name | grep -qE " (^|[-_]) ${ try_id } ( $|[-_]) " ; then
try_id = $(( try_id + 1 ))
continue
fi
break
done
echo " $try_id "
}
2025-02-11 20:07:51 +01:00
function cleanup_vmid( ) {
2025-04-09 18:35:17 +02:00
if qm status $VMID & >/dev/null; then
qm stop $VMID & >/dev/null
qm destroy $VMID & >/dev/null
2025-02-11 20:07:51 +01:00
fi
}
function cleanup( ) {
core/vm's: ensure script state is sent on script exit (#11991)
* Ensure API update is sent on script exit
Add exit-time telemetry handling across scripts to avoid orphaned "installing" records. Introduce local exit_code capture in api_exit_script and cleanup handlers and, when POST_TO_API_DONE is true but POST_UPDATE_DONE is not, post a final status (marking failures on non-zero exit codes, or marking done/failed in VM cleanups based on exit code). Changes touch misc/build.func, misc/vm-core.func and various vm/*-vm.sh cleanup functions to reliably send post_update_to_api on normal or early exits.
* Update api.func
* fix(telemetry): add missing exit codes to explain_exit_code()
- Add curl error codes: 4, 5, 8, 23, 25, 30, 56, 78
- Add code 10: Docker/privileged mode required (used in ~15 scripts)
- Add code 75: Temporary failure (retry later)
- Add BSD sysexits.h codes: 64-77
- Sync error_handler.func fallback with canonical api.func
2026-02-16 17:14:00 +01:00
local exit_code = $?
2025-02-11 20:07:51 +01:00
popd >/dev/null
core/vm's: ensure script state is sent on script exit (#11991)
* Ensure API update is sent on script exit
Add exit-time telemetry handling across scripts to avoid orphaned "installing" records. Introduce local exit_code capture in api_exit_script and cleanup handlers and, when POST_TO_API_DONE is true but POST_UPDATE_DONE is not, post a final status (marking failures on non-zero exit codes, or marking done/failed in VM cleanups based on exit code). Changes touch misc/build.func, misc/vm-core.func and various vm/*-vm.sh cleanup functions to reliably send post_update_to_api on normal or early exits.
* Update api.func
* fix(telemetry): add missing exit codes to explain_exit_code()
- Add curl error codes: 4, 5, 8, 23, 25, 30, 56, 78
- Add code 10: Docker/privileged mode required (used in ~15 scripts)
- Add code 75: Temporary failure (retry later)
- Add BSD sysexits.h codes: 64-77
- Sync error_handler.func fallback with canonical api.func
2026-02-16 17:14:00 +01:00
if [ [ " ${ POST_TO_API_DONE :- } " = = "true" && " ${ POST_UPDATE_DONE :- } " != "true" ] ] ; then
if [ [ $exit_code -eq 0 ] ] ; then
post_update_to_api "done" "none"
else
post_update_to_api "failed" " $exit_code "
fi
fi
2025-04-09 18:35:17 +02:00
rm -rf $TEMP_DIR
2025-02-11 20:07:51 +01:00
}
2026-02-18 22:06:04 +01:00
function check_disk_space( ) {
local path = " $1 "
local required_gb = " $2 "
local available_kb = $( df -k " $path " | awk 'NR==2 {print $4}' )
local available_gb = $(( available_kb / 1024 / 1024 ))
if [ $available_gb -lt $required_gb ] ; then
return 1
fi
return 0
}
2025-02-11 20:07:51 +01:00
TEMP_DIR = $( mktemp -d)
2025-04-09 18:35:17 +02:00
pushd $TEMP_DIR >/dev/null
2025-02-11 20:07:51 +01:00
function send_line_to_vm( ) {
echo -e " ${ DGN } Sending line: ${ YW } $1 ${ CL } "
for ( ( i = 0; i < ${# 1 } ; i++) ) ; do
character = ${ 1 : i : 1 }
case $character in
" " ) character = "spc" ; ;
"-" ) character = "minus" ; ;
"=" ) character = "equal" ; ;
"," ) character = "comma" ; ;
"." ) character = "dot" ; ;
"/" ) character = "slash" ; ;
"'" ) character = "apostrophe" ; ;
";" ) character = "semicolon" ; ;
'\' ) character = "backslash" ; ;
'`' ) character = "grave_accent" ; ;
"[" ) character = "bracket_left" ; ;
"]" ) character = "bracket_right" ; ;
"_" ) character = "shift-minus" ; ;
"+" ) character = "shift-equal" ; ;
"?" ) character = "shift-slash" ; ;
"<" ) character = "shift-comma" ; ;
">" ) character = "shift-dot" ; ;
'"' ) character = "shift-apostrophe" ; ;
":" ) character = "shift-semicolon" ; ;
"|" ) character = "shift-backslash" ; ;
"~" ) character = "shift-grave_accent" ; ;
"{" ) character = "shift-bracket_left" ; ;
"}" ) character = "shift-bracket_right" ; ;
"A" ) character = "shift-a" ; ;
"B" ) character = "shift-b" ; ;
"C" ) character = "shift-c" ; ;
"D" ) character = "shift-d" ; ;
"E" ) character = "shift-e" ; ;
"F" ) character = "shift-f" ; ;
"G" ) character = "shift-g" ; ;
"H" ) character = "shift-h" ; ;
"I" ) character = "shift-i" ; ;
"J" ) character = "shift-j" ; ;
"K" ) character = "shift-k" ; ;
"L" ) character = "shift-l" ; ;
"M" ) character = "shift-m" ; ;
"N" ) character = "shift-n" ; ;
"O" ) character = "shift-o" ; ;
"P" ) character = "shift-p" ; ;
"Q" ) character = "shift-q" ; ;
"R" ) character = "shift-r" ; ;
"S" ) character = "shift-s" ; ;
"T" ) character = "shift-t" ; ;
"U" ) character = "shift-u" ; ;
"V" ) character = "shift-v" ; ;
"W" ) character = "shift-w" ; ;
2025-12-03 04:48:12 -03:00
"X" ) character = "shift-x" ; ;
2025-02-11 20:07:51 +01:00
"Y" ) character = "shift-y" ; ;
"Z" ) character = "shift-z" ; ;
"!" ) character = "shift-1" ; ;
"@" ) character = "shift-2" ; ;
"#" ) character = "shift-3" ; ;
'$' ) character = "shift-4" ; ;
"%" ) character = "shift-5" ; ;
"^" ) character = "shift-6" ; ;
"&" ) character = "shift-7" ; ;
"*" ) character = "shift-8" ; ;
"(" ) character = "shift-9" ; ;
")" ) character = "shift-0" ; ;
esac
2025-04-09 18:35:17 +02:00
qm sendkey $VMID " $character "
2025-02-11 20:07:51 +01:00
done
2025-04-09 18:35:17 +02:00
qm sendkey $VMID ret
2025-02-11 20:07:51 +01:00
}
2025-02-12 11:05:08 +01:00
if ( whiptail --backtitle "Proxmox VE Helper Scripts" --title "OPNsense VM" --yesno "This will create a New OPNsense VM. Proceed?" 10 58) ; then
2025-02-11 20:07:51 +01:00
:
else
header_info && echo -e "⚠ User exited script \n" && exit
fi
function msg_info( ) {
local msg = " $1 "
echo -ne " ${ HOLD } ${ YW } ${ msg } ... "
}
function msg_ok( ) {
local msg = " $1 "
echo -e " ${ BFR } ${ CM } ${ GN } ${ msg } ${ CL } "
}
function msg_error( ) {
local msg = " $1 "
echo -e " ${ BFR } ${ CROSS } ${ RD } ${ msg } ${ CL } "
}
2025-08-06 13:46:07 +02:00
# This function checks the version of Proxmox Virtual Environment (PVE) and exits if the version is not supported.
2025-11-22 14:35:13 +01:00
# Supported: Proxmox VE 8.0.x – 8.9.x, 9.0 and 9.1
2025-07-28 11:00:09 +02:00
pve_check( ) {
local PVE_VER
PVE_VER = " $( pveversion | awk -F'/' '{print $2}' | awk -F'-' '{print $1}' ) "
2025-08-06 13:46:07 +02:00
# Check for Proxmox VE 8.x: allow 8.0– 8.9
2025-07-28 11:00:09 +02:00
if [ [ " $PVE_VER " = ~ ^8\. ( [ 0-9] +) ] ] ; then
local MINOR = " ${ BASH_REMATCH [1] } "
2025-08-06 13:46:07 +02:00
if ( ( MINOR < 0 || MINOR > 9) ) ; then
2025-07-28 11:00:09 +02:00
msg_error "This version of Proxmox VE is not supported."
2025-08-06 13:46:07 +02:00
msg_error "Supported: Proxmox VE version 8.0 – 8.9"
core: standardize exit codes and add mappings (#12467)
* Standardize exit codes and add mappings
Replace generic exit 1 usages with specific numeric exit codes and add corresponding explanations to the error lookup. This commit updates multiple misc/* scripts to return distinct codes for validation, Proxmox/LXC, networking, download and curl errors (e.g. 103-123, 64, 107-120, 206, 0 for explicit user cancels). It also updates curl error handling to propagate the original curl exit code and adds new entries in explain_exit_code and the error handler to improve diagnostics.
* Set exit code 115 for update_os errors
Change exit status from 6 to 115 in misc/alpine-install.func's update_os() error handlers when failing to download tools.func or when the expected functions are missing. This gives a distinct exit code for these specific failure cases.
* Add tools/addon exit codes and use them
Introduce exit codes 232-238 for Tools & Addon scripts in misc/api.func and misc/error_handler.func. Update addon scripts (tools/addon/adguardhome-sync.sh, tools/addon/copyparty.sh, tools/addon/cronmaster.sh) to return specific codes instead of generic exit 1: 238 for unsupported OS and 233 when the application is not installed/upgrade prerequisites are missing. This makes failures more descriptive and aligns scripts with the central error explanations.
* Standardize exit codes in exporter addons
Unify exit codes across exporter addon scripts: return 238 for unsupported OS detections and 233 when an update is requested but the exporter is not installed. Applied to nextcloud-exporter.sh, pihole-exporter.sh, prometheus-paperless-ngx-exporter.sh, and qbittorrent-exporter.sh to make failure modes distinguishable for callers/automation.
* Use specific exit codes in addon scripts
Replace generic exit 1 with distinct exit codes across multiple addon scripts to enable finer-grained error handling in automation. Exit codes introduced: 10 for Docker/Compose missing or user-declined Docker install, 233 for "nothing to update" cases, and 238 for unsupported OS cases. Affected files: tools/addon/arcane.sh, coolify.sh, dockge.sh, dokploy.sh, filebrowser-quantum.sh, filebrowser.sh, immich-public-proxy.sh, jellystat.sh, runtipi.sh.
* Use specific exit codes in addon scripts
Replace generic exit 1 with specific exit codes across multiple addon scripts to improve error signaling and handling. Files updated: tools/addon/add-netbird-lxc.sh (exit 238 on unsupported distro), tools/addon/add-tailscale-lxc.sh (treat user cancel as exit 0), tools/addon/glances.sh (exit 233 when not installed), tools/addon/komodo.sh (distinct exits for missing compose, legacy DB, backup/download failures, docker checks), tools/addon/netdata.sh (distinct exits for unsupported PVE versions, OS/codename detection, repo lookups), and tools/addon/phpmyadmin.sh (distinct exits for unsupported OS, network/download issues, package install/start failures, and invalid input). These changes make failures easier to identify and automate recovery or reporting.
* Use specific exit codes in PVE scripts
Replace generic exit 1 with distinct exit codes across tools/pve scripts to provide clearer failure signals for callers. post-pve-install.sh now returns 105 for unsupported Proxmox versions; pve-privilege-converter.sh uses 104 for non-root, 234 when no containers, and 235 for backup/conversion failures; update-apps.sh maps backup failures to 235, missing containers/selections to 234 (and UI cancellations to 0), missing backup storage to 119, and returns the actual container update exit code on failure. These changes improve diagnostics and allow external tooling to react to specific error conditions.
* Standardize exit codes and behaviors
Adjust exit codes and abort handling across multiple PVE helper scripts to provide clearer outcomes for automation and interactive flows. Changes include:
- container-restore-from-backup.sh, core-restore-from-backup.sh: return 235 when no backups found (was 1).
- fstrim.sh: treat user cancellation of non-ext4 warning as non-error (exit 0 instead of 1).
- kernel-clean.sh: treat no selection or user abort as non-error (exit 0 instead of 1).
- lxc-delete.sh: return 234 when no containers are present; treat no selection as non-error (exit 0).
- nic-offloading-fix.sh: use specific non-zero codes for root check and tool install failures (exit 104, 237) and 236 when no matching interfaces (was 1).
- pbs_microcode.sh, post-pmg-install.sh, post-pbs-install.sh: use distinct exit codes (232 and 105) for detected VM/PVE/unsupported distro conditions instead of generic 1.
These modifications make scripts return distinct codes for different failure modes and ensure user-initiated aborts or benign conditions exit with 0 where appropriate.
* Use exit 105 for unsupported PVE versions
Standardize error handling by replacing generic exit 1 with exit 105 in pve_check() across multiple VM template scripts to indicate unsupported Proxmox VE versions. Also add API exit code 226 message for "Proxmox: VM disk import or post-creation setup failed" in misc/api.func. Affected files include misc/api.func and various vm/*-vm.sh scripts.
* Use specific exit codes in VM scripts
Replace generic exit 1 with distinct exit codes across vm/*.sh to make failures more actionable for callers. Changes include: use 226 for missing imported-disk references, 237 for pv installation failures, 115 for download/extract/ISO-related failures, 214 for insufficient disk space during FreeBSD decompression, and 119 for missing storage detection. Updated scripts: archlinux-vm.sh, docker-vm.sh, haos-vm.sh, openwrt-vm.sh, opnsense-vm.sh, truenas-vm.sh, umbrel-os-vm.sh.
2026-03-02 10:55:20 +01:00
exit 105
2025-07-28 11:00:09 +02:00
fi
return 0
2025-02-11 20:07:51 +01:00
fi
2025-07-28 11:00:09 +02:00
2025-11-22 14:35:13 +01:00
# Check for Proxmox VE 9.x: allow 9.0 and 9.1
2025-07-28 11:00:09 +02:00
if [ [ " $PVE_VER " = ~ ^9\. ( [ 0-9] +) ] ] ; then
2025-08-06 13:46:07 +02:00
local MINOR = " ${ BASH_REMATCH [1] } "
2025-11-22 14:35:13 +01:00
if ( ( MINOR < 0 || MINOR > 1) ) ; then
msg_error "This version of Proxmox VE is not supported."
msg_error "Supported: Proxmox VE version 9.0 – 9.1"
core: standardize exit codes and add mappings (#12467)
* Standardize exit codes and add mappings
Replace generic exit 1 usages with specific numeric exit codes and add corresponding explanations to the error lookup. This commit updates multiple misc/* scripts to return distinct codes for validation, Proxmox/LXC, networking, download and curl errors (e.g. 103-123, 64, 107-120, 206, 0 for explicit user cancels). It also updates curl error handling to propagate the original curl exit code and adds new entries in explain_exit_code and the error handler to improve diagnostics.
* Set exit code 115 for update_os errors
Change exit status from 6 to 115 in misc/alpine-install.func's update_os() error handlers when failing to download tools.func or when the expected functions are missing. This gives a distinct exit code for these specific failure cases.
* Add tools/addon exit codes and use them
Introduce exit codes 232-238 for Tools & Addon scripts in misc/api.func and misc/error_handler.func. Update addon scripts (tools/addon/adguardhome-sync.sh, tools/addon/copyparty.sh, tools/addon/cronmaster.sh) to return specific codes instead of generic exit 1: 238 for unsupported OS and 233 when the application is not installed/upgrade prerequisites are missing. This makes failures more descriptive and aligns scripts with the central error explanations.
* Standardize exit codes in exporter addons
Unify exit codes across exporter addon scripts: return 238 for unsupported OS detections and 233 when an update is requested but the exporter is not installed. Applied to nextcloud-exporter.sh, pihole-exporter.sh, prometheus-paperless-ngx-exporter.sh, and qbittorrent-exporter.sh to make failure modes distinguishable for callers/automation.
* Use specific exit codes in addon scripts
Replace generic exit 1 with distinct exit codes across multiple addon scripts to enable finer-grained error handling in automation. Exit codes introduced: 10 for Docker/Compose missing or user-declined Docker install, 233 for "nothing to update" cases, and 238 for unsupported OS cases. Affected files: tools/addon/arcane.sh, coolify.sh, dockge.sh, dokploy.sh, filebrowser-quantum.sh, filebrowser.sh, immich-public-proxy.sh, jellystat.sh, runtipi.sh.
* Use specific exit codes in addon scripts
Replace generic exit 1 with specific exit codes across multiple addon scripts to improve error signaling and handling. Files updated: tools/addon/add-netbird-lxc.sh (exit 238 on unsupported distro), tools/addon/add-tailscale-lxc.sh (treat user cancel as exit 0), tools/addon/glances.sh (exit 233 when not installed), tools/addon/komodo.sh (distinct exits for missing compose, legacy DB, backup/download failures, docker checks), tools/addon/netdata.sh (distinct exits for unsupported PVE versions, OS/codename detection, repo lookups), and tools/addon/phpmyadmin.sh (distinct exits for unsupported OS, network/download issues, package install/start failures, and invalid input). These changes make failures easier to identify and automate recovery or reporting.
* Use specific exit codes in PVE scripts
Replace generic exit 1 with distinct exit codes across tools/pve scripts to provide clearer failure signals for callers. post-pve-install.sh now returns 105 for unsupported Proxmox versions; pve-privilege-converter.sh uses 104 for non-root, 234 when no containers, and 235 for backup/conversion failures; update-apps.sh maps backup failures to 235, missing containers/selections to 234 (and UI cancellations to 0), missing backup storage to 119, and returns the actual container update exit code on failure. These changes improve diagnostics and allow external tooling to react to specific error conditions.
* Standardize exit codes and behaviors
Adjust exit codes and abort handling across multiple PVE helper scripts to provide clearer outcomes for automation and interactive flows. Changes include:
- container-restore-from-backup.sh, core-restore-from-backup.sh: return 235 when no backups found (was 1).
- fstrim.sh: treat user cancellation of non-ext4 warning as non-error (exit 0 instead of 1).
- kernel-clean.sh: treat no selection or user abort as non-error (exit 0 instead of 1).
- lxc-delete.sh: return 234 when no containers are present; treat no selection as non-error (exit 0).
- nic-offloading-fix.sh: use specific non-zero codes for root check and tool install failures (exit 104, 237) and 236 when no matching interfaces (was 1).
- pbs_microcode.sh, post-pmg-install.sh, post-pbs-install.sh: use distinct exit codes (232 and 105) for detected VM/PVE/unsupported distro conditions instead of generic 1.
These modifications make scripts return distinct codes for different failure modes and ensure user-initiated aborts or benign conditions exit with 0 where appropriate.
* Use exit 105 for unsupported PVE versions
Standardize error handling by replacing generic exit 1 with exit 105 in pve_check() across multiple VM template scripts to indicate unsupported Proxmox VE versions. Also add API exit code 226 message for "Proxmox: VM disk import or post-creation setup failed" in misc/api.func. Affected files include misc/api.func and various vm/*-vm.sh scripts.
* Use specific exit codes in VM scripts
Replace generic exit 1 with distinct exit codes across vm/*.sh to make failures more actionable for callers. Changes include: use 226 for missing imported-disk references, 237 for pv installation failures, 115 for download/extract/ISO-related failures, 214 for insufficient disk space during FreeBSD decompression, and 119 for missing storage detection. Updated scripts: archlinux-vm.sh, docker-vm.sh, haos-vm.sh, openwrt-vm.sh, opnsense-vm.sh, truenas-vm.sh, umbrel-os-vm.sh.
2026-03-02 10:55:20 +01:00
exit 105
2025-07-28 11:00:09 +02:00
fi
2025-08-06 13:46:07 +02:00
return 0
2025-07-28 11:00:09 +02:00
fi
# All other unsupported versions
msg_error "This version of Proxmox VE is not supported."
2025-11-22 14:35:13 +01:00
msg_error "Supported versions: Proxmox VE 8.0 – 8.x or 9.0 – 9.1"
core: standardize exit codes and add mappings (#12467)
* Standardize exit codes and add mappings
Replace generic exit 1 usages with specific numeric exit codes and add corresponding explanations to the error lookup. This commit updates multiple misc/* scripts to return distinct codes for validation, Proxmox/LXC, networking, download and curl errors (e.g. 103-123, 64, 107-120, 206, 0 for explicit user cancels). It also updates curl error handling to propagate the original curl exit code and adds new entries in explain_exit_code and the error handler to improve diagnostics.
* Set exit code 115 for update_os errors
Change exit status from 6 to 115 in misc/alpine-install.func's update_os() error handlers when failing to download tools.func or when the expected functions are missing. This gives a distinct exit code for these specific failure cases.
* Add tools/addon exit codes and use them
Introduce exit codes 232-238 for Tools & Addon scripts in misc/api.func and misc/error_handler.func. Update addon scripts (tools/addon/adguardhome-sync.sh, tools/addon/copyparty.sh, tools/addon/cronmaster.sh) to return specific codes instead of generic exit 1: 238 for unsupported OS and 233 when the application is not installed/upgrade prerequisites are missing. This makes failures more descriptive and aligns scripts with the central error explanations.
* Standardize exit codes in exporter addons
Unify exit codes across exporter addon scripts: return 238 for unsupported OS detections and 233 when an update is requested but the exporter is not installed. Applied to nextcloud-exporter.sh, pihole-exporter.sh, prometheus-paperless-ngx-exporter.sh, and qbittorrent-exporter.sh to make failure modes distinguishable for callers/automation.
* Use specific exit codes in addon scripts
Replace generic exit 1 with distinct exit codes across multiple addon scripts to enable finer-grained error handling in automation. Exit codes introduced: 10 for Docker/Compose missing or user-declined Docker install, 233 for "nothing to update" cases, and 238 for unsupported OS cases. Affected files: tools/addon/arcane.sh, coolify.sh, dockge.sh, dokploy.sh, filebrowser-quantum.sh, filebrowser.sh, immich-public-proxy.sh, jellystat.sh, runtipi.sh.
* Use specific exit codes in addon scripts
Replace generic exit 1 with specific exit codes across multiple addon scripts to improve error signaling and handling. Files updated: tools/addon/add-netbird-lxc.sh (exit 238 on unsupported distro), tools/addon/add-tailscale-lxc.sh (treat user cancel as exit 0), tools/addon/glances.sh (exit 233 when not installed), tools/addon/komodo.sh (distinct exits for missing compose, legacy DB, backup/download failures, docker checks), tools/addon/netdata.sh (distinct exits for unsupported PVE versions, OS/codename detection, repo lookups), and tools/addon/phpmyadmin.sh (distinct exits for unsupported OS, network/download issues, package install/start failures, and invalid input). These changes make failures easier to identify and automate recovery or reporting.
* Use specific exit codes in PVE scripts
Replace generic exit 1 with distinct exit codes across tools/pve scripts to provide clearer failure signals for callers. post-pve-install.sh now returns 105 for unsupported Proxmox versions; pve-privilege-converter.sh uses 104 for non-root, 234 when no containers, and 235 for backup/conversion failures; update-apps.sh maps backup failures to 235, missing containers/selections to 234 (and UI cancellations to 0), missing backup storage to 119, and returns the actual container update exit code on failure. These changes improve diagnostics and allow external tooling to react to specific error conditions.
* Standardize exit codes and behaviors
Adjust exit codes and abort handling across multiple PVE helper scripts to provide clearer outcomes for automation and interactive flows. Changes include:
- container-restore-from-backup.sh, core-restore-from-backup.sh: return 235 when no backups found (was 1).
- fstrim.sh: treat user cancellation of non-ext4 warning as non-error (exit 0 instead of 1).
- kernel-clean.sh: treat no selection or user abort as non-error (exit 0 instead of 1).
- lxc-delete.sh: return 234 when no containers are present; treat no selection as non-error (exit 0).
- nic-offloading-fix.sh: use specific non-zero codes for root check and tool install failures (exit 104, 237) and 236 when no matching interfaces (was 1).
- pbs_microcode.sh, post-pmg-install.sh, post-pbs-install.sh: use distinct exit codes (232 and 105) for detected VM/PVE/unsupported distro conditions instead of generic 1.
These modifications make scripts return distinct codes for different failure modes and ensure user-initiated aborts or benign conditions exit with 0 where appropriate.
* Use exit 105 for unsupported PVE versions
Standardize error handling by replacing generic exit 1 with exit 105 in pve_check() across multiple VM template scripts to indicate unsupported Proxmox VE versions. Also add API exit code 226 message for "Proxmox: VM disk import or post-creation setup failed" in misc/api.func. Affected files include misc/api.func and various vm/*-vm.sh scripts.
* Use specific exit codes in VM scripts
Replace generic exit 1 with distinct exit codes across vm/*.sh to make failures more actionable for callers. Changes include: use 226 for missing imported-disk references, 237 for pv installation failures, 115 for download/extract/ISO-related failures, 214 for insufficient disk space during FreeBSD decompression, and 119 for missing storage detection. Updated scripts: archlinux-vm.sh, docker-vm.sh, haos-vm.sh, openwrt-vm.sh, opnsense-vm.sh, truenas-vm.sh, umbrel-os-vm.sh.
2026-03-02 10:55:20 +01:00
exit 105
2025-02-11 20:07:51 +01:00
}
function arch_check( ) {
if [ " $( dpkg --print-architecture) " != "amd64" ] ; then
echo -e " \n ${ CROSS } This script will not work with PiMox! \n "
echo -e "Exiting..."
sleep 2
exit
fi
}
function ssh_check( ) {
if command -v pveversion >/dev/null 2>& 1; then
if [ -n " ${ SSH_CLIENT : +x } " ] ; then
if whiptail --backtitle "Proxmox VE Helper Scripts" --defaultno --title "SSH DETECTED" --yesno "It's suggested to use the Proxmox shell instead of SSH, since SSH can create issues while gathering variables. Would you like to proceed with using SSH?" 10 62; then
echo "you've been warned"
else
clear
exit
fi
fi
fi
}
function exit-script( ) {
clear
echo -e "⚠ User exited script \n"
exit
}
function default_settings( ) {
2025-05-07 12:37:46 +02:00
VMID = $( get_valid_nextid)
2025-02-11 20:07:51 +01:00
FORMAT = ",efitype=4m"
MACHINE = ""
DISK_CACHE = ""
HN = "opnsense"
CPU_TYPE = ""
CORE_COUNT = "4"
RAM_SIZE = "8192"
BRG = "vmbr0"
IP_ADDR = ""
WAN_IP_ADDR = ""
LAN_GW = ""
WAN_GW = ""
NETMASK = ""
WAN_NETMASK = ""
VLAN = ""
MAC = $GEN_MAC
WAN_MAC = $GEN_MAC_LAN
WAN_BRG = "vmbr1"
MTU = ""
START_VM = "yes"
METHOD = "default"
echo -e " ${ DGN } Using Virtual Machine ID: ${ BGN } ${ VMID } ${ CL } "
echo -e " ${ DGN } Using Hostname: ${ BGN } ${ HN } ${ CL } "
echo -e " ${ DGN } Allocated Cores: ${ BGN } ${ CORE_COUNT } ${ CL } "
echo -e " ${ DGN } Allocated RAM: ${ BGN } ${ RAM_SIZE } ${ CL } "
2026-02-25 17:31:41 +01:00
if ! ip link show " ${ BRG } " & >/dev/null; then
msg_error " Bridge ' ${ BRG } ' does not exist "
2025-04-15 15:20:46 +02:00
exit
2025-02-11 20:07:51 +01:00
else
echo -e " ${ DGN } Using LAN Bridge: ${ BGN } ${ BRG } ${ CL } "
fi
echo -e " ${ DGN } Using LAN VLAN: ${ BGN } Default ${ CL } "
echo -e " ${ DGN } Using LAN MAC Address: ${ BGN } ${ MAC } ${ CL } "
2025-12-03 04:48:12 -03:00
if NETWORK_MODE = $( whiptail --backtitle "Proxmox VE Helper Scripts" --title "NETWORK CONFIGURATION" --radiolist --cancel-button Exit-Script \
"Choose network setup mode for OPNsense:\n" 14 70 2 \
"dual" "Dual Interface (Traditional Firewall/Router)" ON \
"single" "Single Interface (Proxy/VPN/IDS Server)" OFF \
3>& 1 1>& 2 2>& 3) ; then
if [ " $NETWORK_MODE " = "dual" ] ; then
echo -e " ${ DGN } Network Mode: ${ BGN } Dual Interface (Firewall) ${ CL } "
echo -e " ${ DGN } Using WAN MAC Address: ${ BGN } ${ WAN_MAC } ${ CL } "
2026-02-25 17:31:41 +01:00
if ! ip link show " ${ WAN_BRG } " & >/dev/null; then
msg_error " Bridge ' ${ WAN_BRG } ' does not exist "
2025-12-03 04:48:12 -03:00
exit
else
echo -e " ${ DGN } Using WAN Bridge: ${ BGN } ${ WAN_BRG } ${ CL } "
fi
else
echo -e " ${ DGN } Network Mode: ${ BGN } Single Interface (Proxy/VPN/IDS) ${ CL } "
WAN_BRG = ""
fi
2025-02-11 20:07:51 +01:00
else
2025-12-03 04:48:12 -03:00
exit-script
2025-02-11 20:07:51 +01:00
fi
echo -e " ${ DGN } Using Interface MTU Size: ${ BGN } Default ${ CL } "
echo -e " ${ DGN } Start VM when completed: ${ BGN } yes ${ CL } "
2025-02-12 11:05:08 +01:00
echo -e " ${ BL } Creating a OPNsense VM using the above default settings ${ CL } "
2025-02-11 20:07:51 +01:00
}
function advanced_settings( ) {
local ip_regex = '^([0-9]{1,3})\.([0-9]{1,3})\.([0-9]{1,3})\.([0-9]{1,3})$'
METHOD = "advanced"
2025-05-07 12:37:46 +02:00
[ -z " ${ VMID :- } " ] && VMID = $( get_valid_nextid)
2025-02-11 20:07:51 +01:00
while true; do
2025-05-07 12:37:46 +02:00
if VMID = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
2025-02-11 20:07:51 +01:00
if [ -z " $VMID " ] ; then
2025-05-07 12:37:46 +02:00
VMID = $( get_valid_nextid)
2025-02-11 20:07:51 +01:00
fi
if pct status " $VMID " & >/dev/null || qm status " $VMID " & >/dev/null; then
echo -e " ${ CROSS } ${ RD } ID $VMID is already in use ${ CL } "
sleep 2
continue
fi
echo -e " ${ DGN } Virtual Machine ID: ${ BGN } $VMID ${ CL } "
break
else
exit-script
fi
done
if MACH = $( whiptail --backtitle "Proxmox VE Helper Scripts" --title "MACHINE TYPE" --radiolist --cancel-button Exit-Script "Choose Type" 10 58 2 \
"i440fx" "Machine i440fx" ON \
"q35" "Machine q35" OFF \
3>& 1 1>& 2 2>& 3) ; then
2025-04-09 18:35:17 +02:00
if [ $MACH = q35 ] ; then
2025-02-11 20:07:51 +01:00
echo -e " ${ DGN } Using Machine Type: ${ BGN } $MACH ${ CL } "
FORMAT = ""
MACHINE = " -machine q35"
else
echo -e " ${ DGN } Using Machine Type: ${ BGN } $MACH ${ CL } "
FORMAT = ",efitype=4m"
MACHINE = ""
fi
else
exit-script
fi
if CPU_TYPE1 = $( whiptail --backtitle "Proxmox VE Helper Scripts" --title "CPU MODEL" --radiolist "Choose" --cancel-button Exit-Script 10 58 2 \
"0" "KVM64 (Default)" ON \
"1" "Host" OFF \
3>& 1 1>& 2 2>& 3) ; then
2025-04-09 18:35:17 +02:00
if [ $CPU_TYPE1 = "1" ] ; then
2025-02-11 20:07:51 +01:00
echo -e " ${ DGN } Using CPU Model: ${ BGN } Host ${ CL } "
CPU_TYPE = " -cpu host"
else
echo -e " ${ DGN } Using CPU Model: ${ BGN } KVM64 ${ CL } "
CPU_TYPE = ""
fi
else
exit-script
fi
if DISK_CACHE = $( whiptail --backtitle "Proxmox VE Helper Scripts" --title "DISK CACHE" --radiolist "Choose" --cancel-button Exit-Script 10 58 2 \
"0" "None (Default)" ON \
"1" "Write Through" OFF \
3>& 1 1>& 2 2>& 3) ; then
2025-04-09 18:35:17 +02:00
if [ $DISK_CACHE = "1" ] ; then
2025-02-11 20:07:51 +01:00
echo -e " ${ DGN } Using Disk Cache: ${ BGN } Write Through ${ CL } "
DISK_CACHE = "cache=writethrough,"
else
echo -e " ${ DGN } Using Disk Cache: ${ BGN } None ${ CL } "
DISK_CACHE = ""
fi
else
exit-script
fi
2025-02-12 11:05:08 +01:00
if VM_NAME = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Hostname" 8 58 OPNsense --title "HOSTNAME" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
2025-12-03 04:48:12 -03:00
if [ -z " $VM_NAME " ] ; then
2025-02-12 11:05:08 +01:00
HN = "OPNsense"
2025-02-11 20:07:51 +01:00
else
2025-04-09 18:35:17 +02:00
HN = $( echo ${ VM_NAME ,, } | tr -d ' ' )
2025-02-11 20:07:51 +01:00
fi
echo -e " ${ DGN } Using Hostname: ${ BGN } $HN ${ CL } "
else
exit-script
fi
if CORE_COUNT = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Allocate CPU Cores" 8 58 4 --title "CORE COUNT" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
2025-12-03 04:48:12 -03:00
if [ -z " $CORE_COUNT " ] ; then
2025-02-11 20:07:51 +01:00
CORE_COUNT = "2"
fi
echo -e " ${ DGN } Allocated Cores: ${ BGN } $CORE_COUNT ${ CL } "
else
exit-script
fi
if RAM_SIZE = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Allocate RAM in MiB" 8 58 8192 --title "RAM" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
2025-04-09 18:35:17 +02:00
if [ -z $RAM_SIZE ] ; then
2025-02-11 20:07:51 +01:00
RAM_SIZE = "8192"
fi
echo -e " ${ DGN } Allocated RAM: ${ BGN } $RAM_SIZE ${ CL } "
else
exit-script
fi
if BRG = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a LAN Bridge" 8 58 vmbr0 --title "LAN BRIDGE" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
2025-04-09 18:35:17 +02:00
if [ -z $BRG ] ; then
2025-02-11 20:07:51 +01:00
BRG = "vmbr0"
fi
2026-02-25 17:31:41 +01:00
if ! ip link show " ${ BRG } " & >/dev/null; then
msg_error " Bridge ' ${ BRG } ' does not exist "
2025-02-11 20:07:51 +01:00
exit
fi
echo -e " ${ DGN } Using LAN Bridge: ${ BGN } $BRG ${ CL } "
else
exit-script
fi
2025-04-09 18:35:17 +02:00
if IP_ADDR = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a LAN IP" 8 58 $IP_ADDR --title "LAN IP ADDRESS" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
if [ -z $IP_ADDR ] ; then
2025-02-11 20:07:51 +01:00
echo -e " ${ DGN } Using DHCP AS LAN IP ADDRESS ${ CL } "
else
if [ [ -n " $IP_ADDR " && ! " $IP_ADDR " = ~ $ip_regex ] ] ; then
msg_error " Invalid IP Address format for LAN IP. Needs to be 0.0.0.0, was $IP_ADDR "
exit
fi
echo -e " ${ DGN } Using LAN IP ADDRESS: ${ BGN } $IP_ADDR ${ CL } "
2025-04-09 18:35:17 +02:00
if LAN_GW = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a LAN GATEWAY IP" 8 58 $LAN_GW --title "LAN GATEWAY IP ADDRESS" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
if [ -z $LAN_GW ] ; then
2025-02-11 20:07:51 +01:00
echo -e " ${ DGN } Gateway needs to be set if ip is not dhcp ${ CL } "
exit-script
fi
if [ [ -n " $LAN_GW " && ! " $LAN_GW " = ~ $ip_regex ] ] ; then
msg_error " Invalid IP Address format for Gateway. Needs to be 0.0.0.0, was $LAN_GW "
exit
fi
echo -e " ${ DGN } Using LAN GATEWAY ADDRESS: ${ BGN } $LAN_GW ${ CL } "
fi
2025-04-09 18:35:17 +02:00
if NETMASK = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a LAN netmmask (24 for example)" 8 58 $NETMASK --title "LAN NETMASK" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
if [ -z $NETMASK ] ; then
2025-02-11 20:07:51 +01:00
echo -e " ${ DGN } Netmask needs to be set if ip is not dhcp ${ CL } "
fi
if [ [ -n " $NETMASK " && ! ( " $NETMASK " = ~ ^[ 0-9] +$ && " $NETMASK " -ge 1 && " $NETMASK " -le 32) ] ] ; then
msg_error " Invalid LAN NETMASK format. Needs to be 1-32, was $NETMASK "
exit
fi
echo -e " ${ DGN } Using LAN NETMASK: ${ BGN } $NETMASK ${ CL } "
else
exit-script
fi
fi
else
exit-script
fi
if WAN_BRG = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a WAN Bridge" 8 58 vmbr1 --title "WAN BRIDGE" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
2025-04-09 18:35:17 +02:00
if [ -z $WAN_BRG ] ; then
2025-02-11 20:07:51 +01:00
WAN_BRG = "vmbr1"
fi
2026-02-25 17:31:41 +01:00
if ! ip link show " ${ WAN_BRG } " & >/dev/null; then
msg_error " WAN Bridge ' ${ WAN_BRG } ' does not exist "
2025-02-11 20:07:51 +01:00
exit
fi
echo -e " ${ DGN } Using WAN Bridge: ${ BGN } $WAN_BRG ${ CL } "
else
exit-script
fi
2025-04-09 18:35:17 +02:00
if WAN_IP_ADDR = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a WAN IP" 8 58 $WAN_IP_ADDR --title "WAN IP ADDRESS" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
if [ -z $WAN_IP_ADDR ] ; then
2025-02-11 20:07:51 +01:00
echo -e " ${ DGN } Using DHCP AS WAN IP ADDRESS ${ CL } "
else
if [ [ -n " $WAN_IP_ADDR " && ! " $WAN_IP_ADDR " = ~ $ip_regex ] ] ; then
msg_error " Invalid IP Address format for WAN IP. Needs to be 0.0.0.0, was $WAN_IP_ADDR "
exit
fi
echo -e " ${ DGN } Using WAN IP ADDRESS: ${ BGN } $WAN_IP_ADDR ${ CL } "
2025-04-09 18:35:17 +02:00
if WAN_GW = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a WAN GATEWAY IP" 8 58 $WAN_GW --title "WAN GATEWAY IP ADDRESS" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
if [ -z $WAN_GW ] ; then
2025-02-11 20:07:51 +01:00
echo -e " ${ DGN } Gateway needs to be set if ip is not dhcp ${ CL } "
exit-script
fi
if [ [ -n " $WAN_GW " && ! " $WAN_GW " = ~ $ip_regex ] ] ; then
msg_error " Invalid IP Address format for WAN Gateway. Needs to be 0.0.0.0, was $WAN_GW "
exit
fi
echo -e " ${ DGN } Using WAN GATEWAY ADDRESS: ${ BGN } $WAN_GW ${ CL } "
else
exit-script
fi
2025-04-09 18:35:17 +02:00
if WAN_NETMASK = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a WAN netmmask (24 for example)" 8 58 $WAN_NETMASK --title "WAN NETMASK" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
if [ -z $WAN_NETMASK ] ; then
2025-02-11 20:07:51 +01:00
echo -e " ${ DGN } WAN Netmask needs to be set if ip is not dhcp ${ CL } "
fi
if [ [ -n " $WAN_NETMASK " && ! ( " $WAN_NETMASK " = ~ ^[ 0-9] +$ && " $WAN_NETMASK " -ge 1 && " $WAN_NETMASK " -le 32) ] ] ; then
msg_error " Invalid WAN NETMASK format. Needs to be 1-32, was $WAN_NETMASK "
exit
fi
echo -e " ${ DGN } Using WAN NETMASK: ${ BGN } $WAN_NETMASK ${ CL } "
else
exit-script
fi
fi
else
exit-script
fi
2025-04-09 18:35:17 +02:00
if MAC1 = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a WAN MAC Address" 8 58 $GEN_MAC --title "WAN MAC ADDRESS" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
if [ -z $MAC1 ] ; then
2025-02-11 20:07:51 +01:00
MAC = " $GEN_MAC "
else
MAC = " $MAC1 "
fi
echo -e " ${ DGN } Using LAN MAC Address: ${ BGN } $MAC ${ CL } "
else
exit-script
fi
2025-04-09 18:35:17 +02:00
if MAC2 = $( whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a LAN MAC Address" 8 58 $GEN_MAC_LAN --title "LAN MAC ADDRESS" --cancel-button Exit-Script 3>& 1 1>& 2 2>& 3) ; then
if [ -z $MAC2 ] ; then
2025-02-11 20:07:51 +01:00
WAN_MAC = " $GEN_MAC_LAN "
else
WAN_MAC = " $MAC2 "
fi
echo -e " ${ DGN } Using WAN MAC Address: ${ BGN } $WAN_MAC ${ CL } "
else
exit-script
fi
2025-02-12 11:05:08 +01:00
if ( whiptail --backtitle "Proxmox VE Helper Scripts" --title "ADVANCED SETTINGS COMPLETE" --yesno "Ready to create OPNsense VM?" --no-button Do-Over 10 58) ; then
echo -e " ${ RD } Creating a OPNsense VM using the above advanced settings ${ CL } "
2025-02-11 20:07:51 +01:00
else
header_info
echo -e " ${ RD } Using Advanced Settings ${ CL } "
advanced_settings
fi
}
function start_script( ) {
if ( whiptail --backtitle "Proxmox VE Helper Scripts" --title "SETTINGS" --yesno "Use Default Settings?" --no-button Advanced 10 58) ; then
header_info
echo -e " ${ BL } Using Default Settings ${ CL } "
default_settings
else
header_info
echo -e " ${ RD } Using Advanced Settings ${ CL } "
advanced_settings
fi
}
arch_check
pve_check
ssh_check
start_script
post_to_api_vm
msg_info "Validating Storage"
while read -r line; do
2025-04-09 18:35:17 +02:00
TAG = $( echo $line | awk '{print $1}' )
TYPE = $( echo $line | awk '{printf "%-10s", $2}' )
FREE = $( echo $line | numfmt --field 4-6 --from-unit= K --to= iec --format %.2f | awk '{printf( "%9sB", $6)}' )
2025-02-11 20:07:51 +01:00
ITEM = " Type: $TYPE Free: $FREE "
OFFSET = 2
if [ [ $(( ${# ITEM } + $OFFSET )) -gt ${ MSG_MAX_LENGTH :- } ] ] ; then
MSG_MAX_LENGTH = $(( ${# ITEM } + $OFFSET ))
fi
STORAGE_MENU += ( " $TAG " " $ITEM " "OFF" )
done < <( pvesm status -content images | awk 'NR>1' )
VALID = $( pvesm status -content images | awk 'NR>1' )
if [ -z " $VALID " ] ; then
msg_error "Unable to detect a valid storage location."
exit
elif [ $(( ${# STORAGE_MENU [@] } / 3 )) -eq 1 ] ; then
STORAGE = ${ STORAGE_MENU [0] }
else
while [ -z " ${ STORAGE : +x } " ] ; do
STORAGE = $( whiptail --backtitle "Proxmox VE Helper Scripts" --title "Storage Pools" --radiolist \
2025-04-17 02:49:55 -04:00
" Which storage pool would you like to use for ${ HN } ?\nTo make a selection, use the Spacebar.\n " \
2025-02-11 20:07:51 +01:00
16 $(( $MSG_MAX_LENGTH + 23 )) 6 \
2025-04-15 15:20:46 +02:00
" ${ STORAGE_MENU [@] } " 3>& 1 1>& 2 2>& 3)
2025-02-11 20:07:51 +01:00
done
fi
msg_ok " Using ${ CL } ${ BL } $STORAGE ${ CL } ${ GN } for Storage Location. "
msg_ok " Virtual Machine ID is ${ CL } ${ BL } $VMID ${ CL } . "
2025-02-12 11:05:08 +01:00
msg_info "Retrieving the URL for the OPNsense Qcow2 Disk Image"
2025-12-15 09:10:29 -07:00
# Use latest stable FreeBSD amd64 qcow2 VM image (generic, not UFS/ZFS)
2026-01-08 15:10:57 +01:00
RELEASE_LIST = " $( curl -s https://download.freebsd.org/releases/VM-IMAGES/ |
grep -Eo '[0-9]+\.[0-9]+-RELEASE' |
sort -Vr |
uniq) "
2025-12-15 09:10:29 -07:00
URL = ""
FREEBSD_VER = ""
for ver in $RELEASE_LIST ; do
candidate = " https://download.freebsd.org/releases/VM-IMAGES/ ${ ver } /amd64/Latest/FreeBSD- ${ ver } -amd64.qcow2.xz "
if curl -fsI " $candidate " >/dev/null 2>& 1; then
FREEBSD_VER = " $ver "
URL = " $candidate "
break
fi
done
if [ -z " $URL " ] ; then
msg_error "Could not find generic FreeBSD amd64 qcow2 image (non-UFS/ZFS)."
core: standardize exit codes and add mappings (#12467)
* Standardize exit codes and add mappings
Replace generic exit 1 usages with specific numeric exit codes and add corresponding explanations to the error lookup. This commit updates multiple misc/* scripts to return distinct codes for validation, Proxmox/LXC, networking, download and curl errors (e.g. 103-123, 64, 107-120, 206, 0 for explicit user cancels). It also updates curl error handling to propagate the original curl exit code and adds new entries in explain_exit_code and the error handler to improve diagnostics.
* Set exit code 115 for update_os errors
Change exit status from 6 to 115 in misc/alpine-install.func's update_os() error handlers when failing to download tools.func or when the expected functions are missing. This gives a distinct exit code for these specific failure cases.
* Add tools/addon exit codes and use them
Introduce exit codes 232-238 for Tools & Addon scripts in misc/api.func and misc/error_handler.func. Update addon scripts (tools/addon/adguardhome-sync.sh, tools/addon/copyparty.sh, tools/addon/cronmaster.sh) to return specific codes instead of generic exit 1: 238 for unsupported OS and 233 when the application is not installed/upgrade prerequisites are missing. This makes failures more descriptive and aligns scripts with the central error explanations.
* Standardize exit codes in exporter addons
Unify exit codes across exporter addon scripts: return 238 for unsupported OS detections and 233 when an update is requested but the exporter is not installed. Applied to nextcloud-exporter.sh, pihole-exporter.sh, prometheus-paperless-ngx-exporter.sh, and qbittorrent-exporter.sh to make failure modes distinguishable for callers/automation.
* Use specific exit codes in addon scripts
Replace generic exit 1 with distinct exit codes across multiple addon scripts to enable finer-grained error handling in automation. Exit codes introduced: 10 for Docker/Compose missing or user-declined Docker install, 233 for "nothing to update" cases, and 238 for unsupported OS cases. Affected files: tools/addon/arcane.sh, coolify.sh, dockge.sh, dokploy.sh, filebrowser-quantum.sh, filebrowser.sh, immich-public-proxy.sh, jellystat.sh, runtipi.sh.
* Use specific exit codes in addon scripts
Replace generic exit 1 with specific exit codes across multiple addon scripts to improve error signaling and handling. Files updated: tools/addon/add-netbird-lxc.sh (exit 238 on unsupported distro), tools/addon/add-tailscale-lxc.sh (treat user cancel as exit 0), tools/addon/glances.sh (exit 233 when not installed), tools/addon/komodo.sh (distinct exits for missing compose, legacy DB, backup/download failures, docker checks), tools/addon/netdata.sh (distinct exits for unsupported PVE versions, OS/codename detection, repo lookups), and tools/addon/phpmyadmin.sh (distinct exits for unsupported OS, network/download issues, package install/start failures, and invalid input). These changes make failures easier to identify and automate recovery or reporting.
* Use specific exit codes in PVE scripts
Replace generic exit 1 with distinct exit codes across tools/pve scripts to provide clearer failure signals for callers. post-pve-install.sh now returns 105 for unsupported Proxmox versions; pve-privilege-converter.sh uses 104 for non-root, 234 when no containers, and 235 for backup/conversion failures; update-apps.sh maps backup failures to 235, missing containers/selections to 234 (and UI cancellations to 0), missing backup storage to 119, and returns the actual container update exit code on failure. These changes improve diagnostics and allow external tooling to react to specific error conditions.
* Standardize exit codes and behaviors
Adjust exit codes and abort handling across multiple PVE helper scripts to provide clearer outcomes for automation and interactive flows. Changes include:
- container-restore-from-backup.sh, core-restore-from-backup.sh: return 235 when no backups found (was 1).
- fstrim.sh: treat user cancellation of non-ext4 warning as non-error (exit 0 instead of 1).
- kernel-clean.sh: treat no selection or user abort as non-error (exit 0 instead of 1).
- lxc-delete.sh: return 234 when no containers are present; treat no selection as non-error (exit 0).
- nic-offloading-fix.sh: use specific non-zero codes for root check and tool install failures (exit 104, 237) and 236 when no matching interfaces (was 1).
- pbs_microcode.sh, post-pmg-install.sh, post-pbs-install.sh: use distinct exit codes (232 and 105) for detected VM/PVE/unsupported distro conditions instead of generic 1.
These modifications make scripts return distinct codes for different failure modes and ensure user-initiated aborts or benign conditions exit with 0 where appropriate.
* Use exit 105 for unsupported PVE versions
Standardize error handling by replacing generic exit 1 with exit 105 in pve_check() across multiple VM template scripts to indicate unsupported Proxmox VE versions. Also add API exit code 226 message for "Proxmox: VM disk import or post-creation setup failed" in misc/api.func. Affected files include misc/api.func and various vm/*-vm.sh scripts.
* Use specific exit codes in VM scripts
Replace generic exit 1 with distinct exit codes across vm/*.sh to make failures more actionable for callers. Changes include: use 226 for missing imported-disk references, 237 for pv installation failures, 115 for download/extract/ISO-related failures, 214 for insufficient disk space during FreeBSD decompression, and 119 for missing storage detection. Updated scripts: archlinux-vm.sh, docker-vm.sh, haos-vm.sh, openwrt-vm.sh, opnsense-vm.sh, truenas-vm.sh, umbrel-os-vm.sh.
2026-03-02 10:55:20 +01:00
exit 115
2025-12-15 09:10:29 -07:00
fi
2025-12-03 04:48:12 -03:00
msg_ok " Download URL: ${ CL } ${ BL } ${ URL } ${ CL } "
2026-02-18 22:06:04 +01:00
# Check available disk space (require at least 20GB for safety)
if ! check_disk_space " $TEMP_DIR " 20; then
AVAILABLE_GB = $( df -h " $TEMP_DIR " | awk 'NR==2 {print $4}' )
msg_error " Insufficient disk space in temporary directory ( $TEMP_DIR ). "
msg_error " Available: ${ AVAILABLE_GB } , Required: ~20GB for FreeBSD image decompression. "
msg_error "Please free up space or ensure /tmp has sufficient storage."
core: standardize exit codes and add mappings (#12467)
* Standardize exit codes and add mappings
Replace generic exit 1 usages with specific numeric exit codes and add corresponding explanations to the error lookup. This commit updates multiple misc/* scripts to return distinct codes for validation, Proxmox/LXC, networking, download and curl errors (e.g. 103-123, 64, 107-120, 206, 0 for explicit user cancels). It also updates curl error handling to propagate the original curl exit code and adds new entries in explain_exit_code and the error handler to improve diagnostics.
* Set exit code 115 for update_os errors
Change exit status from 6 to 115 in misc/alpine-install.func's update_os() error handlers when failing to download tools.func or when the expected functions are missing. This gives a distinct exit code for these specific failure cases.
* Add tools/addon exit codes and use them
Introduce exit codes 232-238 for Tools & Addon scripts in misc/api.func and misc/error_handler.func. Update addon scripts (tools/addon/adguardhome-sync.sh, tools/addon/copyparty.sh, tools/addon/cronmaster.sh) to return specific codes instead of generic exit 1: 238 for unsupported OS and 233 when the application is not installed/upgrade prerequisites are missing. This makes failures more descriptive and aligns scripts with the central error explanations.
* Standardize exit codes in exporter addons
Unify exit codes across exporter addon scripts: return 238 for unsupported OS detections and 233 when an update is requested but the exporter is not installed. Applied to nextcloud-exporter.sh, pihole-exporter.sh, prometheus-paperless-ngx-exporter.sh, and qbittorrent-exporter.sh to make failure modes distinguishable for callers/automation.
* Use specific exit codes in addon scripts
Replace generic exit 1 with distinct exit codes across multiple addon scripts to enable finer-grained error handling in automation. Exit codes introduced: 10 for Docker/Compose missing or user-declined Docker install, 233 for "nothing to update" cases, and 238 for unsupported OS cases. Affected files: tools/addon/arcane.sh, coolify.sh, dockge.sh, dokploy.sh, filebrowser-quantum.sh, filebrowser.sh, immich-public-proxy.sh, jellystat.sh, runtipi.sh.
* Use specific exit codes in addon scripts
Replace generic exit 1 with specific exit codes across multiple addon scripts to improve error signaling and handling. Files updated: tools/addon/add-netbird-lxc.sh (exit 238 on unsupported distro), tools/addon/add-tailscale-lxc.sh (treat user cancel as exit 0), tools/addon/glances.sh (exit 233 when not installed), tools/addon/komodo.sh (distinct exits for missing compose, legacy DB, backup/download failures, docker checks), tools/addon/netdata.sh (distinct exits for unsupported PVE versions, OS/codename detection, repo lookups), and tools/addon/phpmyadmin.sh (distinct exits for unsupported OS, network/download issues, package install/start failures, and invalid input). These changes make failures easier to identify and automate recovery or reporting.
* Use specific exit codes in PVE scripts
Replace generic exit 1 with distinct exit codes across tools/pve scripts to provide clearer failure signals for callers. post-pve-install.sh now returns 105 for unsupported Proxmox versions; pve-privilege-converter.sh uses 104 for non-root, 234 when no containers, and 235 for backup/conversion failures; update-apps.sh maps backup failures to 235, missing containers/selections to 234 (and UI cancellations to 0), missing backup storage to 119, and returns the actual container update exit code on failure. These changes improve diagnostics and allow external tooling to react to specific error conditions.
* Standardize exit codes and behaviors
Adjust exit codes and abort handling across multiple PVE helper scripts to provide clearer outcomes for automation and interactive flows. Changes include:
- container-restore-from-backup.sh, core-restore-from-backup.sh: return 235 when no backups found (was 1).
- fstrim.sh: treat user cancellation of non-ext4 warning as non-error (exit 0 instead of 1).
- kernel-clean.sh: treat no selection or user abort as non-error (exit 0 instead of 1).
- lxc-delete.sh: return 234 when no containers are present; treat no selection as non-error (exit 0).
- nic-offloading-fix.sh: use specific non-zero codes for root check and tool install failures (exit 104, 237) and 236 when no matching interfaces (was 1).
- pbs_microcode.sh, post-pmg-install.sh, post-pbs-install.sh: use distinct exit codes (232 and 105) for detected VM/PVE/unsupported distro conditions instead of generic 1.
These modifications make scripts return distinct codes for different failure modes and ensure user-initiated aborts or benign conditions exit with 0 where appropriate.
* Use exit 105 for unsupported PVE versions
Standardize error handling by replacing generic exit 1 with exit 105 in pve_check() across multiple VM template scripts to indicate unsupported Proxmox VE versions. Also add API exit code 226 message for "Proxmox: VM disk import or post-creation setup failed" in misc/api.func. Affected files include misc/api.func and various vm/*-vm.sh scripts.
* Use specific exit codes in VM scripts
Replace generic exit 1 with distinct exit codes across vm/*.sh to make failures more actionable for callers. Changes include: use 226 for missing imported-disk references, 237 for pv installation failures, 115 for download/extract/ISO-related failures, 214 for insufficient disk space during FreeBSD decompression, and 119 for missing storage detection. Updated scripts: archlinux-vm.sh, docker-vm.sh, haos-vm.sh, openwrt-vm.sh, opnsense-vm.sh, truenas-vm.sh, umbrel-os-vm.sh.
2026-03-02 10:55:20 +01:00
exit 214
2026-02-18 22:06:04 +01:00
fi
msg_info "Downloading FreeBSD Image"
2025-04-03 16:01:23 +02:00
curl -f#SL -o " $( basename " $URL " ) " " $URL "
2025-02-11 20:07:51 +01:00
echo -en "\e[1A\e[0K"
2026-02-18 22:06:04 +01:00
msg_ok " Downloaded ${ CL } ${ BL } $( basename " $URL " ) ${ CL } "
# Check disk space again before decompression
if ! check_disk_space " $TEMP_DIR " 15; then
AVAILABLE_GB = $( df -h " $TEMP_DIR " | awk 'NR==2 {print $4}' )
msg_error "Insufficient disk space for decompression."
msg_error " Available: ${ AVAILABLE_GB } , Required: ~15GB for decompressed image. "
core: standardize exit codes and add mappings (#12467)
* Standardize exit codes and add mappings
Replace generic exit 1 usages with specific numeric exit codes and add corresponding explanations to the error lookup. This commit updates multiple misc/* scripts to return distinct codes for validation, Proxmox/LXC, networking, download and curl errors (e.g. 103-123, 64, 107-120, 206, 0 for explicit user cancels). It also updates curl error handling to propagate the original curl exit code and adds new entries in explain_exit_code and the error handler to improve diagnostics.
* Set exit code 115 for update_os errors
Change exit status from 6 to 115 in misc/alpine-install.func's update_os() error handlers when failing to download tools.func or when the expected functions are missing. This gives a distinct exit code for these specific failure cases.
* Add tools/addon exit codes and use them
Introduce exit codes 232-238 for Tools & Addon scripts in misc/api.func and misc/error_handler.func. Update addon scripts (tools/addon/adguardhome-sync.sh, tools/addon/copyparty.sh, tools/addon/cronmaster.sh) to return specific codes instead of generic exit 1: 238 for unsupported OS and 233 when the application is not installed/upgrade prerequisites are missing. This makes failures more descriptive and aligns scripts with the central error explanations.
* Standardize exit codes in exporter addons
Unify exit codes across exporter addon scripts: return 238 for unsupported OS detections and 233 when an update is requested but the exporter is not installed. Applied to nextcloud-exporter.sh, pihole-exporter.sh, prometheus-paperless-ngx-exporter.sh, and qbittorrent-exporter.sh to make failure modes distinguishable for callers/automation.
* Use specific exit codes in addon scripts
Replace generic exit 1 with distinct exit codes across multiple addon scripts to enable finer-grained error handling in automation. Exit codes introduced: 10 for Docker/Compose missing or user-declined Docker install, 233 for "nothing to update" cases, and 238 for unsupported OS cases. Affected files: tools/addon/arcane.sh, coolify.sh, dockge.sh, dokploy.sh, filebrowser-quantum.sh, filebrowser.sh, immich-public-proxy.sh, jellystat.sh, runtipi.sh.
* Use specific exit codes in addon scripts
Replace generic exit 1 with specific exit codes across multiple addon scripts to improve error signaling and handling. Files updated: tools/addon/add-netbird-lxc.sh (exit 238 on unsupported distro), tools/addon/add-tailscale-lxc.sh (treat user cancel as exit 0), tools/addon/glances.sh (exit 233 when not installed), tools/addon/komodo.sh (distinct exits for missing compose, legacy DB, backup/download failures, docker checks), tools/addon/netdata.sh (distinct exits for unsupported PVE versions, OS/codename detection, repo lookups), and tools/addon/phpmyadmin.sh (distinct exits for unsupported OS, network/download issues, package install/start failures, and invalid input). These changes make failures easier to identify and automate recovery or reporting.
* Use specific exit codes in PVE scripts
Replace generic exit 1 with distinct exit codes across tools/pve scripts to provide clearer failure signals for callers. post-pve-install.sh now returns 105 for unsupported Proxmox versions; pve-privilege-converter.sh uses 104 for non-root, 234 when no containers, and 235 for backup/conversion failures; update-apps.sh maps backup failures to 235, missing containers/selections to 234 (and UI cancellations to 0), missing backup storage to 119, and returns the actual container update exit code on failure. These changes improve diagnostics and allow external tooling to react to specific error conditions.
* Standardize exit codes and behaviors
Adjust exit codes and abort handling across multiple PVE helper scripts to provide clearer outcomes for automation and interactive flows. Changes include:
- container-restore-from-backup.sh, core-restore-from-backup.sh: return 235 when no backups found (was 1).
- fstrim.sh: treat user cancellation of non-ext4 warning as non-error (exit 0 instead of 1).
- kernel-clean.sh: treat no selection or user abort as non-error (exit 0 instead of 1).
- lxc-delete.sh: return 234 when no containers are present; treat no selection as non-error (exit 0).
- nic-offloading-fix.sh: use specific non-zero codes for root check and tool install failures (exit 104, 237) and 236 when no matching interfaces (was 1).
- pbs_microcode.sh, post-pmg-install.sh, post-pbs-install.sh: use distinct exit codes (232 and 105) for detected VM/PVE/unsupported distro conditions instead of generic 1.
These modifications make scripts return distinct codes for different failure modes and ensure user-initiated aborts or benign conditions exit with 0 where appropriate.
* Use exit 105 for unsupported PVE versions
Standardize error handling by replacing generic exit 1 with exit 105 in pve_check() across multiple VM template scripts to indicate unsupported Proxmox VE versions. Also add API exit code 226 message for "Proxmox: VM disk import or post-creation setup failed" in misc/api.func. Affected files include misc/api.func and various vm/*-vm.sh scripts.
* Use specific exit codes in VM scripts
Replace generic exit 1 with distinct exit codes across vm/*.sh to make failures more actionable for callers. Changes include: use 226 for missing imported-disk references, 237 for pv installation failures, 115 for download/extract/ISO-related failures, 214 for insufficient disk space during FreeBSD decompression, and 119 for missing storage detection. Updated scripts: archlinux-vm.sh, docker-vm.sh, haos-vm.sh, openwrt-vm.sh, opnsense-vm.sh, truenas-vm.sh, umbrel-os-vm.sh.
2026-03-02 10:55:20 +01:00
exit 214
2026-02-18 22:06:04 +01:00
fi
msg_info "Decompressing FreeBSD Image (this may take a few minutes)"
2025-12-03 04:48:12 -03:00
FILE = FreeBSD.qcow2
2026-02-18 22:06:04 +01:00
if ! unxz -cv $( basename $URL ) >${ FILE } ; then
msg_error "Failed to decompress FreeBSD image."
msg_error "This is usually caused by insufficient disk space."
df -h " $TEMP_DIR "
core: standardize exit codes and add mappings (#12467)
* Standardize exit codes and add mappings
Replace generic exit 1 usages with specific numeric exit codes and add corresponding explanations to the error lookup. This commit updates multiple misc/* scripts to return distinct codes for validation, Proxmox/LXC, networking, download and curl errors (e.g. 103-123, 64, 107-120, 206, 0 for explicit user cancels). It also updates curl error handling to propagate the original curl exit code and adds new entries in explain_exit_code and the error handler to improve diagnostics.
* Set exit code 115 for update_os errors
Change exit status from 6 to 115 in misc/alpine-install.func's update_os() error handlers when failing to download tools.func or when the expected functions are missing. This gives a distinct exit code for these specific failure cases.
* Add tools/addon exit codes and use them
Introduce exit codes 232-238 for Tools & Addon scripts in misc/api.func and misc/error_handler.func. Update addon scripts (tools/addon/adguardhome-sync.sh, tools/addon/copyparty.sh, tools/addon/cronmaster.sh) to return specific codes instead of generic exit 1: 238 for unsupported OS and 233 when the application is not installed/upgrade prerequisites are missing. This makes failures more descriptive and aligns scripts with the central error explanations.
* Standardize exit codes in exporter addons
Unify exit codes across exporter addon scripts: return 238 for unsupported OS detections and 233 when an update is requested but the exporter is not installed. Applied to nextcloud-exporter.sh, pihole-exporter.sh, prometheus-paperless-ngx-exporter.sh, and qbittorrent-exporter.sh to make failure modes distinguishable for callers/automation.
* Use specific exit codes in addon scripts
Replace generic exit 1 with distinct exit codes across multiple addon scripts to enable finer-grained error handling in automation. Exit codes introduced: 10 for Docker/Compose missing or user-declined Docker install, 233 for "nothing to update" cases, and 238 for unsupported OS cases. Affected files: tools/addon/arcane.sh, coolify.sh, dockge.sh, dokploy.sh, filebrowser-quantum.sh, filebrowser.sh, immich-public-proxy.sh, jellystat.sh, runtipi.sh.
* Use specific exit codes in addon scripts
Replace generic exit 1 with specific exit codes across multiple addon scripts to improve error signaling and handling. Files updated: tools/addon/add-netbird-lxc.sh (exit 238 on unsupported distro), tools/addon/add-tailscale-lxc.sh (treat user cancel as exit 0), tools/addon/glances.sh (exit 233 when not installed), tools/addon/komodo.sh (distinct exits for missing compose, legacy DB, backup/download failures, docker checks), tools/addon/netdata.sh (distinct exits for unsupported PVE versions, OS/codename detection, repo lookups), and tools/addon/phpmyadmin.sh (distinct exits for unsupported OS, network/download issues, package install/start failures, and invalid input). These changes make failures easier to identify and automate recovery or reporting.
* Use specific exit codes in PVE scripts
Replace generic exit 1 with distinct exit codes across tools/pve scripts to provide clearer failure signals for callers. post-pve-install.sh now returns 105 for unsupported Proxmox versions; pve-privilege-converter.sh uses 104 for non-root, 234 when no containers, and 235 for backup/conversion failures; update-apps.sh maps backup failures to 235, missing containers/selections to 234 (and UI cancellations to 0), missing backup storage to 119, and returns the actual container update exit code on failure. These changes improve diagnostics and allow external tooling to react to specific error conditions.
* Standardize exit codes and behaviors
Adjust exit codes and abort handling across multiple PVE helper scripts to provide clearer outcomes for automation and interactive flows. Changes include:
- container-restore-from-backup.sh, core-restore-from-backup.sh: return 235 when no backups found (was 1).
- fstrim.sh: treat user cancellation of non-ext4 warning as non-error (exit 0 instead of 1).
- kernel-clean.sh: treat no selection or user abort as non-error (exit 0 instead of 1).
- lxc-delete.sh: return 234 when no containers are present; treat no selection as non-error (exit 0).
- nic-offloading-fix.sh: use specific non-zero codes for root check and tool install failures (exit 104, 237) and 236 when no matching interfaces (was 1).
- pbs_microcode.sh, post-pmg-install.sh, post-pbs-install.sh: use distinct exit codes (232 and 105) for detected VM/PVE/unsupported distro conditions instead of generic 1.
These modifications make scripts return distinct codes for different failure modes and ensure user-initiated aborts or benign conditions exit with 0 where appropriate.
* Use exit 105 for unsupported PVE versions
Standardize error handling by replacing generic exit 1 with exit 105 in pve_check() across multiple VM template scripts to indicate unsupported Proxmox VE versions. Also add API exit code 226 message for "Proxmox: VM disk import or post-creation setup failed" in misc/api.func. Affected files include misc/api.func and various vm/*-vm.sh scripts.
* Use specific exit codes in VM scripts
Replace generic exit 1 with distinct exit codes across vm/*.sh to make failures more actionable for callers. Changes include: use 226 for missing imported-disk references, 237 for pv installation failures, 115 for download/extract/ISO-related failures, 214 for insufficient disk space during FreeBSD decompression, and 119 for missing storage detection. Updated scripts: archlinux-vm.sh, docker-vm.sh, haos-vm.sh, openwrt-vm.sh, opnsense-vm.sh, truenas-vm.sh, umbrel-os-vm.sh.
2026-03-02 10:55:20 +01:00
exit 115
2026-02-18 22:06:04 +01:00
fi
# Remove the compressed file to save space
rm -f " $( basename " $URL " ) "
msg_ok " Decompressed ${ CL } ${ BL } ${ FILE } ${ CL } "
2025-02-11 20:07:51 +01:00
2025-04-09 18:35:17 +02:00
STORAGE_TYPE = $( pvesm status -storage $STORAGE | awk 'NR>1 {print $2}' )
2025-02-11 20:07:51 +01:00
case $STORAGE_TYPE in
nfs | dir)
DISK_EXT = ".qcow2"
DISK_REF = " $VMID / "
DISK_IMPORT = "-format qcow2"
THIN = ""
; ;
btrfs)
DISK_EXT = ".raw"
DISK_REF = " $VMID / "
DISK_IMPORT = "-format raw"
FORMAT = ",efitype=4m"
THIN = ""
; ;
Archlinux-VM: fix LVM/LVM-thin storage and improve error reporting | VM's add correct exit_code for analytics (#11842)
* fix(archlinux-vm): fix LVM/LVM-thin storage and improve error reporting
- Add catch-all (*) case for storage types (LVM, LVM-thin, zfspool)
Previously only nfs/dir/cifs and btrfs were handled, leaving
DISK_EXT, DISK_REF, and DISK_IMPORT unset on LVM/LVM-thin storage
- Fix error_handler to send numeric exit_code to API instead of
bash command text (which caused 'Unknown error' in telemetry)
- Replace fragile pvesm alloc for EFI disk with Proxmox-managed
:0,efitype=4m (consistent with docker-vm.sh)
- Modernize disk import: auto-detect qm disk import vs qm importdisk,
parse output to get correct disk reference instead of guessing names
- Use --format flag (double dash) consistent with modern Proxmox API
- Remove unused FORMAT variable (EFI type now always set correctly)
- Remove fragile eval-based disk name construction
* fix(vm): fix LVM/LVM-thin storage and error reporting for all VM scripts
- Add catch-all (*) case to storage type detection in all VM scripts
that were missing it (debian-vm, debian-13-vm, ubuntu2204/2404/2504,
nextcloud-vm, owncloud-vm, opnsense-vm, pimox-haos-vm)
- Add catch-all to mikrotik-routeros (had zfspool but not lvm/lvmthin)
- Fix error_handler in ALL 14 VM scripts to send numeric exit_code
to post_update_to_api instead of bash command text, which caused
'Unknown error' in telemetry because the API expects a number
2026-02-12 20:06:02 +01:00
*)
DISK_EXT = ""
DISK_REF = ""
DISK_IMPORT = "-format raw"
; ;
2025-02-11 20:07:51 +01:00
esac
for i in { 0,1} ; do
disk = " DISK $i "
2025-04-09 18:35:17 +02:00
eval DISK${ i } = vm-${ VMID } -disk-${ i } ${ DISK_EXT :- }
eval DISK${ i } _REF = ${ STORAGE } :${ DISK_REF :- } ${ !disk }
2025-02-11 20:07:51 +01:00
done
2025-02-12 11:05:08 +01:00
msg_info "Creating a OPNsense VM"
2025-04-09 18:35:17 +02:00
qm create $VMID -agent 1${ MACHINE } -tablet 0 -localtime 1 -bios ovmf${ CPU_TYPE } -cores $CORE_COUNT -memory $RAM_SIZE \
-name $HN -tags proxmox-helper-scripts -net0 virtio,bridge= $BRG ,macaddr= $MAC $VLAN $MTU -onboot 1 -ostype l26 -scsihw virtio-scsi-pci
pvesm alloc $STORAGE $VMID $DISK0 4M 1>& /dev/null
qm importdisk $VMID ${ FILE } $STORAGE ${ DISK_IMPORT :- } 1>& /dev/null
qm set $VMID \
-efidisk0 ${ DISK0_REF } ${ FORMAT } \
-scsi0 ${ DISK1_REF } ,${ DISK_CACHE } ${ THIN } size = 2G \
2025-02-11 20:07:51 +01:00
-boot order = scsi0 \
2025-04-15 15:20:46 +02:00
-serial0 socket \
-tags community-script >/dev/null
2026-02-18 22:06:04 +01:00
qm resize $VMID scsi0 20G >/dev/null
2025-04-15 15:20:46 +02:00
DESCRIPTION = $(
cat <<EOF
2025-02-11 20:07:51 +01:00
<div align = 'center' >
<a href = 'https://Helper-Scripts.com' target = '_blank' rel = 'noopener noreferrer' >
<img src = 'https://raw.githubusercontent.com/michelroegl-brunner/ProxmoxVE/refs/heads/develop/misc/images/logo-81x112.png' alt = 'Logo' style = 'width:81px;height:112px;' />
</a>
2025-02-12 11:05:08 +01:00
<h2 style = 'font-size: 24px; margin: 20px 0;' >OPNsense VM</h2>
2025-02-11 20:07:51 +01:00
<p style = 'margin: 16px 0;' >
<a href = 'https://ko-fi.com/community_scripts' target = '_blank' rel = 'noopener noreferrer' >
<img src = 'https://img.shields.io/badge/☕-Buy us a coffee-blue' alt = 'spend Coffee' />
</a>
</p>
2025-12-03 04:48:12 -03:00
2025-02-11 20:07:51 +01:00
<span style = 'margin: 0 10px;' >
<i class = "fa fa-github fa-fw" style = "color: #f5f5f5;" ></i>
<a href = 'https://github.com/community-scripts/ProxmoxVE' target = '_blank' rel = 'noopener noreferrer' style = 'text-decoration: none; color: #00617f;' >GitHub</a>
</span>
<span style = 'margin: 0 10px;' >
<i class = "fa fa-comments fa-fw" style = "color: #f5f5f5;" ></i>
<a href = 'https://github.com/community-scripts/ProxmoxVE/discussions' target = '_blank' rel = 'noopener noreferrer' style = 'text-decoration: none; color: #00617f;' >Discussions</a>
</span>
<span style = 'margin: 0 10px;' >
<i class = "fa fa-exclamation-circle fa-fw" style = "color: #f5f5f5;" ></i>
<a href = 'https://github.com/community-scripts/ProxmoxVE/issues' target = '_blank' rel = 'noopener noreferrer' style = 'text-decoration: none; color: #00617f;' >Issues</a>
</span>
</div>
EOF
)
2026-01-08 15:10:57 +01:00
qm set $VMID -description " $DESCRIPTION " >/dev/null
2025-02-11 20:07:51 +01:00
msg_info "Bridge interfaces are being added."
2025-04-09 18:35:17 +02:00
qm set $VMID \
-net0 virtio,bridge= ${ BRG } ,macaddr= ${ MAC } ${ VLAN } ${ MTU } 2>/dev/null
2025-02-11 20:07:51 +01:00
msg_ok "Bridge interfaces have been successfully added."
2025-04-15 15:20:46 +02:00
2025-02-12 11:05:08 +01:00
msg_ok " Created a OPNsense VM ${ CL } ${ BL } ( ${ HN } ) "
2025-04-15 15:20:46 +02:00
msg_ok "Starting OPNsense VM (Patience this takes 20-30 minutes)"
qm start $VMID
sleep 90
send_line_to_vm "root"
send_line_to_vm "fetch https://raw.githubusercontent.com/opnsense/update/master/src/bootstrap/opnsense-bootstrap.sh.in"
2025-12-03 04:48:12 -03:00
if [ -n " $WAN_BRG " ] ; then
msg_info "Adding WAN interface"
qm set $VMID \
-net1 virtio,bridge= ${ WAN_BRG } ,macaddr= ${ WAN_MAC } & >/dev/null
msg_ok "WAN interface added"
2026-01-08 15:10:57 +01:00
sleep 5 # Brief pause after adding network interface
2025-12-03 04:48:12 -03:00
fi
2025-12-07 02:36:47 -06:00
send_line_to_vm "sh ./opnsense-bootstrap.sh.in -y -f -r 25.7"
2025-04-15 15:20:46 +02:00
msg_ok "OPNsense VM is being installed, do not close the terminal, or the installation will fail."
#We need to wait for the OPNsense build proccess to finish, this takes a few minutes
sleep 1000
send_line_to_vm "root"
send_line_to_vm "opnsense"
send_line_to_vm "2"
2025-04-09 19:29:12 +02:00
2025-04-15 15:20:46 +02:00
if [ " $IP_ADDR " != "" ] ; then
send_line_to_vm "1"
send_line_to_vm "n"
send_line_to_vm " ${ IP_ADDR } "
send_line_to_vm " ${ NETMASK } "
send_line_to_vm " ${ LAN_GW } "
send_line_to_vm "n"
send_line_to_vm " "
send_line_to_vm "n"
send_line_to_vm "n"
send_line_to_vm " "
send_line_to_vm "n"
send_line_to_vm "n"
send_line_to_vm "n"
send_line_to_vm "n"
send_line_to_vm "n"
else
send_line_to_vm "1"
send_line_to_vm "y"
send_line_to_vm "n"
send_line_to_vm "n"
send_line_to_vm " "
send_line_to_vm "n"
send_line_to_vm "n"
send_line_to_vm "n"
fi
2025-12-03 04:48:12 -03:00
#Wait for config changes to be saved
2025-04-15 15:20:46 +02:00
sleep 20
2025-12-03 04:48:12 -03:00
if [ -n " $WAN_BRG " ] && [ " $WAN_IP_ADDR " != "" ] ; then
2025-04-15 15:20:46 +02:00
send_line_to_vm "2"
send_line_to_vm "2"
send_line_to_vm "n"
send_line_to_vm " ${ WAN_IP_ADDR } "
send_line_to_vm " ${ NETMASK } "
send_line_to_vm " ${ LAN_GW } "
send_line_to_vm "n"
send_line_to_vm " "
send_line_to_vm "n"
send_line_to_vm " "
send_line_to_vm "n"
send_line_to_vm "n"
send_line_to_vm "n"
fi
sleep 10
send_line_to_vm "0"
msg_ok "Started OPNsense VM"
2025-02-11 20:07:51 +01:00
2026-01-06 22:57:40 +01:00
msg_ok "Completed successfully!\n"
2025-02-11 20:07:51 +01:00
if [ " $IP_ADDR " != "" ] ; then
echo -e " ${ INFO } ${ YW } Access it using the following URL: ${ CL } "
echo -e " ${ TAB } ${ GATEWAY } ${ BGN } http:// ${ IP_ADDR } ${ CL } "
else
echo -e " ${ INFO } ${ YW } LAN IP was DHCP. ${ CL } "
echo -e " ${ INFO } ${ BGN } To find the IP login to the VM shell ${ CL } "
fi