diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00000.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00000.png index b47dc20..eb8072d 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00000.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00000.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00001.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00001.png index 4877fb0..37698d3 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00001.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00001.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00002.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00002.png index 33f0806..91fa3b1 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00002.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00002.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00003.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00003.png index 9c2fa5d..fbea72d 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00003.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00003.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00004.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00004.png index 54aba60..cfee3ae 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00004.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering/00004.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00000.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00000.png index b47dc20..eb8072d 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00000.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00000.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00001.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00001.png index 88c9c50..c57d9b8 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00001.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00001.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00002.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00002.png index 9c2fa5d..fbea72d 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00002.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00002.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00003.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00003.png index 54aba60..cfee3ae 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00003.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_permit/00003.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00000.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00000.png index b47dc20..eb8072d 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00000.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00000.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00001.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00001.png index 62cd3fb..9d2c54e 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00001.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00001.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00002.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00002.png index 9c2fa5d..fbea72d 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00002.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00002.png differ diff --git a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00003.png b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00003.png index 54aba60..cfee3ae 100644 Binary files a/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00003.png and b/tests/ragger/snapshots/stax/test_eip712_advanced_filtering_unlimited/00003.png differ diff --git a/tests/ragger/test_eip712.py b/tests/ragger/test_eip712.py index b0d0a13..4844d0d 100644 --- a/tests/ragger/test_eip712.py +++ b/tests/ragger/test_eip712.py @@ -129,16 +129,25 @@ def eip712_new_common(firmware: Firmware, moves = [NavInsID.RIGHT_CLICK] * 2 moves += [NavInsID.BOTH_CLICK] else: - # need to skip the message hash + # this move is necessary most of the times, but can't be 100% sure with the fields grouping moves += [NavInsID.SWIPE_CENTER_TO_LEFT] + # need to skip the message hash + if not verbose and filters is None: + moves += [NavInsID.SWIPE_CENTER_TO_LEFT] moves += [NavInsID.USE_CASE_REVIEW_CONFIRM] if SNAPS_CONFIG is not None: + # Could break (time-out) if given a JSON that requires less moves + # TODO: Maybe take list of moves as input instead of trying to guess them ? navigator.navigate_and_compare(default_screenshot_path, SNAPS_CONFIG.test_name, moves, snap_start_idx=SNAPS_CONFIG.idx) else: - navigator.navigate(moves) + # Do them one-by-one to prevent an unnecessary move from timing-out and failing the test + for move in moves: + navigator.navigate([move], + screen_change_before_first_instruction=False, + screen_change_after_last_instruction=False) return ResponseParser.signature(app_client.response().data)