d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Better UI for verbose EIP-712, now shows the review struct screen even on inner structures

Browse Source
This commit is contained in:
Alexandre Paillier
2022-06-24 18:12:55 +02:00
parent 032d74e301
commit 559e729188
5 changed files with 47 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src_features/signMessageEIP712/ui_logic.c
View File

@@ -130,24 +130,32 @@ void ui_712_next_field(void)
{
return;
}
if (!ui_ctx->end_reached)
if (ui_ctx->structs_to_review > 0)
{
// reply to previous APDU
G_io_apdu_buffer[0] = 0x90;
G_io_apdu_buffer[1] = 0x00;
io_exchange(CHANNEL_APDU | IO_RETURN_AFTER_TX, 2);
ui_712_review_struct(path_get_nth_struct_to_last(ui_ctx->structs_to_review));
ui_ctx->structs_to_review -= 1;
}
else
{
if (ui_ctx->pos == UI_712_POS_REVIEW)
if (!ui_ctx->end_reached)
{
ux_flow_next();
ui_ctx->pos = UI_712_POS_END;
// reply to previous APDU
G_io_apdu_buffer[0] = 0x90;
G_io_apdu_buffer[1] = 0x00;
io_exchange(CHANNEL_APDU | IO_RETURN_AFTER_TX, 2);
}
else
{
ux_flow_prev();
ui_ctx->pos = UI_712_POS_REVIEW;
if (ui_ctx->pos == UI_712_POS_REVIEW)
{
ux_flow_next();
ui_ctx->pos = UI_712_POS_END;
}
else
{
ux_flow_prev();
ui_ctx->pos = UI_712_POS_REVIEW;
}
}
}
}
@@ -415,4 +423,12 @@ void ui_712_field_flags_reset(void)
ui_ctx->field_flags = 0;
}
void ui_712_queue_struct_to_review(void)
{
if (N_storage.verbose_eip712)
{
ui_ctx->structs_to_review += 1;
}
}
#endif // HAVE_EIP712_FULL_SUPPORT