From b27bfdcdf0169a3dfa588b6043826aee65d47b90 Mon Sep 17 00:00:00 2001 From: Charles-Edouard de la Vergne Date: Wed, 27 Mar 2024 15:45:06 +0100 Subject: [PATCH 1/4] Revert "Update version to 1.11.1" This reverts commit e82e9858c929a578ca72d520b439df253f0763a6. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a7a2ef2..39c64e4 100644 --- a/Makefile +++ b/Makefile @@ -34,7 +34,7 @@ APP_LOAD_PARAMS += --path "1517992542'/1101353413'" APPVERSION_M = 1 APPVERSION_N = 11 -APPVERSION_P = 1 +APPVERSION_P = 0 APPVERSION = $(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)-dev APP_LOAD_FLAGS = --appFlags 0xa40 --dep Ethereum:$(APPVERSION) From a14418b7ce3a71cd96e61c1559d074e799c2f419 Mon Sep 17 00:00:00 2001 From: Charles-Edouard de la Vergne Date: Wed, 27 Mar 2024 15:45:19 +0100 Subject: [PATCH 2/4] Revert "Adapt test using App version" This reverts commit 6e872b45ccae3ca23cb0a24564411c229b7d7d06. --- tests/speculos/test_configuration_cmd.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/speculos/test_configuration_cmd.py b/tests/speculos/test_configuration_cmd.py index d8213f7..af56756 100644 --- a/tests/speculos/test_configuration_cmd.py +++ b/tests/speculos/test_configuration_cmd.py @@ -1,3 +1,3 @@ def test_configuration(cmd): - assert cmd.get_configuration() == (2, 1, 11, 1) + assert cmd.get_configuration() == (2, 1, 11, 0) From 7e6ae35465833a6d23d6cc61c9dcb2ba9198ac61 Mon Sep 17 00:00:00 2001 From: Charles-Edouard de la Vergne Date: Wed, 27 Mar 2024 16:43:44 +0100 Subject: [PATCH 3/4] Document plugin_sdk changelog --- src_plugin_sdk/CHANGELOG.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src_plugin_sdk/CHANGELOG.md b/src_plugin_sdk/CHANGELOG.md index 90ead8d..f0541d9 100644 --- a/src_plugin_sdk/CHANGELOG.md +++ b/src_plugin_sdk/CHANGELOG.md @@ -5,7 +5,15 @@ | :rotating_light: | Breaks build | | :warning: | Breaks compatibility with app | -## [latest](/) - 2024/02/07 +## [latest](/) - 2024/03/27 + +### Changed + +* Add new functions `getEthAddressFromRawKey` and `getEthAddressStringFromRawKey` +* Simplify crypto calls in `getEthAddressStringFromBinary` +* Cleanup useless `cx_sha3_t` useless parameter + +## [0a98664](/../../commit/0a98664) - 2024/02/07 ### Removed From 1a8bb93180cb0afebe39a3e7d2599de2831fe4de Mon Sep 17 00:00:00 2001 From: Charles-Edouard de la Vergne Date: Wed, 27 Mar 2024 17:20:58 +0100 Subject: [PATCH 4/4] Remove old funtion in deprecated --- src_common/common_utils.h | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/src_common/common_utils.h b/src_common/common_utils.h index 2a7566f..2c1a8dd 100644 --- a/src_common/common_utils.h +++ b/src_common/common_utils.h @@ -63,33 +63,6 @@ void getEthAddressStringFromRawKey(const uint8_t raw_pubkey[static 65], char out[static ADDRESS_LENGTH * 2], uint64_t chainId); -/** - * @deprecated - * See #getEthAddressFromRawKey - */ -DEPRECATED static inline bool getEthAddressFromKey(cx_ecfp_public_key_t *publicKey, - uint8_t *out, - cx_sha3_t *sha3Context) { - UNUSED(sha3Context); - - getEthAddressFromRawKey(publicKey->W, out); - return true; -} - -/** - * @deprecated - * See #getEthAddressFromRawKey - */ -DEPRECATED static inline bool getEthAddressStringFromKey(cx_ecfp_public_key_t *publicKey, - uint8_t *out, - cx_sha3_t *sha3Context, - uint64_t chainId) { - UNUSED(sha3Context); - - getEthAddressStringFromRawKey(publicKey->W, (char *) out, chainId); - return true; -} - bool getEthAddressStringFromBinary(uint8_t *address, char out[static ADDRESS_LENGTH * 2], uint64_t chainId);