From 99950a396c37be4f314cc7dfcf3293b4f8a01066 Mon Sep 17 00:00:00 2001 From: pscott Date: Thu, 15 Apr 2021 16:19:12 +0200 Subject: [PATCH] Add max and min values and restrict bounds --- src_common/ethUstream.c | 2 +- src_common/ethUstream.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src_common/ethUstream.c b/src_common/ethUstream.c index 517691e..5d404fe 100644 --- a/src_common/ethUstream.c +++ b/src_common/ethUstream.c @@ -264,7 +264,7 @@ static parserStatus_e processTxInternal(txContext_t *context) { return USTREAM_PROCESSING; } // EIP 2718: TransactionType might be present before the TransactionPayload. - if (*context->workBuffer > 0x00 && *context->workBuffer < 0x7f) { + if (*context->workBuffer >= MIN_TX_TYPE && *context->workBuffer <= MAX_TX_TYPE) { uint8_t maybeType = *context->workBuffer; PRINTF("TX TYPE: %u\n", maybeType); diff --git a/src_common/ethUstream.h b/src_common/ethUstream.h index 1b9bf2e..05921bb 100644 --- a/src_common/ethUstream.h +++ b/src_common/ethUstream.h @@ -53,6 +53,9 @@ typedef enum rlpTxField_e { TX_RLP_DONE } rlpTxField_e; +#define MIN_TX_TYPE 0x00 +#define MAX_TX_TYPE 0x7f + // EIP 2718 TransactionType typedef enum txType_e { LEGACY_TX,