From a4905326050e01a8a160e2df610ee748a40a2cf6 Mon Sep 17 00:00:00 2001 From: apaillier-ledger <94451027+apaillier-ledger@users.noreply.github.com> Date: Fri, 19 Nov 2021 11:24:28 +0100 Subject: [PATCH] Fix compilation warnings (#216) * Fix deprecated os_memmove warning Switched to the standard memmove function * Fix get_network_ticker implicit declaration warning Included the required missing header file * Removed useless execution rights from Makefile * Fix directory name in README --- Makefile | 0 README.md | 2 +- src/eth_plugin_handler.c | 1 + src/main.c | 2 +- 4 files changed, 3 insertions(+), 2 deletions(-) mode change 100755 => 100644 Makefile diff --git a/Makefile b/Makefile old mode 100755 new mode 100644 diff --git a/README.md b/README.md index 417c5bb..1713c74 100644 --- a/README.md +++ b/README.md @@ -20,7 +20,7 @@ First [install yarn](https://classic.yarnpkg.com/en/docs/install/#debian-stable) Open `tests/build_local_test_elfs.sh` and add your BOLOS SDKs path to `NANOS_SDK` and `NANOX_SDK`. This helper script will build the applications required by the test suite and move them at the right place. ``` -cd test +cd tests ./build_local_test_elfs.sh ``` Then you can install the project by simply running: diff --git a/src/eth_plugin_handler.c b/src/eth_plugin_handler.c index dac067a..b1e19c0 100644 --- a/src/eth_plugin_handler.c +++ b/src/eth_plugin_handler.c @@ -2,6 +2,7 @@ #include "eth_plugin_handler.h" #include "eth_plugin_internal.h" #include "shared_context.h" +#include "network.h" void eth_plugin_prepare_init(ethPluginInitContract_t *init, uint8_t *selector, uint32_t dataSize) { memset((uint8_t *) init, 0, sizeof(ethPluginInitContract_t)); diff --git a/src/main.c b/src/main.c index 11358e7..83621aa 100644 --- a/src/main.c +++ b/src/main.c @@ -411,7 +411,7 @@ void handleGetWalletId(volatile unsigned int *tx) { // pubkey -> sha512 cx_hash_sha512(pub.W, sizeof(pub.W), t, sizeof(t)); // ! cookie ! - os_memmove(G_io_apdu_buffer, t, 64); + memmove(G_io_apdu_buffer, t, 64); *tx = 64; THROW(0x9000); }