From a865be3d5fef64d33940814ba408a7d0aabed8f6 Mon Sep 17 00:00:00 2001
From: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
Date: Tue, 8 Dec 2020 12:44:27 +0100
Subject: [PATCH] remove useless calls to strlen

---
 src/handle_check_address.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/handle_check_address.c b/src/handle_check_address.c
index e89a96a..50b9ddf 100644
--- a/src/handle_check_address.c
+++ b/src/handle_check_address.c
@@ -6,6 +6,11 @@
 
 #define ZERO(x) memset(x, 0, sizeof(x))
 
+static int os_strcmp(const char* s1, const char* s2) {
+    size_t size = strlen(s1) + 1;
+    return memcmp(s1, s2, size);
+}
+
 int handle_check_address(check_address_parameters_t* params, chain_config_t* chain_config) {
     PRINTF("Params on the address %d\n", (unsigned int) params);
     PRINTF("Address to check %s\n", params->address_to_check);
@@ -64,11 +69,8 @@ int handle_check_address(check_address_parameters_t* params, chain_config_t* cha
         offset_0x = 2;
     }
 
-    if ((strlen(locals_union1.address) != strlen(params->address_to_check + offset_0x)) ||
-        memcmp(locals_union1.address,
-               params->address_to_check + offset_0x,
-               strlen(locals_union1.address)) != 0) {
-        PRINTF("Addresses doesn't match\n");
+    if (os_strcmp(locals_union1.address, params->address_to_check + offset_0x) != 0) {
+        PRINTF("Addresses don't match\n");
         return 0;
     }
     PRINTF("Addresses  match\n");