Code improvements / Fix warnings
- Fix CodeQL warnings - Port lots of improvements/fixes from PR #225 - replace 'array_hexstr' and '%*H' format by sdk function 'format_hex' - Add 'noreturn' attribute in 'main.c'
This commit is contained in:
@@ -1,21 +1,20 @@
|
||||
#include "shared_context.h"
|
||||
#include "ui_callbacks.h"
|
||||
#include "common_712.h"
|
||||
#include "uint_common.h"
|
||||
|
||||
void prepare_domain_hash_v0() {
|
||||
snprintf(strings.tmp.tmp,
|
||||
sizeof(strings.tmp.tmp),
|
||||
"0x%.*H",
|
||||
KECCAK256_HASH_BYTESIZE,
|
||||
tmpCtx.messageSigningContext712.domainHash);
|
||||
bytes_to_string(strings.tmp.tmp,
|
||||
sizeof(strings.tmp.tmp),
|
||||
tmpCtx.messageSigningContext712.domainHash,
|
||||
KECCAK256_HASH_BYTESIZE);
|
||||
}
|
||||
|
||||
void prepare_message_hash_v0() {
|
||||
snprintf(strings.tmp.tmp,
|
||||
sizeof(strings.tmp.tmp),
|
||||
"0x%.*H",
|
||||
KECCAK256_HASH_BYTESIZE,
|
||||
tmpCtx.messageSigningContext712.messageHash);
|
||||
bytes_to_string(strings.tmp.tmp,
|
||||
sizeof(strings.tmp.tmp),
|
||||
tmpCtx.messageSigningContext712.messageHash,
|
||||
KECCAK256_HASH_BYTESIZE);
|
||||
}
|
||||
|
||||
// clang-format off
|
||||
@@ -46,7 +45,7 @@ UX_STEP_NOCB_INIT(
|
||||
UX_STEP_CB(
|
||||
ux_sign_712_v0_flow_4_step,
|
||||
pbb,
|
||||
ui_712_approve_cb(NULL),
|
||||
ui_712_approve_cb(),
|
||||
{
|
||||
&C_icon_validate_14,
|
||||
"Sign",
|
||||
@@ -55,7 +54,7 @@ UX_STEP_CB(
|
||||
UX_STEP_CB(
|
||||
ux_sign_712_v0_flow_5_step,
|
||||
pbb,
|
||||
ui_712_reject_cb(NULL),
|
||||
ui_712_reject_cb(),
|
||||
{
|
||||
&C_icon_crossmark,
|
||||
"Cancel",
|
||||
|
||||
Reference in New Issue
Block a user