d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Code improvements / Fix warnings

Browse Source 
- Fix CodeQL warnings
- Port lots of improvements/fixes from PR #225
- replace 'array_hexstr' and '%*H' format by sdk function 'format_hex'
- Add 'noreturn' attribute in 'main.c'
This commit is contained in:
Charles-Edouard de la Vergne
2024-04-12 16:40:05 +02:00
parent 90d536402b
commit aa38ee9959
29 changed files with 103 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src_plugins/erc1155/erc1155_plugin.c
View File

@@ -27,7 +27,7 @@ static void handle_init_contract(void *parameters) {
}
uint8_t i;
for (i = 0; i < SELECTORS_COUNT; i++) {
if (memcmp((uint8_t *) PIC(ERC1155_SELECTORS[i]), msg->selector, SELECTOR_SIZE) == 0) {
if (memcmp(PIC(ERC1155_SELECTORS[i]), msg->selector, SELECTOR_SIZE) == 0) {
context->selectorIndex = i;
break;
}

2
src_plugins/erc20/erc20_plugin.c
View File

@@ -64,7 +64,7 @@ const contract_t CONTRACTS[NUM_CONTRACTS] = {
bool check_contract(erc20_parameters_t *context) {
for (size_t i = 0; i < NUM_CONTRACTS; i++) {
contract_t *contract = (contract_t *) PIC(&CONTRACTS[i]);
const contract_t *contract = (const contract_t *) PIC(&CONTRACTS[i]);
if (memcmp(contract->address, context->destinationAddress, ADDRESS_LENGTH) == 0) {
strlcpy(context->contract_name, contract->name, sizeof(context->contract_name));
return true;

2
src_plugins/erc721/erc721_plugin.c
View File

@@ -32,7 +32,7 @@ static void handle_init_contract(void *parameters) {
}
uint8_t i;
for (i = 0; i < SELECTORS_COUNT; i++) {
if (memcmp((uint8_t *) PIC(ERC721_SELECTORS[i]), msg->selector, SELECTOR_SIZE) == 0) {
if (memcmp(PIC(ERC721_SELECTORS[i]), msg->selector, SELECTOR_SIZE) == 0) {
context->selectorIndex = i;
break;
}

2
src_plugins/eth2/eth2_plugin.c
View File

@@ -199,7 +199,7 @@ void eth2_plugin_call(int message, void *parameters) {
switch (msg->screenIndex) {
case 0: { // Amount screen
uint8_t decimals = WEI_TO_ETHER;
char *ticker = chainConfig->coinName;
const char *ticker = chainConfig->coinName;
strlcpy(msg->title, "Amount", msg->titleLength);
if (!amountToString(tmpContent.txContent.value.value,
tmpContent.txContent.value.length,