28 Commits

Author SHA1 Message Date
apaillier-ledger
44b5a23785 Fix Wanchain (#615)
* fix Wanchain app sign error

* remove redundant path

---------

Co-authored-by: zhwir <zhwir@163.com>
2024-07-26 10:46:52 +02:00
Alexandre Paillier
4770b55f46 New blind-signing flow for LNSP/LNX 2024-06-25 15:44:51 +02:00
Charles-Edouard de la Vergne
36ae183a1c Fix deprecated warnings 2024-03-27 14:43:15 +01:00
Alexandre Paillier
015842d4e5 Simplified adding new clones
Removed dead code from the app (was safeguarded by #ifdefs of macros
that weren't defined)
2023-10-04 18:06:52 +02:00
Alexandre Paillier
ab67ae1cb3 Merge remote-tracking branch 'origin/develop' into HEAD 2022-09-14 17:27:25 +02:00
Clement Bouvet
89eeaa7b7d eth: split ux from rest of source 2022-08-24 10:35:16 +02:00
Alexandre Paillier
895c37e1fa Change apdu payload length to proper size (8 bits) 2022-08-05 17:52:20 +02:00
Jorge Martins
2811917658 Mark pointer to databuffer/workbuffer as const 2022-07-15 12:33:19 +02:00
Jorge Martins
e0218520d8 Fix multiple vulnerabilities 2022-07-08 11:12:50 +02:00
Jean P
a53a2428cc Fix nft transactions (#229)
* Removed pluginType "hack"

* Fix some ERC 721 & 1155 function signature hashes

* Fix UI for ERC721 operations

* Explicit Batch Transfer UI with ERC1155

* Unified some ERC721 & 1155 non-static functions naming

* Fix UI for ERC1155 operations

* Added missing pin-lock check when signing transactions

* Fix the shell script that builds the elf files for testing

* Add tests dependency ethers

* Removed the space in the test filename

* Tests build script refactoring

* Now works when called from anywhere (not just the script's directory)
* Now handles LNS & LNX builds together (less duplicated code)

* Temporarily disable Nano X tests

Until Zemu supports Nano X 2.0 SDK

* Tests now start with blind signing disabled

Makes it closer to reality & very few of them requires it

* Update to the latest sdk version

* make eth_plugin_perform_init() readable

Introduce 2 functions.

* Now properly parses the apdu and displays the total quantity of NFT IDs transferred in ERC1155 batch transfer

* Add NFT prod public keys

* Added extra checks for the chain ID handling

Following the security review

* NFTs now only supported by LNS

* Version bump

Co-authored-by: Alexandre Paillier <alexandre.paillier@ledger.fr>
Co-authored-by: greenknot <greenknot@users.noreply.github.com>
2021-12-17 12:04:51 +01:00
apaillier-ledger
fcc3dd6d31 Add support for ERC-721 and ERC-1155 (v3) (#218)
* First draft for erc721 token allowance

* Split ui and provide parameters into their own files

* Print txtype when not supported

* fix compilation for erc721

* Use pluginType

* Add debug statement in compound plugin

* add debug error msg in plugin error

* Add parameter parsing for all methods

* Remove debug logs

* Add SET_APPROVAL_FOR_ALL; Add correct parsing method on contract init

* Add dst_size parameter to copy functions

* Add query contract id code

* format

* Add UIs

* update ethapp.asc

* Change setExternalPlugin to setPlugin; Add support for ERC721

* clang-format

* Fix typo Unconsistent -> Inconsistent

* Add support for 721; use extraInfo

* Add extraInfo to ethpluginQueryConractUI

* Rename extraInfo to item

* Add txFromEtherscan to tests

* Add nft key and temp padding

* Remove comments around HAVE_BYPASS_SIGNATURES

* Rename TESTING_KEY to NFT_TESTING_KEY

* Add comments regarding value of queryContractUI->item

* Fix comment regarding method selector

* Rename provideToken to provideInfo; Update plugin doc

* fix caps of eth_plugin_prepare_provide_info

* fix caps of handle_provide_info

* Use verificationFn insead of hardcoded cx_ecdsa_verify

* Add comments about nftInfo_t and tokenDefinition_t

* Add erc721 test

* Remove comment from plugin interface version

* Fix network_ticker duplicate

* Add setPlugin and provideNFTInfo to doc.asc

* Add back setExternalPlugin; implement new setPlugin

* Update plugin sdk

* Call setPlugin instead of setExternalPlugin

* setPlugin work without checking sig

* Remove printf of displayed fees

* Add working 721 test

* Finalize ERC721 and add simple test

* Display NFT address on set approval and operator

* Support set approval for all for erc721

* Finish UI for set approval for all erc721

* Move copy_parameter and copy_address to eth_plugin_internal; Add tests for erc721

* update plugin sdk

* Add erc1155 plugin and 1155 tests placeholder

* Add restriction for AWS key and setPlugin

* Add NOT_OLD_INTERNAL variant; Add erc_1155_plugin_call

* Fixed compilation warnings (function pointer casting)

Co-authored-by: pscott <scott.piriou@ledger.fr>
2021-11-22 14:39:36 +01:00
pscott
f2ff741767 Increase size of V 2021-08-27 14:47:59 +02:00
pscott
d04dcd8dc6 Add printf for txtype; Fix txtype init 2021-08-04 17:42:09 +02:00
pscott
06075c9586 Sign txType byte 2021-07-31 14:21:10 +02:00
pscott
0bff1de52c Add setting to display detailed fees 2021-06-29 16:04:38 +02:00
pscott
df4fe3c0dd Implement support for EIP1559; No settings 2021-06-29 16:04:38 +02:00
pscott
f250865bcb Merge branch 'master' of github.com:LedgerHQ/app-ethereum into fix_security_and_display_issues 2021-05-04 12:14:44 +02:00
pscott
0af10691eb Verify return value of plugin 2021-04-23 19:15:30 +02:00
pscott
970f0355dd Add support for EIP2718 (enveloppe) and EIP2930 (acess list tx); Display chain ID when different from 1 (ethereum mainnet) 2021-04-21 16:56:17 +02:00
pscott
5dd99c3d48 Move TxType parsing in cmd_signTx and add 0x6501 error 2021-04-15 17:59:41 +02:00
TamtamHero
17bd07a346 Apply clang-format 2020-12-01 16:20:13 +01:00
TamtamHero
7e1bdce835 Fix basic transacting 2020-11-16 17:06:43 +01:00
BTChip github
38da718b00 Plugins support WIP 2020-11-16 17:06:37 +01:00
TamtamHero
62a144b22b Remove Ledger Blue specific code, and other unused discriminants 2020-10-20 15:22:22 +02:00
TamtamHero
eac45259da Remove trailing whitespaces 2020-10-07 16:56:40 +02:00
TamtamHero
c2e3d75328 Fix broken error reporting 2020-09-14 14:43:37 +02:00
TamtamHero
9d4dfbe1bf Add Swap feature 2020-09-14 14:43:36 +02:00
BTChip github
8d0544bf68 Merge Starkware branch 2020-06-27 13:24:04 +02:00