Commit Graph

37 Commits

Author SHA1 Message Date
Alexandre Paillier
2474bdb81a Merge remote-tracking branch 'origin/develop' into HEAD 2022-10-17 11:44:28 +02:00
Alexandre Paillier
f43d9c4dc7 Fix EIP-191 UI split 2022-10-06 15:11:30 +02:00
Alexandre Paillier
e9ecf2e109 Activate full EIP-191 implementation on LNS + with adequate wording 2022-10-04 13:59:50 +02:00
Lucas PASCAL
3f294f9582 Minor fixes after review 2022-09-16 14:43:51 +02:00
Alexandre Paillier
ba34e37bce Downgrade to make the app fit on LNS 2022-09-15 16:49:20 +02:00
Alexandre Paillier
50dd4f5965 Linting + updated to clang-format 12.0.1 2022-09-15 16:49:19 +02:00
Alexandre Paillier
218098efe9 Removed unused header includes from EIP-191 2022-09-15 16:49:19 +02:00
Alexandre Paillier
eec44e994a Removed duplicated function signature of ui_idle 2022-09-15 16:49:19 +02:00
Alexandre Paillier
f46ed72c60 Reimplement the status words for EIP-191 error cases without throwing 2022-09-15 16:49:18 +02:00
Alexandre Paillier
e93d82c104 Better separation between EIP-191 UI & business logic 2022-09-15 16:49:18 +02:00
Alexandre Paillier
4bbc142ee5 Doxygen comments 2022-09-15 16:49:15 +02:00
Alexandre Paillier
40f00bb012 Minimize the RAM used by EIP-191 global variables 2022-09-15 13:25:10 +02:00
Alexandre Paillier
aedf6026c7 Handling of EIP191 non ASCII messages 2022-09-15 13:25:09 +02:00
Alexandre Paillier
81e15e51e8 Fix skip issue 2022-09-15 13:25:09 +02:00
Alexandre Paillier
493ce85c3b New implementation 2022-09-15 13:25:08 +02:00
Alexandre Paillier
ab67ae1cb3 Merge remote-tracking branch 'origin/develop' into HEAD 2022-09-14 17:27:25 +02:00
Alexandre Paillier
a58d2ababb Removed unused bagl type references in EIP-191 code 2022-09-14 11:08:10 +02:00
Clement Bouvet
89eeaa7b7d eth: split ux from rest of source 2022-08-24 10:35:16 +02:00
Alexandre Paillier
0cc75edf69 EIP712 code Doxygen comments pass 2022-08-05 18:15:57 +02:00
Alexandre Paillier
895c37e1fa Change apdu payload length to proper size (8 bits) 2022-08-05 17:52:20 +02:00
Jorge Martins
2811917658 Mark pointer to databuffer/workbuffer as const 2022-07-15 12:33:19 +02:00
Jorge Martins
e0218520d8 Fix multiple vulnerabilities 2022-07-08 11:12:50 +02:00
Alexandre Paillier
2ed6a4502d Linting fix following review 2022-06-10 09:47:32 +02:00
yhql
6768ccaf78 Eip191 review (#314)
* Avoid using a global for is_ascii

* Fix unused var, missing init, and use size_t for length

* Use snprintf where possible
2022-06-10 09:45:12 +02:00
Alexandre Paillier
5dc1a0cfcd EIP-191 clear signing 2022-06-08 11:45:20 +02:00
Alexandre Paillier
23202f6a63 Minimize includes in header files to what they depend on 2022-03-09 15:23:53 +01:00
Jean-Baptiste Bédrune
cd78581ffd Fix all the defects identified by Clang Static Analyzer
Some fixes are dirty, but it is a start to enforce scan-build on
every commit.

Signed-off-by: pscott <scott.piriou@ledger.fr>
2021-07-27 12:09:22 +02:00
pscott
b646cf1b28 Fix compilation warnings (#159)
* Fix easy warnings for sdk 2.0

* Add attribute unused to bagl_elemt_t in callback functions

* Add attribute unused to io_event function

* Clang-format

* Use elfs from CI in tests (#167)

* Add Nano X build

* Use CI's build artifacts for CI's tests

* Add network display (#152)

* Add network name display instead of chainID

* Add display of correct ticker along with network

* Add FTM

* Clang-format

* Add comment in python script

* Rename SIZE_MAX to MAX_SIZE

* Change %u to %d in printf

* Remove needless PIC

* Update comment about get_chain_id()

* Update example script to follow EIP155

* Remove unused PIC calls

* Add whitespace between ticker and amount when using EIP155

* Remove decimal config per network, set back 18 everywhere

* Adapt u32_from_BE to swith cases

* Remove chainid from signTx.py

* Switch to switch in stead of if in get_chain_id

* Revert "Remove chainid from signTx.py"

This reverts commit 454e09f280ec3e3ec1c7d7cc0027247ef4390088.

* Change Ethereum chainid to 1

* Rename chainid_step to network_step

* Adapt finalizeParsing to new chainid for Ethereum

* Update snapshots

* clang-format

* Fix network display logic for clones

* Fix tests

* Add clone tests

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>

Co-authored-by: Jean P <10632523+TamtamHero@users.noreply.github.com>
2021-07-05 11:01:51 +02:00
pscott
5fd27ff5ca Use INT256_LENGTH and ADDRESS_LENGTH define 2021-06-08 10:24:51 +02:00
TamtamHero
17bd07a346 Apply clang-format 2020-12-01 16:20:13 +01:00
BTChip github
1a311684a2 Replace memset by expilcit_bzero for critical data 2020-11-30 18:22:21 +01:00
BTChip github
d43f7f6698 Cleanup os_mem* functions 2020-11-30 18:22:17 +01:00
TamtamHero
1f9ef34845 Use recommanded UX macros from recents SDKs 2020-10-20 15:40:31 +02:00
TamtamHero
62a144b22b Remove Ledger Blue specific code, and other unused discriminants 2020-10-20 15:22:22 +02:00
TamtamHero
eac45259da Remove trailing whitespaces 2020-10-07 16:56:40 +02:00
TamtamHero
9d4dfbe1bf Add Swap feature 2020-09-14 14:43:36 +02:00
BTChip github
8d0544bf68 Merge Starkware branch 2020-06-27 13:24:04 +02:00