- Fix CodeQL warnings
- Port lots of improvements/fixes from PR #225
- replace 'array_hexstr' and '%*H' format by sdk function 'format_hex'
- Add 'noreturn' attribute in 'main.c'
Before was not possible to abort the signing process even if the plugin
return an error code. According to the docs any return code besides
ETH_PLUGIN_RESULT_OK should abort the signing process.
* Removed pluginType "hack"
* Fix some ERC 721 & 1155 function signature hashes
* Fix UI for ERC721 operations
* Explicit Batch Transfer UI with ERC1155
* Unified some ERC721 & 1155 non-static functions naming
* Fix UI for ERC1155 operations
* Added missing pin-lock check when signing transactions
* Fix the shell script that builds the elf files for testing
* Add tests dependency ethers
* Removed the space in the test filename
* Tests build script refactoring
* Now works when called from anywhere (not just the script's directory)
* Now handles LNS & LNX builds together (less duplicated code)
* Temporarily disable Nano X tests
Until Zemu supports Nano X 2.0 SDK
* Tests now start with blind signing disabled
Makes it closer to reality & very few of them requires it
* Update to the latest sdk version
* make eth_plugin_perform_init() readable
Introduce 2 functions.
* Now properly parses the apdu and displays the total quantity of NFT IDs transferred in ERC1155 batch transfer
* Add NFT prod public keys
* Added extra checks for the chain ID handling
Following the security review
* NFTs now only supported by LNS
* Version bump
Co-authored-by: Alexandre Paillier <alexandre.paillier@ledger.fr>
Co-authored-by: greenknot <greenknot@users.noreply.github.com>
* First draft for erc721 token allowance
* Split ui and provide parameters into their own files
* Print txtype when not supported
* fix compilation for erc721
* Use pluginType
* Add debug statement in compound plugin
* add debug error msg in plugin error
* Add parameter parsing for all methods
* Remove debug logs
* Add SET_APPROVAL_FOR_ALL; Add correct parsing method on contract init
* Add dst_size parameter to copy functions
* Add query contract id code
* format
* Add UIs
* update ethapp.asc
* Change setExternalPlugin to setPlugin; Add support for ERC721
* clang-format
* Fix typo Unconsistent -> Inconsistent
* Add support for 721; use extraInfo
* Add extraInfo to ethpluginQueryConractUI
* Rename extraInfo to item
* Add txFromEtherscan to tests
* Add nft key and temp padding
* Remove comments around HAVE_BYPASS_SIGNATURES
* Rename TESTING_KEY to NFT_TESTING_KEY
* Add comments regarding value of queryContractUI->item
* Fix comment regarding method selector
* Rename provideToken to provideInfo; Update plugin doc
* fix caps of eth_plugin_prepare_provide_info
* fix caps of handle_provide_info
* Use verificationFn insead of hardcoded cx_ecdsa_verify
* Add comments about nftInfo_t and tokenDefinition_t
* Add erc721 test
* Remove comment from plugin interface version
* Fix network_ticker duplicate
* Add setPlugin and provideNFTInfo to doc.asc
* Add back setExternalPlugin; implement new setPlugin
* Update plugin sdk
* Call setPlugin instead of setExternalPlugin
* setPlugin work without checking sig
* Remove printf of displayed fees
* Add working 721 test
* Finalize ERC721 and add simple test
* Display NFT address on set approval and operator
* Support set approval for all for erc721
* Finish UI for set approval for all erc721
* Move copy_parameter and copy_address to eth_plugin_internal; Add tests for erc721
* update plugin sdk
* Add erc1155 plugin and 1155 tests placeholder
* Add restriction for AWS key and setPlugin
* Add NOT_OLD_INTERNAL variant; Add erc_1155_plugin_call
* Fixed compilation warnings (function pointer casting)
Co-authored-by: pscott <scott.piriou@ledger.fr>
* Fix deprecated os_memmove warning
Switched to the standard memmove function
* Fix get_network_ticker implicit declaration warning
Included the required missing header file
* Removed useless execution rights from Makefile
* Fix directory name in README
* Add network ticker to queryContractUI for plugins use
* Update sdk deps
* Bump version 1.9.11
* Fix blockSize error when bytes is optimized by EVM
Co-authored-by: pscott <scott.piriou@ledger.fr>
* Add some PRINTF debug statements and fir additional screens init
* Memzero struture and use two pointers less
* Clang-format
* Use ADDRESS_LENGTH where possible; Add printf statements when failing to compare contracts
* clang-format
* Remove 'token1' and 'token2' locals
* Fix typo
* apply clang-format
* Add bip32path to sharedRO for plugins
* Change getEthAddressStringFromKey to accept char instead of uint8_t
* Update ethereum plugin sdk
* Add BYPASS_SIGNATURES compilation option
* Remove bip32path and pathLength from sharedRO; add msg_sender pointer to pluginFinalize.address
* clang format eth_plugin_interface
* Update submodule
* Set address BEFORE making the finalize call
* Update SDK
Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
* Fix easy warnings for sdk 2.0
* Add attribute unused to bagl_elemt_t in callback functions
* Add attribute unused to io_event function
* Clang-format
* Use elfs from CI in tests (#167)
* Add Nano X build
* Use CI's build artifacts for CI's tests
* Add network display (#152)
* Add network name display instead of chainID
* Add display of correct ticker along with network
* Add FTM
* Clang-format
* Add comment in python script
* Rename SIZE_MAX to MAX_SIZE
* Change %u to %d in printf
* Remove needless PIC
* Update comment about get_chain_id()
* Update example script to follow EIP155
* Remove unused PIC calls
* Add whitespace between ticker and amount when using EIP155
* Remove decimal config per network, set back 18 everywhere
* Adapt u32_from_BE to swith cases
* Remove chainid from signTx.py
* Switch to switch in stead of if in get_chain_id
* Revert "Remove chainid from signTx.py"
This reverts commit 454e09f280ec3e3ec1c7d7cc0027247ef4390088.
* Change Ethereum chainid to 1
* Rename chainid_step to network_step
* Adapt finalizeParsing to new chainid for Ethereum
* Update snapshots
* clang-format
* Fix network display logic for clones
* Fix tests
* Add clone tests
Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
Co-authored-by: Jean P <10632523+TamtamHero@users.noreply.github.com>