Commit Graph

177 Commits

Author SHA1 Message Date
Lucas PASCAL
653b64d6f7 [clean] Removing compound-related plugin code 2022-06-21 15:38:51 +02:00
Alexandre Paillier
b483804ff4 adding astar&shiden 2022-06-15 13:35:46 +02:00
Alexandre Paillier
785cfdc2ea cube 2022-06-15 13:35:44 +02:00
Alexandre Paillier
d1eb4ccc92 okc 2022-06-15 12:07:14 +02:00
Alexandre Paillier
8bc541b994 Increased display value buffer size for LNX & LNS+ 2022-06-08 11:45:20 +02:00
Lucas PASCAL
66ac35bc6f [add] Extending the amount buffer from 30 to 50 bytes + adding some const fields 2022-04-25 16:54:07 +02:00
Alexandre Paillier
78d159761d Linting pass following the clang-format update 2022-04-13 15:52:29 +02:00
tjulien-ledger
6b24a045ce Multiple ETH PRs (#289)
* adding Conflux espace

* adding Moonbeam

* kardiachain and bttc

* adding Wethio
2022-04-13 15:37:30 +02:00
BTChip github
52738e6bf5 Make lint happier 2022-03-22 08:40:36 +01:00
BTChip github
78f4642b6c Add EIP 1024 APDUs 2022-03-22 08:23:30 +01:00
Alexandre Paillier
faf2044108 Bump plugin interface version 2022-03-15 14:19:30 +01:00
Alexandre Paillier
a26da165df Now prevents NFT signatures without NFT metadata 2022-03-09 16:40:42 +01:00
Alexandre Paillier
fed91e2261 Removed old os_strcmp function 2022-03-09 15:23:55 +01:00
Alexandre Paillier
23202f6a63 Minimize includes in header files to what they depend on 2022-03-09 15:23:53 +01:00
Alexandre Paillier
c548aba364 Unify the include guards accross all header files 2022-03-09 11:52:03 +01:00
Alexandre Paillier
89070cd2be Now only loops through tokens once to match it 2022-03-09 11:52:03 +01:00
Alexandre Paillier
76c7f9dbd8 Fixes the location in memory of the address between nftInfo_t & tokenDefinition_t
Both used as members of the same union, also unifies the type (array of uint8_t)
2022-03-08 16:16:40 +01:00
Jean-Baptiste Bédrune
0d9c868a77 Set const qualifier for input buffers for copy functions 2022-02-22 00:08:49 +01:00
Jean-Baptiste Bédrune
ed4e10628a Change type of output length in amountToString
Defining out_buffer_size as uint8_t triggers warnings with static
analysers when sizeof() is used on the output buffer.

There is no reason to use uint8_t here.
2022-02-21 23:56:08 +01:00
Jean-Baptiste Bédrune
89fddf3ef8 Set const qualifiers in few fields used by the plugin interface 2022-02-21 23:46:54 +01:00
lpascal-ledger
bf9bfb3ee7 Merge pull request #231 from LedgerHQ/fix/printable_fees
[fix] Get printable amount handle should not parse configuration for ticker and decimal if the amount is a fee
2022-02-15 15:21:56 +01:00
Alexandre Paillier
2e63a428b2 Removed useless header include in shared_context.h
Could easily create a circular header dependency
2022-02-15 14:13:55 +01:00
Lucas PASCAL
1b24fc2eca [fix] Get printable amount handle should not parse configuration for ticker and decimal if the amount is a fee 2022-02-15 11:46:19 +01:00
Edouard Merle
617b60483f fix: build for lns+ 2022-02-08 16:43:45 +01:00
greenknot
3c36c41d3e enclose COLLECTION_NAME_MAX_LEN and HEADER_SIZE in parentheses
to prevent future potential issues.
2022-01-20 10:37:04 +01:00
Alexandre Paillier
eb531de5d2 [clean] Linting pass 2022-01-14 17:33:20 +01:00
Alexandre Paillier
8fd033e32a Merge remote-tracking branch 'origin/master' into fix/version_adjustment 2022-01-14 17:22:51 +01:00
Noel Moldvai
c8bf437424 Add Shyft support 2022-01-14 10:38:58 +01:00
Jean P
a53a2428cc Fix nft transactions (#229)
* Removed pluginType "hack"

* Fix some ERC 721 & 1155 function signature hashes

* Fix UI for ERC721 operations

* Explicit Batch Transfer UI with ERC1155

* Unified some ERC721 & 1155 non-static functions naming

* Fix UI for ERC1155 operations

* Added missing pin-lock check when signing transactions

* Fix the shell script that builds the elf files for testing

* Add tests dependency ethers

* Removed the space in the test filename

* Tests build script refactoring

* Now works when called from anywhere (not just the script's directory)
* Now handles LNS & LNX builds together (less duplicated code)

* Temporarily disable Nano X tests

Until Zemu supports Nano X 2.0 SDK

* Tests now start with blind signing disabled

Makes it closer to reality & very few of them requires it

* Update to the latest sdk version

* make eth_plugin_perform_init() readable

Introduce 2 functions.

* Now properly parses the apdu and displays the total quantity of NFT IDs transferred in ERC1155 batch transfer

* Add NFT prod public keys

* Added extra checks for the chain ID handling

Following the security review

* NFTs now only supported by LNS

* Version bump

Co-authored-by: Alexandre Paillier <alexandre.paillier@ledger.fr>
Co-authored-by: greenknot <greenknot@users.noreply.github.com>
2021-12-17 12:04:51 +01:00
TamtamHero
53d67418e5 Fix stark order signatures on LNS 2021-11-30 14:19:32 +01:00
apaillier-ledger
fcc3dd6d31 Add support for ERC-721 and ERC-1155 (v3) (#218)
* First draft for erc721 token allowance

* Split ui and provide parameters into their own files

* Print txtype when not supported

* fix compilation for erc721

* Use pluginType

* Add debug statement in compound plugin

* add debug error msg in plugin error

* Add parameter parsing for all methods

* Remove debug logs

* Add SET_APPROVAL_FOR_ALL; Add correct parsing method on contract init

* Add dst_size parameter to copy functions

* Add query contract id code

* format

* Add UIs

* update ethapp.asc

* Change setExternalPlugin to setPlugin; Add support for ERC721

* clang-format

* Fix typo Unconsistent -> Inconsistent

* Add support for 721; use extraInfo

* Add extraInfo to ethpluginQueryConractUI

* Rename extraInfo to item

* Add txFromEtherscan to tests

* Add nft key and temp padding

* Remove comments around HAVE_BYPASS_SIGNATURES

* Rename TESTING_KEY to NFT_TESTING_KEY

* Add comments regarding value of queryContractUI->item

* Fix comment regarding method selector

* Rename provideToken to provideInfo; Update plugin doc

* fix caps of eth_plugin_prepare_provide_info

* fix caps of handle_provide_info

* Use verificationFn insead of hardcoded cx_ecdsa_verify

* Add comments about nftInfo_t and tokenDefinition_t

* Add erc721 test

* Remove comment from plugin interface version

* Fix network_ticker duplicate

* Add setPlugin and provideNFTInfo to doc.asc

* Add back setExternalPlugin; implement new setPlugin

* Update plugin sdk

* Call setPlugin instead of setExternalPlugin

* setPlugin work without checking sig

* Remove printf of displayed fees

* Add working 721 test

* Finalize ERC721 and add simple test

* Display NFT address on set approval and operator

* Support set approval for all for erc721

* Finish UI for set approval for all erc721

* Move copy_parameter and copy_address to eth_plugin_internal; Add tests for erc721

* update plugin sdk

* Add erc1155 plugin and 1155 tests placeholder

* Add restriction for AWS key and setPlugin

* Add NOT_OLD_INTERNAL variant; Add erc_1155_plugin_call

* Fixed compilation warnings (function pointer casting)

Co-authored-by: pscott <scott.piriou@ledger.fr>
2021-11-22 14:39:36 +01:00
apaillier-ledger
a490532605 Fix compilation warnings (#216)
* Fix deprecated os_memmove warning

Switched to the standard memmove function

* Fix get_network_ticker implicit declaration warning

Included the required missing header file

* Removed useless execution rights from Makefile

* Fix directory name in README
2021-11-22 10:56:27 +01:00
Edouard Merle
a6a92cafe0 apply clang format
Signed-off-by: Edouard Merle <edouard.merle@ledger.fr>
2021-11-17 10:45:37 +01:00
Salvatore Ingala
29024c0c8b Avoid signed division
Signed-off-by: Edouard Merle <edouard.merle@ledger.fr>
2021-11-17 10:45:35 +01:00
TamtamHero
a7b2402bdb Apply clang-format-10 2021-11-17 09:50:28 +01:00
TamtamHero
6bad1c4b05 Fix stark order signatures on LNX 2021-11-17 09:50:03 +01:00
Jean P
3a47291fb1 Add Polygon as a variant (#207) 2021-10-28 18:17:05 +02:00
Jean P
3eeec97efa Share network ticker with plugins (#205)
* Add network ticker to queryContractUI for plugins use

* Update sdk deps

* Bump version 1.9.11

* Fix blockSize error when bytes is optimized by EVM

Co-authored-by: pscott <scott.piriou@ledger.fr>
2021-10-28 18:10:21 +02:00
estienne.antoine@gmail.com
50a1536045 sync with master 2021-10-08 12:18:21 +02:00
Jean P
2e5b675cd3 Revert "Revert "blind sign" wording (#203)" (#204)
This reverts commit 53599fb81c.
2021-10-08 10:29:12 +02:00
Neozaru
6ac7be1277 feat: goerli build (#202)
* feat: goerli build

* Apply clang-format-10

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
2021-10-06 14:13:33 +02:00
Jean P
53599fb81c Revert "blind sign" wording (#203)
* Rollback wording changes of contract data to blind signing

* Update tests
2021-10-06 12:02:46 +02:00
estienne.antoine@gmail.com
84a6d18510 Merge remote-tracking branch 'ledgertech/master' into jlm-copy-for-moonriver 2021-10-04 18:57:47 +02:00
estienne.antoine@gmail.com
7bbdb24be4 add moonrriver 2021-10-04 18:55:46 +02:00
Jean P
408805f751 Fix big amounts (#199)
* Fix wrong display of amounts >= 2^87

* Add test to check that amounts >= 2^87 make the app throw

* Bump v1.9.7 and update changelog
2021-10-04 11:26:01 +02:00
Jean P
fb7204fb6c Fix fees overwrite in starkware plugin (#198)
* increase display buffer size to handle Starkware master key and control size when using snprintf

* Bump version 1.9.6

* Fix broken tests

* Add first starkware tests

* Add some constants for starkware

* Update CHANGELOG.md
2021-09-29 18:39:10 +02:00
Jean P
fa355a5d97 Add a UI warning when contract data are not enabled in the settings (#193)
* Add a UI warning when contract data are not enabled in the settings

* Update wording "contract data" -> "blind signing" to raise awareness

* Bump version 1.9.5

* remove hardcoded path in helper build script

* Add blind signature test

* Add snapshot-tmp to gitignore

* Remove unused snapshots

* Increase tests timings

* Remove unused snapshots

* Fix and rename compound blind deposit test

* Update Approve and Transfer tests

* Update tests

* Cosmetic changes + disable debug flag

* Update CHANGELOG.md
2021-09-28 12:32:06 +02:00
pscott
b67d6d65b8 Remove tokens from ethereum app; Add comments about tokens 2021-09-14 10:48:23 +02:00
pscott
ae28843c6c Merge branch 'TowoLabs-master' into bigger_chainid 2021-09-03 15:02:30 +02:00
pscott
fd48a2c1a2 Remove theta, flare and flare_coston 2021-09-03 14:55:28 +02:00