Usually the length of an array is sent in a parameter.
Most of the times the developer simply uses U2BE/U4BE to get this length. It
is possible to forge a tx with a `length > sizeof(uint16_t/uint32_t)` and trick the
user into signing something different from what is shown.
For instance consider the following parameter:
00 ... 01 00 00 00 01
if the developer uses U2BE/U4BE, it is possible that this length is shown to the user
and if it is, the user will see the length as 1.
* First draft for erc721 token allowance
* Split ui and provide parameters into their own files
* Print txtype when not supported
* fix compilation for erc721
* Use pluginType
* Add debug statement in compound plugin
* add debug error msg in plugin error
* Add parameter parsing for all methods
* Remove debug logs
* Add SET_APPROVAL_FOR_ALL; Add correct parsing method on contract init
* Add dst_size parameter to copy functions
* Add query contract id code
* format
* Add UIs
* update ethapp.asc
* Change setExternalPlugin to setPlugin; Add support for ERC721
* clang-format
* Fix typo Unconsistent -> Inconsistent
* Add support for 721; use extraInfo
* Add extraInfo to ethpluginQueryConractUI
* Rename extraInfo to item
* Add txFromEtherscan to tests
* Add nft key and temp padding
* Remove comments around HAVE_BYPASS_SIGNATURES
* Rename TESTING_KEY to NFT_TESTING_KEY
* Add comments regarding value of queryContractUI->item
* Fix comment regarding method selector
* Rename provideToken to provideInfo; Update plugin doc
* fix caps of eth_plugin_prepare_provide_info
* fix caps of handle_provide_info
* Use verificationFn insead of hardcoded cx_ecdsa_verify
* Add comments about nftInfo_t and tokenDefinition_t
* Add erc721 test
* Remove comment from plugin interface version
* Fix network_ticker duplicate
* Add setPlugin and provideNFTInfo to doc.asc
* Add back setExternalPlugin; implement new setPlugin
* Update plugin sdk
* Call setPlugin instead of setExternalPlugin
* setPlugin work without checking sig
* Remove printf of displayed fees
* Add working 721 test
* Finalize ERC721 and add simple test
* Display NFT address on set approval and operator
* Support set approval for all for erc721
* Finish UI for set approval for all erc721
* Move copy_parameter and copy_address to eth_plugin_internal; Add tests for erc721
* update plugin sdk
* Add erc1155 plugin and 1155 tests placeholder
* Add restriction for AWS key and setPlugin
* Add NOT_OLD_INTERNAL variant; Add erc_1155_plugin_call
* Fixed compilation warnings (function pointer casting)
Co-authored-by: pscott <scott.piriou@ledger.fr>
* Add some PRINTF debug statements and fir additional screens init
* Memzero struture and use two pointers less
* Clang-format
* Use ADDRESS_LENGTH where possible; Add printf statements when failing to compare contracts
* clang-format
* Remove 'token1' and 'token2' locals
* Fix typo
* apply clang-format
* Add bip32path to sharedRO for plugins
* Change getEthAddressStringFromKey to accept char instead of uint8_t
* Update ethereum plugin sdk
* Add BYPASS_SIGNATURES compilation option
* Remove bip32path and pathLength from sharedRO; add msg_sender pointer to pluginFinalize.address
* clang format eth_plugin_interface
* Update submodule
* Set address BEFORE making the finalize call
* Update SDK
Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
