d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,750 Commits 1 Branch 0 Tags
ae359b481ef5f6cff7531a1f6b7f64dc10e4db9d
Commit Graph

34 Commits

Author SHA1 Message Date
Charles-Edouard de la Vergne
aa38ee9959 Code improvements / Fix warnings 
- Fix CodeQL warnings
- Port lots of improvements/fixes from PR #225
- replace 'array_hexstr' and '%*H' format by sdk function 'format_hex'
- Add 'noreturn' attribute in 'main.c'
 2024-04-26 11:09:18 +02:00
Charles-Edouard de la Vergne
36ae183a1c Fix deprecated warnings 2024-03-27 14:43:15 +01:00
Francois Beutin
3bcf12ce1d Rename utils to common_utils 2024-02-02 11:23:30 +01:00
Francois Beutin
3d9da0dd16 Move basic utility functions from ethUtils to main utils file 2024-02-02 11:23:28 +01:00
Alexandre Paillier
49da32af8e Added missing return value checks following recent changes 2023-10-10 16:42:24 +02:00
Alexandre Paillier
4cce06ca2c Fix compilation warnings 2023-05-16 11:42:31 +02:00
TamtamHero
0d45d2e2d0 Update some prototypes to use chainId value instead of chainConfig structure 2021-08-30 11:02:55 +02:00
TamtamHero
3e25f04d05 Refactoring helper to get printable eth address from hex 2021-08-30 11:00:51 +02:00
Jean-Baptiste Bédrune
cd78581ffd Fix all the defects identified by Clang Static Analyzer 
Some fixes are dirty, but it is a start to enforce scan-build on
every commit.

Signed-off-by: pscott <scott.piriou@ledger.fr>
 2021-07-27 12:09:22 +02:00
Jean-Baptiste Bédrune
c27d59d792 Fix last compilation warnings 
Signed-off-by: pscott <scott.piriou@ledger.fr>
 2021-07-27 12:09:22 +02:00
pscott
b646cf1b28 Fix compilation warnings (#159) 
* Fix easy warnings for sdk 2.0

* Add attribute unused to bagl_elemt_t in callback functions

* Add attribute unused to io_event function

* Clang-format

* Use elfs from CI in tests (#167)

* Add Nano X build

* Use CI's build artifacts for CI's tests

* Add network display (#152)

* Add network name display instead of chainID

* Add display of correct ticker along with network

* Add FTM

* Clang-format

* Add comment in python script

* Rename SIZE_MAX to MAX_SIZE

* Change %u to %d in printf

* Remove needless PIC

* Update comment about get_chain_id()

* Update example script to follow EIP155

* Remove unused PIC calls

* Add whitespace between ticker and amount when using EIP155

* Remove decimal config per network, set back 18 everywhere

* Adapt u32_from_BE to swith cases

* Remove chainid from signTx.py

* Switch to switch in stead of if in get_chain_id

* Revert "Remove chainid from signTx.py"

This reverts commit 454e09f280ec3e3ec1c7d7cc0027247ef4390088.

* Change Ethereum chainid to 1

* Rename chainid_step to network_step

* Adapt finalizeParsing to new chainid for Ethereum

* Update snapshots

* clang-format

* Fix network display logic for clones

* Fix tests

* Add clone tests

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>

Co-authored-by: Jean P <10632523+TamtamHero@users.noreply.github.com>
 2021-07-05 11:01:51 +02:00
pscott
a2d9a8068a Add network display (#152) 
* Add network name display instead of chainID

* Add display of correct ticker along with network

* Add FTM

* Clang-format

* Add comment in python script

* Rename SIZE_MAX to MAX_SIZE

* Change %u to %d in printf

* Remove needless PIC

* Update comment about get_chain_id()

* Update example script to follow EIP155

* Remove unused PIC calls

* Add whitespace between ticker and amount when using EIP155

* Remove decimal config per network, set back 18 everywhere

* Adapt u32_from_BE to swith cases

* Remove chainid from signTx.py

* Switch to switch in stead of if in get_chain_id

* Revert "Remove chainid from signTx.py"

This reverts commit 454e09f280ec3e3ec1c7d7cc0027247ef4390088.

* Change Ethereum chainid to 1

* Rename chainid_step to network_step

* Adapt finalizeParsing to new chainid for Ethereum

* Update snapshots

* clang-format

* Fix network display logic for clones

* Fix tests

* Add clone tests

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
 2021-07-02 18:46:23 +02:00
TamtamHero
ebc28881f7 bytes to bytes 2021-05-04 23:49:03 +02:00
pscott
3a1cd33f74 Fix segv 2021-05-04 13:41:43 +02:00
pscott
0547bc8a02 Clang format 2021-05-04 13:28:10 +02:00
pscott
76d982a539 Merge branch 'fix_security_and_display_issues' of github.com:LedgerHQ/app-ethereum into fix_security_and_display_issues 2021-05-04 12:15:08 +02:00
pscott
a88ed3de5d Do not used global sha3 for future-proofness 2021-05-04 12:11:18 +02:00
pscott
257ff60b9b Fix typo 2021-05-04 12:06:16 +02:00
pscott
653e5e667b Update INDEX_MAX to 2^16 2021-04-27 18:00:38 +02:00
pscott
0af10691eb Verify return value of plugin 2021-04-23 19:15:30 +02:00
pscott
fe2aab08a1 Add comment regarding arbitrary value of INDEX_MAX 2021-04-22 15:53:09 +02:00
pscott
d4bd5cac89 Fix compilation error 2021-04-22 15:06:12 +02:00
pscott
550fc86ba8 Remove INDEX_MAX from withdrawal_index.h ; set limit to 2^19 2021-04-22 14:57:30 +02:00
pscott
18822f9462 Move deposit_address to eth2_deposit_parameters_t 2021-04-22 14:39:46 +02:00
pscott
e76a7aa5ca Clang please 2021-04-22 14:08:02 +02:00
pscott
31ad5e3431 Remove comments 2021-04-22 14:04:09 +02:00
pscott
a4dcec436f Clang-format 2021-04-22 14:01:52 +02:00
pscott
b899edfaaf Display validator address 2021-04-22 13:57:09 +02:00
pscott
d1f5cd0286 Fix destinationLen computing 2021-04-22 11:40:12 +02:00
pscott
4c067f2a43 Add check for deposit contract address 2021-04-22 11:38:21 +02:00
pscott
6ff2172f1b Add upper bound for withdrawal index 2021-04-22 10:08:05 +02:00
TamtamHero
17bd07a346 Apply clang-format 2020-12-01 16:20:13 +01:00
BTChip github
235b4b1863 Fix Withdrawal key derivation path 2020-11-17 10:31:15 +01:00
BTChip github
7e53de8897 Add ETH 2 deposit handling 2020-11-17 10:31:15 +01:00