Commit Graph

150 Commits

Author SHA1 Message Date
Alexandre Paillier
b2fe2f26ba Implements the hashing part of typeHash 2022-08-05 17:52:29 +02:00
Alexandre Paillier
5889da054e Extracted the encodeType and typeHash functions from the main file 2022-08-05 17:52:28 +02:00
Alexandre Paillier
e3dfd787b5 Memory allocation checking 2022-08-05 17:52:28 +02:00
Alexandre Paillier
16081c38a9 Added some memory related debug features 2022-08-05 17:52:28 +02:00
Alexandre Paillier
59490beff9 Small type-enforcing refactoring + now properly gets typestrings 2022-08-05 17:52:27 +02:00
Alexandre Paillier
e57bc93c69 Fix stack overflow with long APDUs 2022-08-05 17:52:27 +02:00
Alexandre Paillier
161919c012 Simpler computing the string's length in memory 2022-08-05 17:52:26 +02:00
Alexandre Paillier
420afdf958 Small function to make formatting into memory of uint easier 2022-08-05 17:52:26 +02:00
Alexandre Paillier
e3a8e4ccd2 Big Refactoring
- moved some things in header files
- now uses memory allocation functions with automatic checks, small abstraction layer
2022-08-05 17:52:26 +02:00
Alexandre Paillier
3fda010667 Add memory functions 2022-08-05 17:52:25 +02:00
Alexandre Paillier
5438b39eb2 Fixes the index overflow, since header + data could be longer than 0xFF 2022-08-05 17:52:25 +02:00
Alexandre Paillier
63f454b29a Fixed ram usage message 2022-08-05 17:52:24 +02:00
Alexandre Paillier
024691eb64 Fix warning in release mode 2022-08-05 17:52:24 +02:00
Alexandre Paillier
545bc439fe Better implementation of enum(s)->typename memory structure 2022-08-05 17:52:24 +02:00
Alexandre Paillier
c3dc0c18ff Refactoring; added some utility functions to navigate the type definitions 2022-08-05 17:52:23 +02:00
Alexandre Paillier
3b6c32d707 Updated C code with new array handling 2022-08-05 17:52:23 +02:00
Alexandre Paillier
1bc8675473 Initial version 2022-08-05 17:52:22 +02:00
Alexandre Paillier
b25eaa1b48 Renamed the existing EIP712 implementation folder 2022-08-05 17:52:22 +02:00
Alexandre Paillier
895c37e1fa Change apdu payload length to proper size (8 bits) 2022-08-05 17:52:20 +02:00
Jorge Martins
143d0e54f6 Fix function signature 2022-07-15 12:51:30 +02:00
Jorge Martins
8cc2adbb0a Mark pointer to databuffer/workbuffer as const 2022-07-15 12:36:35 +02:00
Jorge Martins
2811917658 Mark pointer to databuffer/workbuffer as const 2022-07-15 12:33:19 +02:00
Jorge Martins
e0218520d8 Fix multiple vulnerabilities 2022-07-08 11:12:50 +02:00
Alexandre Paillier
2ed6a4502d Linting fix following review 2022-06-10 09:47:32 +02:00
yhql
6768ccaf78 Eip191 review (#314)
* Avoid using a global for is_ascii

* Fix unused var, missing init, and use size_t for length

* Use snprintf where possible
2022-06-10 09:45:12 +02:00
Alexandre Paillier
5dc1a0cfcd EIP-191 clear signing 2022-06-08 11:45:20 +02:00
Alexandre Paillier
df79977ee9 Fix EIP1024 warnings 2022-06-08 11:45:19 +02:00
Alexandre Paillier
78d159761d Linting pass following the clang-format update 2022-04-13 15:52:29 +02:00
BTChip github
52738e6bf5 Make lint happier 2022-03-22 08:40:36 +01:00
BTChip github
d04ed9aef1 Minor changes related to code review 2022-03-22 08:23:30 +01:00
BTChip github
78f4642b6c Add EIP 1024 APDUs 2022-03-22 08:23:30 +01:00
Alexandre Paillier
853a85205d Now checks if a proper plugin is loaded when receiving NFT metadata 2022-03-09 16:28:23 +01:00
Alexandre Paillier
23202f6a63 Minimize includes in header files to what they depend on 2022-03-09 15:23:53 +01:00
Alexandre Paillier
c548aba364 Unify the include guards accross all header files 2022-03-09 11:52:03 +01:00
Alexandre Paillier
76c7f9dbd8 Fixes the location in memory of the address between nftInfo_t & tokenDefinition_t
Both used as members of the same union, also unifies the type (array of uint8_t)
2022-03-08 16:16:40 +01:00
Jean-Baptiste Bédrune
458ef9af52 Define better prototype for "network" functions 2022-02-21 23:46:54 +01:00
Alexandre Paillier
2e63a428b2 Removed useless header include in shared_context.h
Could easily create a circular header dependency
2022-02-15 14:13:55 +01:00
Alexandre Paillier
7a92b65bf7 Fix typo in setPlugin 2022-02-14 18:15:19 +01:00
greenknot
6c03be385c use size_t instead of uint8_t to prevent potential integer overflows 2022-01-20 10:37:04 +01:00
greenknot
3c36c41d3e enclose COLLECTION_NAME_MAX_LEN and HEADER_SIZE in parentheses
to prevent future potential issues.
2022-01-20 10:37:04 +01:00
Alexandre Paillier
eb531de5d2 [clean] Linting pass 2022-01-14 17:33:20 +01:00
Jean P
a53a2428cc Fix nft transactions (#229)
* Removed pluginType "hack"

* Fix some ERC 721 & 1155 function signature hashes

* Fix UI for ERC721 operations

* Explicit Batch Transfer UI with ERC1155

* Unified some ERC721 & 1155 non-static functions naming

* Fix UI for ERC1155 operations

* Added missing pin-lock check when signing transactions

* Fix the shell script that builds the elf files for testing

* Add tests dependency ethers

* Removed the space in the test filename

* Tests build script refactoring

* Now works when called from anywhere (not just the script's directory)
* Now handles LNS & LNX builds together (less duplicated code)

* Temporarily disable Nano X tests

Until Zemu supports Nano X 2.0 SDK

* Tests now start with blind signing disabled

Makes it closer to reality & very few of them requires it

* Update to the latest sdk version

* make eth_plugin_perform_init() readable

Introduce 2 functions.

* Now properly parses the apdu and displays the total quantity of NFT IDs transferred in ERC1155 batch transfer

* Add NFT prod public keys

* Added extra checks for the chain ID handling

Following the security review

* NFTs now only supported by LNS

* Version bump

Co-authored-by: Alexandre Paillier <alexandre.paillier@ledger.fr>
Co-authored-by: greenknot <greenknot@users.noreply.github.com>
2021-12-17 12:04:51 +01:00
apaillier-ledger
fcc3dd6d31 Add support for ERC-721 and ERC-1155 (v3) (#218)
* First draft for erc721 token allowance

* Split ui and provide parameters into their own files

* Print txtype when not supported

* fix compilation for erc721

* Use pluginType

* Add debug statement in compound plugin

* add debug error msg in plugin error

* Add parameter parsing for all methods

* Remove debug logs

* Add SET_APPROVAL_FOR_ALL; Add correct parsing method on contract init

* Add dst_size parameter to copy functions

* Add query contract id code

* format

* Add UIs

* update ethapp.asc

* Change setExternalPlugin to setPlugin; Add support for ERC721

* clang-format

* Fix typo Unconsistent -> Inconsistent

* Add support for 721; use extraInfo

* Add extraInfo to ethpluginQueryConractUI

* Rename extraInfo to item

* Add txFromEtherscan to tests

* Add nft key and temp padding

* Remove comments around HAVE_BYPASS_SIGNATURES

* Rename TESTING_KEY to NFT_TESTING_KEY

* Add comments regarding value of queryContractUI->item

* Fix comment regarding method selector

* Rename provideToken to provideInfo; Update plugin doc

* fix caps of eth_plugin_prepare_provide_info

* fix caps of handle_provide_info

* Use verificationFn insead of hardcoded cx_ecdsa_verify

* Add comments about nftInfo_t and tokenDefinition_t

* Add erc721 test

* Remove comment from plugin interface version

* Fix network_ticker duplicate

* Add setPlugin and provideNFTInfo to doc.asc

* Add back setExternalPlugin; implement new setPlugin

* Update plugin sdk

* Call setPlugin instead of setExternalPlugin

* setPlugin work without checking sig

* Remove printf of displayed fees

* Add working 721 test

* Finalize ERC721 and add simple test

* Display NFT address on set approval and operator

* Support set approval for all for erc721

* Finish UI for set approval for all erc721

* Move copy_parameter and copy_address to eth_plugin_internal; Add tests for erc721

* update plugin sdk

* Add erc1155 plugin and 1155 tests placeholder

* Add restriction for AWS key and setPlugin

* Add NOT_OLD_INTERNAL variant; Add erc_1155_plugin_call

* Fixed compilation warnings (function pointer casting)

Co-authored-by: pscott <scott.piriou@ledger.fr>
2021-11-22 14:39:36 +01:00
Edouard Merle
f0f47e4250 export ux function for all targets
Signed-off-by: Edouard Merle <edouard.merle@ledger.fr>
2021-11-17 10:45:37 +01:00
Jean P
3eeec97efa Share network ticker with plugins (#205)
* Add network ticker to queryContractUI for plugins use

* Update sdk deps

* Bump version 1.9.11

* Fix blockSize error when bytes is optimized by EVM

Co-authored-by: pscott <scott.piriou@ledger.fr>
2021-10-28 18:10:21 +02:00
Edouard Merle
bee6a57f89 remove legacy ux paging function 2021-10-27 15:54:22 +02:00
Jean P
2e5b675cd3 Revert "Revert "blind sign" wording (#203)" (#204)
This reverts commit 53599fb81c.
2021-10-08 10:29:12 +02:00
Jean P
53599fb81c Revert "blind sign" wording (#203)
* Rollback wording changes of contract data to blind signing

* Update tests
2021-10-06 12:02:46 +02:00
Jean P
408805f751 Fix big amounts (#199)
* Fix wrong display of amounts >= 2^87

* Add test to check that amounts >= 2^87 make the app throw

* Bump v1.9.7 and update changelog
2021-10-04 11:26:01 +02:00
Jean P
fa355a5d97 Add a UI warning when contract data are not enabled in the settings (#193)
* Add a UI warning when contract data are not enabled in the settings

* Update wording "contract data" -> "blind signing" to raise awareness

* Bump version 1.9.5

* remove hardcoded path in helper build script

* Add blind signature test

* Add snapshot-tmp to gitignore

* Remove unused snapshots

* Increase tests timings

* Remove unused snapshots

* Fix and rename compound blind deposit test

* Update Approve and Transfer tests

* Update tests

* Cosmetic changes + disable debug flag

* Update CHANGELOG.md
2021-09-28 12:32:06 +02:00