Commit Graph

147 Commits

Author SHA1 Message Date
apaillier-ledger
fcc3dd6d31 Add support for ERC-721 and ERC-1155 (v3) (#218)
* First draft for erc721 token allowance

* Split ui and provide parameters into their own files

* Print txtype when not supported

* fix compilation for erc721

* Use pluginType

* Add debug statement in compound plugin

* add debug error msg in plugin error

* Add parameter parsing for all methods

* Remove debug logs

* Add SET_APPROVAL_FOR_ALL; Add correct parsing method on contract init

* Add dst_size parameter to copy functions

* Add query contract id code

* format

* Add UIs

* update ethapp.asc

* Change setExternalPlugin to setPlugin; Add support for ERC721

* clang-format

* Fix typo Unconsistent -> Inconsistent

* Add support for 721; use extraInfo

* Add extraInfo to ethpluginQueryConractUI

* Rename extraInfo to item

* Add txFromEtherscan to tests

* Add nft key and temp padding

* Remove comments around HAVE_BYPASS_SIGNATURES

* Rename TESTING_KEY to NFT_TESTING_KEY

* Add comments regarding value of queryContractUI->item

* Fix comment regarding method selector

* Rename provideToken to provideInfo; Update plugin doc

* fix caps of eth_plugin_prepare_provide_info

* fix caps of handle_provide_info

* Use verificationFn insead of hardcoded cx_ecdsa_verify

* Add comments about nftInfo_t and tokenDefinition_t

* Add erc721 test

* Remove comment from plugin interface version

* Fix network_ticker duplicate

* Add setPlugin and provideNFTInfo to doc.asc

* Add back setExternalPlugin; implement new setPlugin

* Update plugin sdk

* Call setPlugin instead of setExternalPlugin

* setPlugin work without checking sig

* Remove printf of displayed fees

* Add working 721 test

* Finalize ERC721 and add simple test

* Display NFT address on set approval and operator

* Support set approval for all for erc721

* Finish UI for set approval for all erc721

* Move copy_parameter and copy_address to eth_plugin_internal; Add tests for erc721

* update plugin sdk

* Add erc1155 plugin and 1155 tests placeholder

* Add restriction for AWS key and setPlugin

* Add NOT_OLD_INTERNAL variant; Add erc_1155_plugin_call

* Fixed compilation warnings (function pointer casting)

Co-authored-by: pscott <scott.piriou@ledger.fr>
2021-11-22 14:39:36 +01:00
apaillier-ledger
a490532605 Fix compilation warnings (#216)
* Fix deprecated os_memmove warning

Switched to the standard memmove function

* Fix get_network_ticker implicit declaration warning

Included the required missing header file

* Removed useless execution rights from Makefile

* Fix directory name in README
2021-11-22 10:56:27 +01:00
Edouard Merle
a6a92cafe0 apply clang format
Signed-off-by: Edouard Merle <edouard.merle@ledger.fr>
2021-11-17 10:45:37 +01:00
Salvatore Ingala
29024c0c8b Avoid signed division
Signed-off-by: Edouard Merle <edouard.merle@ledger.fr>
2021-11-17 10:45:35 +01:00
TamtamHero
a7b2402bdb Apply clang-format-10 2021-11-17 09:50:28 +01:00
TamtamHero
6bad1c4b05 Fix stark order signatures on LNX 2021-11-17 09:50:03 +01:00
Jean P
3a47291fb1 Add Polygon as a variant (#207) 2021-10-28 18:17:05 +02:00
Jean P
3eeec97efa Share network ticker with plugins (#205)
* Add network ticker to queryContractUI for plugins use

* Update sdk deps

* Bump version 1.9.11

* Fix blockSize error when bytes is optimized by EVM

Co-authored-by: pscott <scott.piriou@ledger.fr>
2021-10-28 18:10:21 +02:00
estienne.antoine@gmail.com
50a1536045 sync with master 2021-10-08 12:18:21 +02:00
Jean P
2e5b675cd3 Revert "Revert "blind sign" wording (#203)" (#204)
This reverts commit 53599fb81c.
2021-10-08 10:29:12 +02:00
Neozaru
6ac7be1277 feat: goerli build (#202)
* feat: goerli build

* Apply clang-format-10

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
2021-10-06 14:13:33 +02:00
Jean P
53599fb81c Revert "blind sign" wording (#203)
* Rollback wording changes of contract data to blind signing

* Update tests
2021-10-06 12:02:46 +02:00
estienne.antoine@gmail.com
84a6d18510 Merge remote-tracking branch 'ledgertech/master' into jlm-copy-for-moonriver 2021-10-04 18:57:47 +02:00
estienne.antoine@gmail.com
7bbdb24be4 add moonrriver 2021-10-04 18:55:46 +02:00
Jean P
408805f751 Fix big amounts (#199)
* Fix wrong display of amounts >= 2^87

* Add test to check that amounts >= 2^87 make the app throw

* Bump v1.9.7 and update changelog
2021-10-04 11:26:01 +02:00
Jean P
fb7204fb6c Fix fees overwrite in starkware plugin (#198)
* increase display buffer size to handle Starkware master key and control size when using snprintf

* Bump version 1.9.6

* Fix broken tests

* Add first starkware tests

* Add some constants for starkware

* Update CHANGELOG.md
2021-09-29 18:39:10 +02:00
Jean P
fa355a5d97 Add a UI warning when contract data are not enabled in the settings (#193)
* Add a UI warning when contract data are not enabled in the settings

* Update wording "contract data" -> "blind signing" to raise awareness

* Bump version 1.9.5

* remove hardcoded path in helper build script

* Add blind signature test

* Add snapshot-tmp to gitignore

* Remove unused snapshots

* Increase tests timings

* Remove unused snapshots

* Fix and rename compound blind deposit test

* Update Approve and Transfer tests

* Update tests

* Cosmetic changes + disable debug flag

* Update CHANGELOG.md
2021-09-28 12:32:06 +02:00
pscott
b67d6d65b8 Remove tokens from ethereum app; Add comments about tokens 2021-09-14 10:48:23 +02:00
pscott
ae28843c6c Merge branch 'TowoLabs-master' into bigger_chainid 2021-09-03 15:02:30 +02:00
pscott
fd48a2c1a2 Remove theta, flare and flare_coston 2021-09-03 14:55:28 +02:00
TamtamHero
7ddd32f83d Improve plugin SDK version management 2021-08-31 19:31:56 +02:00
TamtamHero
0d45d2e2d0 Update some prototypes to use chainId value instead of chainConfig structure 2021-08-30 11:02:55 +02:00
pscott
89eba39c63 Remove some warnings when using Eth app as lib 2021-08-27 12:13:47 +02:00
pscott
ef91934b23 Update NETWORK_STRING_MAX_SIZE 2021-08-26 13:21:10 +02:00
pscott
b2172e4627 Use uint64_t for chainID 2021-08-26 13:02:07 +02:00
pscott
54572a95f6 Fix missing ui_plugin.h; add constants to eth_plugin_internals; update plugin sdk 2021-08-18 16:42:30 +02:00
pscott
de5830b494 Merge branch 'master' into remove_v_check 2021-08-11 11:20:23 +02:00
pscott
c5fb10dd47 Remove check for v length 2021-08-06 15:20:58 +02:00
TamtamHero
48c6536d93 Fix theta tokens 2021-08-06 12:34:26 +02:00
Markus Alvila
779fae6058 Add support for Songbird (SGB) 2021-08-05 19:27:53 +02:00
pscott
24541034c6 Merge branch 'master' into support_eip1559 2021-08-03 12:01:58 +02:00
pscott
ee4a865144 Use strlcpy instead of strncpy 2021-07-27 12:24:05 +02:00
pscott
b7110eafe0 update plugin sdk 2021-07-27 12:11:56 +02:00
Jean-Baptiste Bédrune
cd78581ffd Fix all the defects identified by Clang Static Analyzer
Some fixes are dirty, but it is a start to enforce scan-build on
every commit.

Signed-off-by: pscott <scott.piriou@ledger.fr>
2021-07-27 12:09:22 +02:00
Jean-Baptiste Bédrune
c27d59d792 Fix last compilation warnings
Signed-off-by: pscott <scott.piriou@ledger.fr>
2021-07-27 12:09:22 +02:00
pscott
9f49dc0768 Merge remote-tracking branch 'origin' into bsc 2021-07-27 11:14:12 +02:00
pscott
d541f1f524 Add pointer to msg_sender in Eth_plugin_finalize (#170)
* Add some PRINTF debug statements and fir additional screens init

* Memzero struture and use two pointers less

* Clang-format

* Use ADDRESS_LENGTH where possible; Add printf statements when failing to compare contracts

* clang-format

* Remove 'token1' and 'token2' locals

* Fix typo

* apply clang-format

* Add bip32path to sharedRO for plugins

* Change getEthAddressStringFromKey to accept char instead of uint8_t

* Update ethereum plugin sdk

* Add BYPASS_SIGNATURES compilation option

* Remove bip32path and pathLength from sharedRO; add msg_sender pointer to pluginFinalize.address

* clang format eth_plugin_interface

* Update submodule

* Set address BEFORE making the finalize call

* Update SDK

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
2021-07-09 11:46:36 +02:00
Edouard Merle
de6e226dc6 not always define seed cookie path 2021-07-06 11:47:38 +02:00
pscott
b646cf1b28 Fix compilation warnings (#159)
* Fix easy warnings for sdk 2.0

* Add attribute unused to bagl_elemt_t in callback functions

* Add attribute unused to io_event function

* Clang-format

* Use elfs from CI in tests (#167)

* Add Nano X build

* Use CI's build artifacts for CI's tests

* Add network display (#152)

* Add network name display instead of chainID

* Add display of correct ticker along with network

* Add FTM

* Clang-format

* Add comment in python script

* Rename SIZE_MAX to MAX_SIZE

* Change %u to %d in printf

* Remove needless PIC

* Update comment about get_chain_id()

* Update example script to follow EIP155

* Remove unused PIC calls

* Add whitespace between ticker and amount when using EIP155

* Remove decimal config per network, set back 18 everywhere

* Adapt u32_from_BE to swith cases

* Remove chainid from signTx.py

* Switch to switch in stead of if in get_chain_id

* Revert "Remove chainid from signTx.py"

This reverts commit 454e09f280ec3e3ec1c7d7cc0027247ef4390088.

* Change Ethereum chainid to 1

* Rename chainid_step to network_step

* Adapt finalizeParsing to new chainid for Ethereum

* Update snapshots

* clang-format

* Fix network display logic for clones

* Fix tests

* Add clone tests

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>

Co-authored-by: Jean P <10632523+TamtamHero@users.noreply.github.com>
2021-07-05 11:01:51 +02:00
pscott
a2d9a8068a Add network display (#152)
* Add network name display instead of chainID

* Add display of correct ticker along with network

* Add FTM

* Clang-format

* Add comment in python script

* Rename SIZE_MAX to MAX_SIZE

* Change %u to %d in printf

* Remove needless PIC

* Update comment about get_chain_id()

* Update example script to follow EIP155

* Remove unused PIC calls

* Add whitespace between ticker and amount when using EIP155

* Remove decimal config per network, set back 18 everywhere

* Adapt u32_from_BE to swith cases

* Remove chainid from signTx.py

* Switch to switch in stead of if in get_chain_id

* Revert "Remove chainid from signTx.py"

This reverts commit 454e09f280ec3e3ec1c7d7cc0027247ef4390088.

* Change Ethereum chainid to 1

* Rename chainid_step to network_step

* Adapt finalizeParsing to new chainid for Ethereum

* Update snapshots

* clang-format

* Fix network display logic for clones

* Fix tests

* Add clone tests

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
2021-07-02 18:46:23 +02:00
pscott
61e7d17442 Add bsc variant 2021-06-29 17:18:15 +02:00
pscott
0294c5e60f Remove detailed fees display 2021-06-29 16:04:38 +02:00
pscott
a944387c11 change wording to available instead of possible 2021-06-29 16:04:38 +02:00
pscott
036091bb63 Unify plugin ui with standard UI; add prepareFeeDisplay and prepareChainIdDisplay 2021-06-29 16:04:38 +02:00
pscott
27b91e4dea Bump Plugin interface version to v2 2021-06-29 16:04:38 +02:00
pscott
0bff1de52c Add setting to display detailed fees 2021-06-29 16:04:38 +02:00
pscott
9a11d36105 Clang-format main 2021-06-18 12:27:20 +02:00
pscott
0dbb693c59 clang-format 2021-06-08 10:25:15 +02:00
pscott
a61a155d0b Add additionalScreens field 2021-06-08 10:25:15 +02:00
pscott
268ce5d9dd Fix uint256_to_decimal 2021-06-08 10:25:15 +02:00