d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
484 Commits 1 Branch 0 Tags
d541f1f524b9240297d0c2c1cf8b02c4d6b2058c
Commit Graph

72 Commits

Author SHA1 Message Date
pscott
d541f1f524 Add pointer to msg_sender in Eth_plugin_finalize (#170) 
* Add some PRINTF debug statements and fir additional screens init

* Memzero struture and use two pointers less

* Clang-format

* Use ADDRESS_LENGTH where possible; Add printf statements when failing to compare contracts

* clang-format

* Remove 'token1' and 'token2' locals

* Fix typo

* apply clang-format

* Add bip32path to sharedRO for plugins

* Change getEthAddressStringFromKey to accept char instead of uint8_t

* Update ethereum plugin sdk

* Add BYPASS_SIGNATURES compilation option

* Remove bip32path and pathLength from sharedRO; add msg_sender pointer to pluginFinalize.address

* clang format eth_plugin_interface

* Update submodule

* Set address BEFORE making the finalize call

* Update SDK

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
 2021-07-09 11:46:36 +02:00
pscott
b646cf1b28 Fix compilation warnings (#159) 
* Fix easy warnings for sdk 2.0

* Add attribute unused to bagl_elemt_t in callback functions

* Add attribute unused to io_event function

* Clang-format

* Use elfs from CI in tests (#167)

* Add Nano X build

* Use CI's build artifacts for CI's tests

* Add network display (#152)

* Add network name display instead of chainID

* Add display of correct ticker along with network

* Add FTM

* Clang-format

* Add comment in python script

* Rename SIZE_MAX to MAX_SIZE

* Change %u to %d in printf

* Remove needless PIC

* Update comment about get_chain_id()

* Update example script to follow EIP155

* Remove unused PIC calls

* Add whitespace between ticker and amount when using EIP155

* Remove decimal config per network, set back 18 everywhere

* Adapt u32_from_BE to swith cases

* Remove chainid from signTx.py

* Switch to switch in stead of if in get_chain_id

* Revert "Remove chainid from signTx.py"

This reverts commit 454e09f280ec3e3ec1c7d7cc0027247ef4390088.

* Change Ethereum chainid to 1

* Rename chainid_step to network_step

* Adapt finalizeParsing to new chainid for Ethereum

* Update snapshots

* clang-format

* Fix network display logic for clones

* Fix tests

* Add clone tests

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>

Co-authored-by: Jean P <10632523+TamtamHero@users.noreply.github.com>
 2021-07-05 11:01:51 +02:00
pscott
a2d9a8068a Add network display (#152) 
* Add network name display instead of chainID

* Add display of correct ticker along with network

* Add FTM

* Clang-format

* Add comment in python script

* Rename SIZE_MAX to MAX_SIZE

* Change %u to %d in printf

* Remove needless PIC

* Update comment about get_chain_id()

* Update example script to follow EIP155

* Remove unused PIC calls

* Add whitespace between ticker and amount when using EIP155

* Remove decimal config per network, set back 18 everywhere

* Adapt u32_from_BE to swith cases

* Remove chainid from signTx.py

* Switch to switch in stead of if in get_chain_id

* Revert "Remove chainid from signTx.py"

This reverts commit 454e09f280ec3e3ec1c7d7cc0027247ef4390088.

* Change Ethereum chainid to 1

* Rename chainid_step to network_step

* Adapt finalizeParsing to new chainid for Ethereum

* Update snapshots

* clang-format

* Fix network display logic for clones

* Fix tests

* Add clone tests

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
 2021-07-02 18:46:23 +02:00
pscott
0dbb693c59 clang-format 2021-06-08 10:25:15 +02:00
pscott
a61a155d0b Add additionalScreens field 2021-06-08 10:25:15 +02:00
pscott
b651f530be Put externalPluginIsSet as its own global; initialize it at launch 2021-06-08 10:24:51 +02:00
pscott
8592a22542 Clang-format 2021-06-08 10:24:51 +02:00
pscott
3b6fd0d169 Undo testing commit 2021-06-08 10:24:51 +02:00
pscott
632e6b3233 Properly handle return value of eth_plugin_call 2021-06-08 10:24:51 +02:00
pscott
d029e9f635 Print ticker only if it's present 2021-06-08 10:24:51 +02:00
pscott
6b309c2676 Add printf and adapt logic for provideToken 2021-06-08 10:24:51 +02:00
pscott
4780893ac5 Put back os_perso_derive_eip2333 in getEth2PublicKey 2021-06-08 10:24:51 +02:00
TamtamHero
ec1a0d1128 test key + disable bls sigs 2021-06-08 10:24:51 +02:00
TamtamHero
40664a65f1 Fix issues due to base64(contractAddr) removal 2021-06-08 10:24:51 +02:00
pscott
5fd27ff5ca Use INT256_LENGTH and ADDRESS_LENGTH define 2021-06-08 10:24:51 +02:00
TamtamHero
0bd5fa717e Add Ledger signature checking for external plugins 2021-06-08 10:24:51 +02:00
TamtamHero
f096e91690 Add contract address and selector to setExternalPlugin 2021-06-08 10:24:50 +02:00
TamtamHero
b821c0d8a7 Add setExternalPlugin command 2021-06-08 10:24:50 +02:00
pscott
f250865bcb Merge branch 'master' of github.com:LedgerHQ/app-ethereum into fix_security_and_display_issues 2021-05-04 12:14:44 +02:00
pscott
c7ec0c7dfa Use %d flag instead of %u 2021-04-28 11:39:47 +02:00
pscott
ebffb48cd3 Use snprintf instead of u32_to_str 2021-04-28 10:48:18 +02:00
pscott
f893637d71 Clang-format 2021-04-27 10:37:22 +02:00
pscott
a6945c42b2 Fix return values from enums 2021-04-27 10:36:22 +02:00
pscott
6cd4b6e2aa Revamp return results of plugins 2021-04-24 12:14:36 +02:00
pscott
dcacda44c1 Revert changes to seteth2withdrawalindex 2021-04-24 12:04:41 +02:00
pscott
59ce2b6562 Uncomment os_perso_derive 2021-04-24 12:02:47 +02:00
pscott
0af10691eb Verify return value of plugin 2021-04-23 19:15:30 +02:00
pscott
550fc86ba8 Remove INDEX_MAX from withdrawal_index.h ; set limit to 2^19 2021-04-22 14:57:30 +02:00
pscott
a6a196b62d Remove comment of os_perso_derive 2021-04-22 14:29:27 +02:00
pscott
3fd3b2e46d clang-format 2021-04-22 14:05:39 +02:00
pscott
a4dcec436f Clang-format 2021-04-22 14:01:52 +02:00
pscott
6ff2172f1b Add upper bound for withdrawal index 2021-04-22 10:08:05 +02:00
pscott
d5b32af95e Clang format 2021-04-21 17:24:54 +02:00
pscott
11701b6fa2 Remove debugging printf 2021-04-21 17:19:02 +02:00
pscott
1a1a3198f9 Remove debugggin printf 2021-04-21 17:17:21 +02:00
pscott
dafdc404ac Add strict parameter to u32_from_BE 2021-04-21 17:07:16 +02:00
pscott
970f0355dd Add support for EIP2718 (enveloppe) and EIP2930 (acess list tx); Display chain ID when different from 1 (ethereum mainnet) 2021-04-21 16:56:17 +02:00
pscott
5dd99c3d48 Move TxType parsing in cmd_signTx and add 0x6501 error 2021-04-15 17:59:41 +02:00
Jean P
b09ba946d5 Merge pull request #127 from LedgerHQ/fix_warning_1.6 
Fix compilation warnings for 1.6.1-2 and NanoX sdk
 2021-03-25 12:42:12 +01:00
pscott
013538e9fe Apply clang-format 2021-03-25 10:43:59 +01:00
pscott
9a798e3662 Fix warnings for nanox sdk 2021-03-24 16:32:08 +01:00
TamtamHero
a96caadc4f Fix swap issue with nonce update, save a few bytes and improve settings switch feedback 2021-02-12 11:53:41 +01:00
pscott
9874ab4116 Set displayBuffer back to 50 bytes 2021-02-08 13:19:00 +01:00
pscott
1acce7aa4c Update ux_approval_tx_flow naming 2021-02-05 18:03:24 +01:00
pscott
4cbcdc0be0 Apply clang-format 2021-02-05 17:58:21 +01:00
pscott
2518efd3dd Add manual ux_flow; display nonce is now a setting 2021-02-05 17:52:46 +01:00
pscott
b2d5b85a2f Add nonce display settings ; nonce is always displayed 2021-02-05 17:36:54 +01:00
BTChip github
4629d6633c Fix contract details debugging with plugins 2021-01-05 15:31:26 +01:00
TamtamHero
17bd07a346 Apply clang-format 2020-12-01 16:20:13 +01:00
BTChip github
1a311684a2 Replace memset by expilcit_bzero for critical data 2020-11-30 18:22:21 +01:00