From cd7313d04c4f7adc12ee1f7952063feb2c7123cb Mon Sep 17 00:00:00 2001
From: owen05 <liuhongnan53@163.com>
Date: Wed, 31 Mar 2021 14:44:00 +0800
Subject: [PATCH] fix basemine

---
 contracts/DODOToken/DODOMineV2/BaseMine.sol | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/contracts/DODOToken/DODOMineV2/BaseMine.sol b/contracts/DODOToken/DODOMineV2/BaseMine.sol
index 4687527..4155a6b 100644
--- a/contracts/DODOToken/DODOMineV2/BaseMine.sol
+++ b/contracts/DODOToken/DODOMineV2/BaseMine.sol
@@ -61,7 +61,7 @@ contract BaseMine is InitializableOwnable {
             ).add(rt.userRewards[user]);
     }
 
-    function getPendingRewardByToken(address user, address rewardToken) public view returns (uint256) {
+    function getPendingRewardByToken(address user, address rewardToken) external view returns (uint256) {
         return getPendingReward(user, getIdByRewardToken(rewardToken));
     }
 
@@ -73,8 +73,8 @@ contract BaseMine is InitializableOwnable {
         return _balances[user];
     }
 
-    function getRewardTokenById(uint256 i) public view returns (address) {
-        require(i<rewardTokenInfos.length, "DODOMineV2: REWARD_ID_FOUND");
+    function getRewardTokenById(uint256 i) external view returns (address) {
+        require(i<rewardTokenInfos.length, "DODOMineV2: REWARD_ID_NOT_FOUND");
         RewardTokenInfo memory rt = rewardTokenInfos[i];
         return rt.rewardToken;
     }
@@ -86,7 +86,7 @@ contract BaseMine is InitializableOwnable {
                 return i;
             }
         }
-        require(true, "DODOMineV2: TOKEN_NOT_FOUND");
+        require(false, "DODOMineV2: TOKEN_NOT_FOUND");
     }
 
     // ============ Claim ============
@@ -102,7 +102,7 @@ contract BaseMine is InitializableOwnable {
         }
     }
 
-    function claimAllRewards() public {
+    function claimAllRewards() external {
         uint256 len = rewardTokenInfos.length;
         for (uint256 i = 0; i < len; i++) {
             claimReward(i);
@@ -143,7 +143,9 @@ contract BaseMine is InitializableOwnable {
         uint256 len = rewardTokenInfos.length;
         for (uint256 i = 0; i < len; i++) {
             if (rewardToken == rewardTokenInfos[i].rewardToken) {
-                rewardTokenInfos[i] = rewardTokenInfos[len - 1];
+                if(i != len - 1) {
+                    rewardTokenInfos[i] = rewardTokenInfos[len - 1];
+                }
                 rewardTokenInfos.pop();
                 emit RemoveRewardToken(rewardToken);
                 break;