Some checks failed
Deploy to Phoenix / deploy (push) Has been cancelled
- ADD_CHAIN138_TO_LEDGER_LIVE: Ledger form done; public code review repo bis-innovations/LedgerLive; init/push commands - CONTRACT_DEPLOYMENT_RUNBOOK: Chain 138 gas price 1 gwei, 36-addr check, TransactionMirror workaround - CONTRACT_*: AddressMapper, MirrorManager deployed 2026-02-12; 36-address on-chain check - NEXT_STEPS_FOR_YOU: Ledger done; steps completable now (no LAN); run-completable-tasks-from-anywhere - MASTER_INDEX, OPERATOR_OPTIONAL, SMART_CONTRACTS_INVENTORY_SIMPLE: updates - LEDGER_BLOCKCHAIN_INTEGRATION_COMPLETE: bis-innovations/LedgerLive reference Co-authored-by: Cursor <cursoragent@cursor.com>
2.1 KiB
2.1 KiB
Prune and Deduplicate Plan (Before IP Fix Completion)
Last Updated: 2026-01-31
Rationale: Reduce IP fix scope by pruning archived scripts and deduplicating before applying remaining ~481 bare IP fixes.
Current State
| Scope | Script Count | IP References |
|---|---|---|
Archive (scripts/archive/) |
436 | ~1,427 |
| Active (non-archive) | 450 | ~1,088 |
| Total | 886 | ~2,515 |
- Bare IPs (excl. fallbacks): ~481 across all scripts
- Strategy: Fix only active scripts; exclude archive from scope
Phase 1: Scope Down (Prune from IP Fix)
Decision: Exclude scripts/archive/ from IP centralization.
- Archive = historical / superseded scripts; not part of operational runpath
- Fixing 1,427 refs in archive yields little operational value
- Reduces fix scope from ~553 to ~117 scripts with IPs (active only)
Implementation:
- Update
fix-remaining-hardcoded-ips.shto excludescripts/archive - Update
centralize-ip-addresses.shto exclude archive when run in batch mode - Document in
IP_CENTRALIZATION_TRACKING.md
Phase 2: Deduplicate (Identify Overlaps)
Archive Duplicates (already archived; no action)
Examples in scripts/archive/consolidated/:
list-all-vmids-*.sh: 4 variants (complete, final, status, status-simple)configure-persistent-networks*.sh: v1, v2, v3fix-shared-tunnel*.sh,fix-blockscout*.sh: multiple variants
Recommendation: Leave as-is. Archive serves as history; no need to delete.
Active Duplicates (review if any)
- Check for scripts with similar names/purpose in active tree
- Prefer consolidating into single canonical script before IP fix
Phase 3: Complete IP Fix (Active Scripts Only)
After prune:
- Run
fix-remaining-hardcoded-ips.sh(now scoped to active only) - Add remaining high-frequency IPs to
config/ip-addresses.conf - Re-run until bare count in active scripts is minimal
Execution Order
- ✅ Update fix script to exclude archive
- Run fix script (active-only scope)
- Update tracking docs with new counts