7cd7022f6e
- Added lock file exclusions for pnpm in .gitignore. - Removed obsolete package-lock.json from the api and portal directories. - Enhanced Cloudflare adapter with additional interfaces for zones and tunnels. - Improved Proxmox adapter error handling and logging for API requests. - Updated Proxmox VM parameters with validation rules in the API schema. - Enhanced documentation for Proxmox VM specifications and examples.
117 lines
2.8 KiB
Markdown
117 lines
2.8 KiB
Markdown
# Pre-existing Issues Fixed
|
|
|
|
**Date**: 2025-12-12
|
|
**Status**: ✅ All Pre-existing Issues Fixed
|
|
|
|
---
|
|
|
|
## Summary
|
|
|
|
All pre-existing compilation and vet issues have been fixed. The codebase now compiles cleanly without warnings.
|
|
|
|
---
|
|
|
|
## Issues Fixed
|
|
|
|
### 1. `pkg/scaling/policy.go`
|
|
|
|
**Issue**: Unused import and unused variable
|
|
- Unused import: `"github.com/pkg/errors"`
|
|
- Unused variable: `desiredReplicas` on line 39
|
|
|
|
**Fix**:
|
|
- Removed unused import
|
|
- Removed unused `desiredReplicas` variable (it was assigned but never used)
|
|
|
|
**Status**: ✅ Fixed
|
|
|
|
---
|
|
|
|
### 2. `pkg/gpu/manager.go`
|
|
|
|
**Issue**: Unused variable `utilStr` on line 145
|
|
|
|
**Fix**:
|
|
- Changed to `_ = strings.TrimSpace(parts[0])` with comment indicating it's reserved for future use
|
|
|
|
**Status**: ✅ Fixed
|
|
|
|
---
|
|
|
|
### 3. `pkg/controller/virtualmachine/controller_test.go`
|
|
|
|
**Issue**: Outdated API references
|
|
- Line 41: `ProviderConfigReference` should be a pointer `*ProviderConfigReference`
|
|
- Lines 91-92: `ProviderCredentials` and `CredentialsSourceSecret` don't exist in current API
|
|
|
|
**Fix**:
|
|
- Changed `ProviderConfigReference` to `&ProviderConfigReference` (pointer)
|
|
- Updated to use `CredentialsSource` with proper `SecretRef` structure
|
|
|
|
**Status**: ✅ Fixed
|
|
|
|
---
|
|
|
|
### 4. `pkg/controller/resourcediscovery/controller.go`
|
|
|
|
**Issue**: References non-existent `providerConfig.Spec.Endpoint` field
|
|
- The `ProviderConfigSpec` doesn't have an `Endpoint` field
|
|
- It has `Sites []ProxmoxSite` instead
|
|
|
|
**Fix**:
|
|
- Updated to find endpoint from `providerConfig.Spec.Sites` array
|
|
- Matches site by `rd.Spec.Site` name
|
|
- Falls back to first site if no site specified
|
|
- Also handles `InsecureSkipTLSVerify` from site configuration
|
|
- Fixed return value to return `[]discovery.DiscoveredResource{}` instead of `nil` on errors
|
|
|
|
**Status**: ✅ Fixed
|
|
|
|
---
|
|
|
|
## Verification
|
|
|
|
All fixes have been verified:
|
|
|
|
```bash
|
|
# Build successful
|
|
docker build --target builder -t crossplane-provider-proxmox:builder .
|
|
|
|
# All packages compile
|
|
go build ./pkg/scaling/...
|
|
go build ./pkg/gpu/...
|
|
go build ./pkg/controller/resourcediscovery/...
|
|
go build ./pkg/controller/virtualmachine/...
|
|
```
|
|
|
|
---
|
|
|
|
## Files Modified
|
|
|
|
1. `crossplane-provider-proxmox/pkg/scaling/policy.go`
|
|
2. `crossplane-provider-proxmox/pkg/gpu/manager.go`
|
|
3. `crossplane-provider-proxmox/pkg/controller/virtualmachine/controller_test.go`
|
|
4. `crossplane-provider-proxmox/pkg/controller/resourcediscovery/controller.go`
|
|
|
|
---
|
|
|
|
## Impact
|
|
|
|
- **No Breaking Changes**: All fixes are internal improvements
|
|
- **Better Code Quality**: Removed unused code and fixed API references
|
|
- **Improved Maintainability**: Code now follows current API structure
|
|
- **Clean Builds**: No more vet warnings or compilation errors
|
|
|
|
---
|
|
|
|
## Next Steps
|
|
|
|
1. ✅ All pre-existing issues fixed
|
|
2. ✅ Code compiles cleanly
|
|
3. ✅ Ready for deployment
|
|
|
|
---
|
|
|
|
*Last Updated: 2025-12-12*
|
|
|