Fix impl APDU wrongly returning 0x6a80

src_features/signMessageEIP712/entrypoint.c

@@ -396,7 +396,7 @@ bool    handle_eip712_struct_def(const uint8_t *const apdu_buf)
 
 bool    handle_eip712_struct_impl(const uint8_t *const apdu_buf)
 {
-    bool ret;
+    bool ret = true;
 
     switch (apdu_buf[OFFSET_P2])
     {

src_features/signMessageEIP712/field_hash.c

@@ -21,9 +21,9 @@ bool field_hash_init(void)
     return true;
 }
 
-const uint8_t *field_hash(const uint8_t *data,
-                          uint8_t data_length,
-                          bool partial)
+bool    field_hash(const uint8_t *data,
+                   uint8_t data_length,
+                   bool partial)
 {
     const void *field_ptr;
     e_type field_type;
@@ -39,12 +39,12 @@ const uint8_t *field_hash(const uint8_t *data,
     (void)data;
     if (fh == NULL)
     {
-        return NULL;
+        return false;
     }
     // get field by path
     if ((field_ptr = path_get_field()) == NULL)
     {
-        return NULL;
+        return false;
     }
     field_type = struct_field_type(field_ptr);
     if (fh->state == FHS_IDLE) // first packet for this frame
@@ -73,7 +73,7 @@ const uint8_t *field_hash(const uint8_t *data,
     {
         if (partial) // only makes sense if marked as complete
         {
-            return NULL;
+            return false;
         }
 #ifdef DEBUG
         PRINTF("=> ");
@@ -105,19 +105,19 @@ const uint8_t *field_hash(const uint8_t *data,
                 case TYPE_CUSTOM:
                 default:
                     PRINTF("Unknown solidity type!\n");
-                    return NULL;
+                    return false;
             }
 
             if (value == NULL)
             {
-                return NULL;
+                return false;
             }
         }
         else
         {
             if ((value = mem_alloc(KECCAK256_HASH_BYTESIZE)) == NULL)
             {
-                return NULL;
+                return false;
             }
             // copy hash into memory
             cx_hash((cx_hash_t*)&global_sha3,
@@ -152,9 +152,9 @@ const uint8_t *field_hash(const uint8_t *data,
     {
         if (!partial || !IS_DYN(field_type)) // only makes sense if marked as partial
         {
-            return NULL;
+            return false;
         }
     }
 
-    return value;
+    return true;
 }

src_features/signMessageEIP712/field_hash.h

@@ -19,7 +19,7 @@ typedef struct
 }   s_field_hashing;
 
 bool field_hash_init(void);
-const uint8_t *field_hash(const uint8_t *data,
-                          uint8_t data_length,
-                          bool partial);
+bool field_hash(const uint8_t *data,
+                uint8_t data_length,
+                bool partial);
 #endif // FIELD_HASH_H_