d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove debug prints; secure copy of chainid into v

Browse Source
This commit is contained in:
pscott
2021-08-06 21:07:22 +02:00
parent 3a4f477b1d
commit c8bad8b2f8
2 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src_common/ethUstream.c
View File

@@ -254,10 +254,6 @@ static void processTo(txContext_t *context) {
}
static void processData(txContext_t *context) {
PRINTF("DATA len: %d, DATA: %.*H\n",
context->currentFieldLength,
context->currentFieldLength,
context->workBuffer);
if (context->currentFieldIsList) {
PRINTF("Invalid type for RLP_DATA\n");
THROW(EXCEPTION);
@@ -278,7 +274,6 @@ static void processData(txContext_t *context) {
}
static void processAndDiscard(txContext_t *context) {
PRINTF("DISCARDING: %.*H\n", context->currentFieldLength, context->workBuffer);
if (context->currentFieldIsList) {
PRINTF("Invalid type for Discarded field\n");
THROW(EXCEPTION);
@@ -295,10 +290,6 @@ static void processAndDiscard(txContext_t *context) {
}
static void processV(txContext_t *context) {
PRINTF("current Length: %d\tBuff: %.*H\n",
context->currentFieldLength,
context->currentFieldLength,
context->workBuffer);
if (context->currentFieldIsList) {
PRINTF("Invalid type for RLP_V\n");
THROW(EXCEPTION);
@@ -306,6 +297,8 @@ static void processV(txContext_t *context) {
if (context->currentFieldPos < context->currentFieldLength) {
uint32_t copySize =
MIN(context->commandLength, context->currentFieldLength - context->currentFieldPos);
// Make sure we do not copy more than the size of v.
copySize = MIN(copySize, sizeof(context->content->v));
copyTxData(context, context->content->v + context->currentFieldPos, copySize);
}
if (context->currentFieldPos == context->currentFieldLength) {

2
src_features/signTx/ui_common_signTx.c
View File

@@ -27,8 +27,6 @@ unsigned int io_seproxyhal_touch_tx_ok(__attribute__((unused)) const bagl_elemen
sizeof(signature),
&info);
explicit_bzero(&privateKey, sizeof(privateKey));
PRINTF("v: %.*H\n", tmpContent.txContent.vLength, tmpContent.txContent.v);
PRINTF("u32 v: %.*H\n", sizeof(v), &v);
if (txContext.txType == EIP1559 || txContext.txType == EIP2930) {
if (info & CX_ECCINFO_PARITY_ODD) {
G_io_apdu_buffer[0] = 1;