Commit Graph

1053 Commits

Author SHA1 Message Date
Alexandre Paillier
ab67ae1cb3 Merge remote-tracking branch 'origin/develop' into HEAD 2022-09-14 17:27:25 +02:00
tjulien-ledger
a0d16023d5 Light integration (#334)
* adding XDC

* adding meter

* adding multivac

* adding id4good

* adding tecracoin

* minor typo

* adding apothem

* adding apothem 2

* apothem and tecratestnet on network.c

* fix nettwork.c

* 1st additions

* last additions

* adding fix from develop

* update apothem coin name

* removing id4good

* adding Cronos
2022-09-14 10:50:57 +02:00
Alexandre Paillier
a27826dcf6 Fix EIP712 type_hash function description 2022-09-14 09:41:39 +02:00
Alexandre Paillier
ed479128fd EIP712 Filtering count checking 2022-09-14 09:41:39 +02:00
Alexandre Paillier
93b0bb08f7 Better handling of missing EIP721 error codes + add a missing one for EIP712 filtering signature checking 2022-09-14 09:41:38 +02:00
Alexandre Paillier
3f02bf672c Updated linter to clang-format 12.0.1 2022-09-14 09:41:38 +02:00
Alexandre Paillier
9e4df4b655 Updated EIP712 filtering signature specs to start with a magic number
Making it impossible for a signature of one type to be valid as another
2022-09-14 09:41:38 +02:00
Alexandre Paillier
3ee1fa419a Now supports EIP-712 filtering with missing chain id & contract address 2022-09-14 09:41:37 +02:00
Alexandre Paillier
089de9e28f EIP712 tests - Renamed -test.json files into -data.json 2022-09-14 09:41:37 +02:00
Alexandre Paillier
fd93495096 CI - Add ragger tests 2022-09-14 09:41:31 +02:00
Alexandre Paillier
78172cdd61 CI - Changed build workflow to compile release applications instead; remove the artifacts upload since they were not used 2022-09-13 18:20:19 +02:00
apaillier-ledger
829a694b78 Merge pull request #340 from LedgerHQ/revert-319-purge/compound_plugin
Revert "[clean] Removing compound-related plugin code"
2022-09-12 15:12:23 +02:00
apaillier-ledger
95a0c8896b Revert "[clean] Removing compound-related plugin code" 2022-09-12 14:42:57 +02:00
Alexandre Paillier
3e89610499 Ragger tests now take CLI arguments for device model and elfs location 2022-08-31 18:09:48 +02:00
Alexandre Paillier
770bd9c39d Replaced the signature key used for EIP712 tests by the CAL testing one 2022-08-31 18:09:38 +02:00
apaillier-ledger
384c16c3d0 Merge pull request #338 from LedgerHQ/eth-ux-split
eth: split ux from rest of source
2022-08-24 17:32:47 +02:00
Clement Bouvet
89eeaa7b7d eth: split ux from rest of source 2022-08-24 10:35:16 +02:00
Alexandre Paillier
ed7b6541c0 EIP712 - Extra fixes from security review 2022-08-10 16:19:52 +02:00
Alexandre Paillier
98889e2642 Moved EIP712 filtering argument switch from P1 to P2, more in line with other EIP712 APDUs 2022-08-10 15:19:10 +02:00
Alexandre Paillier
f278221537 Add two new EIP712 filters 2022-08-09 17:49:47 +02:00
Alexandre Paillier
3c321a04ea Split ragger ethereum client into multiple smaller files 2022-08-09 17:49:05 +02:00
Alexandre Paillier
c6ae3480a7 Updated ragger requirements file 2022-08-09 14:07:37 +02:00
Alexandre Paillier
af277c9c40 Removed dead code in EIP712 JSON handling python test code 2022-08-09 14:07:37 +02:00
Alexandre Paillier
e8f58bdce7 Ragger tests now have EIP721 filtering 2022-08-09 14:07:36 +02:00
Alexandre Paillier
0d38bea388 Ragger tests - Refactored the handling of the app settings 2022-08-09 14:07:36 +02:00
Alexandre Paillier
5e9b426b3e EIP-712 tests now have reference response signatures they can check against 2022-08-09 14:07:36 +02:00
Alexandre Paillier
ca04b5e213 Now properly handles UI clicks in EIP712 automated tests 2022-08-09 14:07:35 +02:00
Alexandre Paillier
341b7c2adf Modified all the nominal eip712 test input files 2022-08-09 14:07:35 +02:00
Alexandre Paillier
243f33bbb7 Fix initial state of buffer in BIP32 formatting function 2022-08-09 14:07:35 +02:00
Alexandre Paillier
311c266084 Fixes problem with field values too long for one APDU 2022-08-09 14:07:34 +02:00
Alexandre Paillier
fe13260140 EIP712 feeder script ragger support 2022-08-09 14:07:34 +02:00
Alexandre Paillier
ef7f2e128a Ragger tests now target all devices 2022-08-09 14:07:33 +02:00
Alexandre Paillier
aef491fdee Added a ragger ethereum client with EIP712 support 2022-08-09 14:07:33 +02:00
Alexandre Paillier
6758453dfa Merge remote-tracking branch 'origin/develop' into apr/feature/eip712 2022-08-09 14:05:14 +02:00
Jorge Martins
7c831dd067 Merge pull request #336 from jmartins-ledger/bug-fix
Fix feesToString buffer overflow
2022-08-09 12:35:50 +02:00
Jorge Martins
d384007912 Fix feesToString buffer overflow 2022-08-09 11:30:43 +02:00
Alexandre Paillier
3e3dade0b4 Security review code linting 2022-08-08 13:55:45 +02:00
Jorge Martins
b2ec3eff0a Security review (#331)
* Fix some issues

* add typed_data.c changes

* Make attribution after the check
2022-08-08 13:53:41 +02:00
Alexandre Paillier
ff68de5bb7 Fix compound tests 2022-08-05 18:39:56 +02:00
Alexandre Paillier
de9e895ad9 EIP-712 code linting 2022-08-05 18:15:59 +02:00
Alexandre Paillier
0cf21cdf73 Better EIP-712 array error-handling on APDU parsing 2022-08-05 18:15:58 +02:00
Alexandre Paillier
5e5b3c3621 EIP712 STRUCT FIELD IMPL now checks the APDU payload bounds 2022-08-05 18:15:58 +02:00
Alexandre Paillier
38f199e46b Now only writes to EIP-712 UI buffers data that should be show
Prevents the case if the last field of a message is supposed to be hidden and after reaching the Approve/Reject screens the user goes back to see the last field, he would see the actual last field that should be hidden instead of the last one he saw beforehand.
2022-08-05 18:15:57 +02:00
Alexandre Paillier
b4fe42cd78 EIP712 STRUCT FIELD DEF now checks the APDU payload bounds 2022-08-05 18:15:57 +02:00
Alexandre Paillier
0cc75edf69 EIP712 code Doxygen comments pass 2022-08-05 18:15:57 +02:00
Alexandre Paillier
0cfb16759c Add missing APDU return code 2022-08-05 18:15:56 +02:00
Alexandre Paillier
fcc375a9aa Small refactoring to EIP712 typed data functions 2022-08-05 18:15:56 +02:00
Alexandre Paillier
1eaba306e1 Add missing information to EIP712 send struct def APDU in doc 2022-08-05 18:15:55 +02:00
Alexandre Paillier
cfb45a795b Better EIP712 field implementation error handling, including hidden ones 2022-08-05 18:15:55 +02:00
Alexandre Paillier
58d1b40c79 UI 712 logic refactoring 2022-08-05 18:15:55 +02:00