d-bis/app-ethereum
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
606 Commits 1 Branch 0 Tags
fb7204fb6cc136e3218cf52c6402ffb231ca2c11
Commit Graph

101 Commits

Author SHA1 Message Date
Jean P
fa355a5d97 Add a UI warning when contract data are not enabled in the settings (#193) 
* Add a UI warning when contract data are not enabled in the settings

* Update wording "contract data" -> "blind signing" to raise awareness

* Bump version 1.9.5

* remove hardcoded path in helper build script

* Add blind signature test

* Add snapshot-tmp to gitignore

* Remove unused snapshots

* Increase tests timings

* Remove unused snapshots

* Fix and rename compound blind deposit test

* Update Approve and Transfer tests

* Update tests

* Cosmetic changes + disable debug flag

* Update CHANGELOG.md
 2021-09-28 12:32:06 +02:00
TamtamHero
0d45d2e2d0 Update some prototypes to use chainId value instead of chainConfig structure 2021-08-30 11:02:55 +02:00
TamtamHero
3e25f04d05 Refactoring helper to get printable eth address from hex 2021-08-30 11:00:51 +02:00
pscott
dda1e20fb3 Fix V computing when using < 4 bytes chain IDs 2021-08-27 18:35:53 +02:00
pscott
847db91cfb Remove debugging statements 2021-08-27 17:28:24 +02:00
pscott
f2ff741767 Increase size of V 2021-08-27 14:47:59 +02:00
pscott
94363738fe Move u64_to_string 2021-08-26 13:59:42 +02:00
pscott
b2172e4627 Use uint64_t for chainID 2021-08-26 13:02:07 +02:00
pscott
54572a95f6 Fix missing ui_plugin.h; add constants to eth_plugin_internals; update plugin sdk 2021-08-18 16:42:30 +02:00
pscott
c8bad8b2f8 Remove debug prints; secure copy of chainid into v 2021-08-06 21:07:22 +02:00
pscott
9d2c07d648 remove double get_chainID fn 2021-08-06 16:46:03 +02:00
pscott
c5fb10dd47 Remove check for v length 2021-08-06 15:20:58 +02:00
pscott
d04dcd8dc6 Add printf for txtype; Fix txtype init 2021-08-04 17:42:09 +02:00
pscott
24541034c6 Merge branch 'master' into support_eip1559 2021-08-03 12:01:58 +02:00
pscott
06075c9586 Sign txType byte 2021-07-31 14:21:10 +02:00
pscott
d0a540f683 Fix y_parity signature for eip1559 and eip2930 2021-07-31 13:33:45 +02:00
pscott
ee4a865144 Use strlcpy instead of strncpy 2021-07-27 12:24:05 +02:00
pscott
b7110eafe0 update plugin sdk 2021-07-27 12:11:56 +02:00
Jean-Baptiste Bédrune
cd78581ffd Fix all the defects identified by Clang Static Analyzer 
Some fixes are dirty, but it is a start to enforce scan-build on
every commit.

Signed-off-by: pscott <scott.piriou@ledger.fr>
 2021-07-27 12:09:22 +02:00
Jean-Baptiste Bédrune
c27d59d792 Fix last compilation warnings 
Signed-off-by: pscott <scott.piriou@ledger.fr>
 2021-07-27 12:09:22 +02:00
pscott
9f49dc0768 Merge remote-tracking branch 'origin' into bsc 2021-07-27 11:14:12 +02:00
TamtamHero
e336a7c153 Repair provideERC20TokenInformation for side chains when using eth app 2021-07-15 12:00:11 +02:00
pscott
d541f1f524 Add pointer to msg_sender in Eth_plugin_finalize (#170) 
* Add some PRINTF debug statements and fir additional screens init

* Memzero struture and use two pointers less

* Clang-format

* Use ADDRESS_LENGTH where possible; Add printf statements when failing to compare contracts

* clang-format

* Remove 'token1' and 'token2' locals

* Fix typo

* apply clang-format

* Add bip32path to sharedRO for plugins

* Change getEthAddressStringFromKey to accept char instead of uint8_t

* Update ethereum plugin sdk

* Add BYPASS_SIGNATURES compilation option

* Remove bip32path and pathLength from sharedRO; add msg_sender pointer to pluginFinalize.address

* clang format eth_plugin_interface

* Update submodule

* Set address BEFORE making the finalize call

* Update SDK

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
 2021-07-09 11:46:36 +02:00
pscott
b646cf1b28 Fix compilation warnings (#159) 
* Fix easy warnings for sdk 2.0

* Add attribute unused to bagl_elemt_t in callback functions

* Add attribute unused to io_event function

* Clang-format

* Use elfs from CI in tests (#167)

* Add Nano X build

* Use CI's build artifacts for CI's tests

* Add network display (#152)

* Add network name display instead of chainID

* Add display of correct ticker along with network

* Add FTM

* Clang-format

* Add comment in python script

* Rename SIZE_MAX to MAX_SIZE

* Change %u to %d in printf

* Remove needless PIC

* Update comment about get_chain_id()

* Update example script to follow EIP155

* Remove unused PIC calls

* Add whitespace between ticker and amount when using EIP155

* Remove decimal config per network, set back 18 everywhere

* Adapt u32_from_BE to swith cases

* Remove chainid from signTx.py

* Switch to switch in stead of if in get_chain_id

* Revert "Remove chainid from signTx.py"

This reverts commit 454e09f280ec3e3ec1c7d7cc0027247ef4390088.

* Change Ethereum chainid to 1

* Rename chainid_step to network_step

* Adapt finalizeParsing to new chainid for Ethereum

* Update snapshots

* clang-format

* Fix network display logic for clones

* Fix tests

* Add clone tests

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>

Co-authored-by: Jean P <10632523+TamtamHero@users.noreply.github.com>
 2021-07-05 11:01:51 +02:00
pscott
a2d9a8068a Add network display (#152) 
* Add network name display instead of chainID

* Add display of correct ticker along with network

* Add FTM

* Clang-format

* Add comment in python script

* Rename SIZE_MAX to MAX_SIZE

* Change %u to %d in printf

* Remove needless PIC

* Update comment about get_chain_id()

* Update example script to follow EIP155

* Remove unused PIC calls

* Add whitespace between ticker and amount when using EIP155

* Remove decimal config per network, set back 18 everywhere

* Adapt u32_from_BE to swith cases

* Remove chainid from signTx.py

* Switch to switch in stead of if in get_chain_id

* Revert "Remove chainid from signTx.py"

This reverts commit 454e09f280ec3e3ec1c7d7cc0027247ef4390088.

* Change Ethereum chainid to 1

* Rename chainid_step to network_step

* Adapt finalizeParsing to new chainid for Ethereum

* Update snapshots

* clang-format

* Fix network display logic for clones

* Fix tests

* Add clone tests

Co-authored-by: TamtamHero <10632523+TamtamHero@users.noreply.github.com>
 2021-07-02 18:46:23 +02:00
pscott
032bd7b7ee clang format 2021-06-29 16:07:28 +02:00
pscott
0294c5e60f Remove detailed fees display 2021-06-29 16:04:38 +02:00
pscott
638c124739 Add comment 2021-06-29 16:04:38 +02:00
pscott
036091bb63 Unify plugin ui with standard UI; add prepareFeeDisplay and prepareChainIdDisplay 2021-06-29 16:04:38 +02:00
pscott
0bff1de52c Add setting to display detailed fees 2021-06-29 16:04:38 +02:00
pscott
bb6f65ad75 Add comment, remove debug 2021-06-29 16:04:38 +02:00
pscott
df4fe3c0dd Implement support for EIP1559; No settings 2021-06-29 16:04:38 +02:00
pscott
0dbb693c59 clang-format 2021-06-08 10:25:15 +02:00
pscott
a61a155d0b Add additionalScreens field 2021-06-08 10:25:15 +02:00
pscott
b651f530be Put externalPluginIsSet as its own global; initialize it at launch 2021-06-08 10:24:51 +02:00
pscott
8592a22542 Clang-format 2021-06-08 10:24:51 +02:00
pscott
3b6fd0d169 Undo testing commit 2021-06-08 10:24:51 +02:00
pscott
632e6b3233 Properly handle return value of eth_plugin_call 2021-06-08 10:24:51 +02:00
pscott
d029e9f635 Print ticker only if it's present 2021-06-08 10:24:51 +02:00
pscott
6b309c2676 Add printf and adapt logic for provideToken 2021-06-08 10:24:51 +02:00
pscott
4780893ac5 Put back os_perso_derive_eip2333 in getEth2PublicKey 2021-06-08 10:24:51 +02:00
TamtamHero
ec1a0d1128 test key + disable bls sigs 2021-06-08 10:24:51 +02:00
TamtamHero
40664a65f1 Fix issues due to base64(contractAddr) removal 2021-06-08 10:24:51 +02:00
pscott
5fd27ff5ca Use INT256_LENGTH and ADDRESS_LENGTH define 2021-06-08 10:24:51 +02:00
TamtamHero
0bd5fa717e Add Ledger signature checking for external plugins 2021-06-08 10:24:51 +02:00
TamtamHero
f096e91690 Add contract address and selector to setExternalPlugin 2021-06-08 10:24:50 +02:00
TamtamHero
b821c0d8a7 Add setExternalPlugin command 2021-06-08 10:24:50 +02:00
pscott
f250865bcb Merge branch 'master' of github.com:LedgerHQ/app-ethereum into fix_security_and_display_issues 2021-05-04 12:14:44 +02:00
pscott
c7ec0c7dfa Use %d flag instead of %u 2021-04-28 11:39:47 +02:00
pscott
ebffb48cd3 Use snprintf instead of u32_to_str 2021-04-28 10:48:18 +02:00