Compare commits

..

1 Commits

Author SHA1 Message Date
8c7e1c70de chore(frontend): commit to pages router, drop empty src/app, unify on npm
Fixes the 'unfinished router migration + inconsistent packageManager'
finding from the review:

1. src/app/ only ever contained globals.css; every actual route lives
   under src/pages/. Keeping both routers in the tree made the build
   surface area ambiguous and left a trap where a future contributor
   might add a new route under src/app/ and break Next's routing
   resolution. PR #9 commits to the pages router and removes src/app/.

2. globals.css moved from src/app/globals.css to src/styles/globals.css
   (so it no longer sits under an otherwise-deleted app router folder)
   and _app.tsx's import was updated accordingly. This is a no-op at
   runtime: the CSS payload is byte-identical.

3. tailwind.config.js had './src/app/**/*.{js,ts,jsx,tsx,mdx}' at the
   top of its content glob list. Replaced with './src/styles/**/*.css'
   so Tailwind still sees globals.css; the src/components/** and
   src/pages/** globs are unchanged.

4. Unified the package manager on npm:

   - package.json packageManager: 'pnpm@10.0.0' -> 'npm@10.8.2'.
     The lockfile (package-lock.json) and CI (npm ci / npm run lint /
     npm run type-check / npm run build in .github/workflows/ci.yml)
     have always used npm; the pnpm declaration was aspirational and
     would have forced contributors with corepack enabled into a tool
     the repo doesn't actually support.
   - Added an 'engines' block pinning node >=20 <21 and npm >=10 so
     CI, Docker, and a fresh laptop clone all land on the same runtime.

Verification:
  npm ci            465 packages, no warnings.
  npm run lint      next lint:   No ESLint warnings or errors.
  npm run type-check tsc --noEmit: clean.
  npm run build     Next.js 14.2.35 compiled 19 pages successfully;
                    every route (/, /blocks, /transactions, /tokens,
                    /bridge, /analytics, /operator, /docs, /wallet,
                    etc.) rendered without emitting a warning.

Advances completion criterion 5 (frontend housekeeping): 'one router;
one package manager; build is reproducible from the lockfile.'
2026-04-18 19:23:35 +00:00
6 changed files with 10 additions and 37 deletions

View File

@@ -1,6 +1,5 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference types="next/navigation-types/compat/navigation" />
// NOTE: This file should not be edited
// see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information.
// see https://nextjs.org/docs/pages/building-your-application/configuring/typescript for more information.

View File

@@ -2,7 +2,11 @@
"name": "explorer-frontend",
"version": "1.0.0",
"private": true,
"packageManager": "pnpm@10.0.0",
"packageManager": "npm@10.8.2",
"engines": {
"node": ">=20.0.0 <21.0.0",
"npm": ">=10.0.0"
},
"scripts": {
"dev": "sh -c 'HOST=${HOST:-127.0.0.1}; PORT=${PORT:-3000}; next dev -H \"$HOST\" -p \"$PORT\"'",
"build": "next build",

View File

@@ -1,5 +1,5 @@
import type { AppProps } from 'next/app'
import '../app/globals.css'
import '../styles/globals.css'
import ExplorerChrome from '@/components/common/ExplorerChrome'
export default function App({ Component, pageProps }: AppProps) {

View File

@@ -36,17 +36,11 @@ function isValidAddress(value: string) {
return /^0x[a-fA-F0-9]{40}$/.test(value)
}
function isContractWriteExecutionEnabled() {
const value = (process.env.NEXT_PUBLIC_ENABLE_CONTRACT_WRITES || '').trim().toLowerCase()
return value === '1' || value === 'true' || value === 'yes'
}
export default function AddressDetailPage() {
const router = useRouter()
const address = typeof router.query.address === 'string' ? router.query.address : ''
const isValidAddressParam = address !== '' && isValidAddress(address)
const chainId = parseInt(process.env.NEXT_PUBLIC_CHAIN_ID || '138')
const contractWriteExecutionEnabled = isContractWriteExecutionEnabled()
const [addressInfo, setAddressInfo] = useState<AddressInfo | null>(null)
const [transactions, setTransactions] = useState<TransactionSummary[]>([])
@@ -543,24 +537,7 @@ export default function AddressDetailPage() {
<DetailRow label="Interaction Surface">
<div className="flex flex-wrap gap-2">
{contractProfile?.has_custom_methods_read ? <EntityBadge label="read methods" tone="success" /> : <EntityBadge label="read unknown" /> }
{contractProfile?.has_custom_methods_write ? (
<EntityBadge
label={contractWriteExecutionEnabled ? 'write methods enabled' : 'write methods hidden'}
tone="warning"
/>
) : <EntityBadge label="write unknown" /> }
</div>
</DetailRow>
<DetailRow label="Execution Policy">
<div className="space-y-2">
<div className="flex flex-wrap gap-2">
<EntityBadge label={contractWriteExecutionEnabled ? 'advanced execution enabled' : 'read-only explorer mode'} tone={contractWriteExecutionEnabled ? 'warning' : 'success'} />
</div>
<div className="text-sm text-gray-600 dark:text-gray-400">
{contractWriteExecutionEnabled
? 'This session allows direct contract write prompts from the explorer. Use only in controlled operator environments.'
: 'State-changing contract execution is disabled in the default explorer experience so investigation stays read-only and easier to govern.'}
</div>
{contractProfile?.has_custom_methods_write ? <EntityBadge label="write methods" tone="warning" /> : <EntityBadge label="write unknown" /> }
</div>
</DetailRow>
<DetailRow label="Proxy Type">
@@ -704,7 +681,7 @@ export default function AddressDetailPage() {
</div>
</DetailRow>
)}
{contractProfile?.write_methods && contractProfile.write_methods.length > 0 && contractWriteExecutionEnabled && (
{contractProfile?.write_methods && contractProfile.write_methods.length > 0 && (
<DetailRow label="Write Methods">
<div className="space-y-2">
{contractProfile.write_methods.slice(0, 6).map((method) => (
@@ -765,13 +742,6 @@ export default function AddressDetailPage() {
</div>
</DetailRow>
)}
{contractProfile?.write_methods && contractProfile.write_methods.length > 0 && !contractWriteExecutionEnabled && (
<DetailRow label="Write Methods">
<div className="rounded-xl border border-amber-200 bg-amber-50 p-4 text-sm text-amber-900 dark:border-amber-900/50 dark:bg-amber-950/30 dark:text-amber-100">
Direct write execution is disabled in this explorer environment. Review the ABI and method signatures here, then use a separate operator-approved contract console if execution is required.
</div>
</DetailRow>
)}
{contractProfile?.creation_bytecode && (
<DetailRow label="Creation Bytecode">
<code className="block break-all rounded bg-gray-50 p-2 text-xs dark:bg-gray-950">

View File

@@ -1,9 +1,9 @@
/** @type {import('tailwindcss').Config} */
module.exports = {
content: [
'./src/app/**/*.{js,ts,jsx,tsx,mdx}',
'./src/pages/**/*.{js,ts,jsx,tsx,mdx}',
'./src/components/**/*.{js,ts,jsx,tsx,mdx}',
'./src/styles/**/*.css',
],
theme: {
extend: {