fix: validate numeric office id on money-supply route
Some checks failed
CI/CD Pipeline / Solidity Contracts (push) Failing after 1m16s
CI/CD Pipeline / Security Scanning (push) Successful in 2m27s
CI/CD Pipeline / Lint and Format (push) Failing after 44s
CI/CD Pipeline / Terraform Validation (push) Failing after 26s
CI/CD Pipeline / Kubernetes Validation (push) Successful in 27s
Validation / validate-genesis (push) Successful in 30s
Validation / validate-terraform (push) Failing after 28s
Validation / validate-kubernetes (push) Failing after 11s
Validation / validate-smart-contracts (push) Failing after 10s
Validation / validate-security (push) Failing after 1m21s
Validation / validate-documentation (push) Failing after 17s
Some checks failed
CI/CD Pipeline / Solidity Contracts (push) Failing after 1m16s
CI/CD Pipeline / Security Scanning (push) Successful in 2m27s
CI/CD Pipeline / Lint and Format (push) Failing after 44s
CI/CD Pipeline / Terraform Validation (push) Failing after 26s
CI/CD Pipeline / Kubernetes Validation (push) Successful in 27s
Validation / validate-genesis (push) Successful in 30s
Validation / validate-terraform (push) Failing after 28s
Validation / validate-kubernetes (push) Failing after 11s
Validation / validate-smart-contracts (push) Failing after 10s
Validation / validate-security (push) Failing after 1m21s
Validation / validate-documentation (push) Failing after 17s
Avoid TypeScript express param regex; return 404 for non-numeric ids like public. Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
@@ -101,10 +101,14 @@ export function createSettlementRouter(): Router {
|
||||
}
|
||||
});
|
||||
|
||||
router.get('/money-supply/:officeIdParam(\\d+)', async (req, res) => {
|
||||
router.get('/money-supply/:officeIdParam', async (req, res) => {
|
||||
if (!requireApiKey(req, res)) return;
|
||||
const requested = parseInt(req.params.officeIdParam, 10);
|
||||
if (!Number.isFinite(requested)) {
|
||||
res.status(404).json({ error: 'Not found' });
|
||||
return;
|
||||
}
|
||||
try {
|
||||
const requested = parseInt(req.params.officeIdParam, 10);
|
||||
res.json(await getMoneySupply(settlementOfficeId(requested)));
|
||||
} catch (e) {
|
||||
res.status(400).json({ error: e instanceof Error ? e.message : String(e) });
|
||||
|
||||
Reference in New Issue
Block a user